Migrate `print-target-list` to `rmake` and `print-calling-convention` to ui-test by Rejyr · Pull Request #127877 · rust-lang/rust

Rejyr · 2024-07-17T21:19:47Z

try-job: x86_64-gnu-llvm-18
try-job: test-various
try-job: armhf-gnu
try-job: aarch64-apple
try-job: i686-mingw
try-job: x86_64-msvc

rustbot · 2024-07-17T21:19:56Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

tgross35 · 2024-07-17T21:36:53Z

Could you add checks that the output has a trailing newline? Just since we have missed them before (https://github.com/rust-lang/rust/pull/127512/files)

tests/run-make/print-target-list/rmake.rs

tests/run-make/print-calling-conventions/rmake.rs

tests/run-make/print-cfg/rmake.rs

tests/run-make/print-target-list/rmake.rs

jieyouxu · 2024-07-18T03:15:21Z

Marking this as blocked on the pending discussions in #127895.
@rustbot blocked (waiting for more info from #127895)

jieyouxu · 2024-07-18T15:33:24Z

@rustbot review

tests/run-make/print-target-list/rmake.rs

jieyouxu · 2024-07-19T14:37:44Z

@rustbot author

bors · 2024-07-25T06:41:45Z

☔ The latest upstream changes (presumably #128169) made this pull request unmergeable. Please resolve the merge conflicts.

[EXPERIMENTAL] try to see how to make `print-target-list` pass Experiments for rust-lang#127877. r? `@ghost` try-job: x86_64-gnu-llvm-18

jieyouxu

I finally found out why we were struggling...

tests/run-make/print-target-list/Makefile

tests/run-make/print-target-list/rmake.rs

jieyouxu

Cool, I'll run a couple of try job to double-check.

jieyouxu · 2024-08-04T03:46:27Z

@bors try

bors · 2024-08-04T03:47:37Z

⌛ Trying commit 36cf385 with merge cb916b6...

Migrate `print-target-list` to `rmake` and `print-calling-convention` to ui-test Part of rust-lang#121876. r? `@jieyouxu` try-job: x86_64-gnu-llvm-18 try-job: test-various try-job: armhf-gnu try-job: aarch64-apple try-job: i686-mingw try-job: x86_64-msvc

bors · 2024-08-04T06:03:11Z

☀️ Try build successful - checks-actions
Build commit: cb916b6 (cb916b6a99b6275c0044407fc7a8c9083a0a5c73)

jieyouxu · 2024-08-04T06:39:19Z

@bors r+ rollup=iffy

bors · 2024-08-04T06:39:21Z

📌 Commit 36cf385 has been approved by jieyouxu

It is now in the queue for this repository.

bors · 2024-08-04T09:31:27Z

⌛ Testing commit 36cf385 with merge 58fb508...

bors · 2024-08-04T11:56:52Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 58fb508 to master...

rust-timer · 2024-08-04T13:14:37Z

Finished benchmarking commit (58fb508): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Cycles

Results (primary 1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.3%	[1.3%, 1.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 758.686s -> 757.27s (-0.19%)
Artifact size: 336.83 MiB -> 336.80 MiB (-0.01%)

rustbot assigned jieyouxu Jul 17, 2024

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc labels Jul 17, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 17, 2024

Rejyr force-pushed the migrate-print-rmake branch from 31c57e7 to 328c34f Compare July 17, 2024 21:29

This comment has been minimized.

Sign in to view

Rejyr force-pushed the migrate-print-rmake branch from bc5d27e to 65cab6f Compare July 17, 2024 23:06

This comment has been minimized.

Sign in to view

Rejyr mentioned this pull request Jul 18, 2024

Add trailing newline check for rustc --print in run-make-support #127887

Closed

Rejyr commented Jul 18, 2024

View reviewed changes

tests/run-make/print-target-list/rmake.rs Show resolved Hide resolved

jieyouxu mentioned this pull request Jul 18, 2024

tests/run-make/print-target-list --print=sysroot check fails for experimental llvm targets #127895

Closed

jieyouxu requested changes Jul 18, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2024

rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2024

Kobzol mentioned this pull request Jul 18, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Closed

Rejyr force-pushed the migrate-print-rmake branch from 65cab6f to a4259f6 Compare July 18, 2024 15:22

Rejyr changed the title ~~Migrate print-calling-convention and print-target-list to rmake~~ Migrate print-target-list to rmake and print-calling-convention to ui-test Jul 18, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jul 18, 2024

This comment has been minimized.

Sign in to view

jieyouxu reviewed Jul 19, 2024

View reviewed changes

tests/run-make/print-target-list/rmake.rs Show resolved Hide resolved

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2024

jieyouxu mentioned this pull request Jul 22, 2024

[EXPERIMENTAL] try to see how to make print-target-list pass #128073

Closed

jieyouxu requested changes Aug 3, 2024

View reviewed changes

tests/run-make/print-target-list/Makefile Show resolved Hide resolved

tests/run-make/print-target-list/rmake.rs Outdated Show resolved Hide resolved

tests/run-make/print-target-list/rmake.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2024

Rejyr added 3 commits August 3, 2024 20:09

Migrate run-make/print-calling-conventions to ui-test

3a41a11

Migrate print-target-list to rmake

1ca959e

Ensure Rustc::print use in rmake tests

36cf385

Rejyr force-pushed the migrate-print-rmake branch from c38861b to 36cf385 Compare August 4, 2024 03:12

jieyouxu approved these changes Aug 4, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 4, 2024

bors merged commit 58fb508 into rust-lang:master Aug 4, 2024

rustbot added this to the 1.82.0 milestone Aug 4, 2024

This was referenced Aug 4, 2024

Migrate raw-dylib-alt-calling-convention, raw-dylib-c and redundant-libs run-make tests to rmake #128107

Merged

Migrate pdb-buildinfo-cl-cmd and pgo-indirect-call-promotion run-make tests to rmake #128363

Merged

Rejyr deleted the migrate-print-rmake branch August 4, 2024 13:56

Uh oh!

Conversation

Rejyr commented Jul 17, 2024 • edited by jieyouxu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 17, 2024

Uh oh!

tgross35 commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Jul 18, 2024

Uh oh!

jieyouxu commented Jul 18, 2024

Uh oh!

This comment has been minimized.

Uh oh!

jieyouxu commented Jul 19, 2024

Uh oh!

bors commented Jul 25, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Aug 4, 2024

Uh oh!

bors commented Aug 4, 2024

Uh oh!

bors commented Aug 4, 2024

Uh oh!

jieyouxu commented Aug 4, 2024

Uh oh!

bors commented Aug 4, 2024

Uh oh!

bors commented Aug 4, 2024

Uh oh!

bors commented Aug 4, 2024

Uh oh!

rust-timer commented Aug 4, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Rejyr commented Jul 17, 2024 •

edited by jieyouxu

Loading

tgross35 commented Jul 17, 2024 •

edited

Loading