Migrate `interdependent-c-libraries`, `compiler-rt-works-on-mingw` and `incr-foreign-head-span` `run-make` tests to rmake by Oneirical · Pull Request #127989 · rust-lang/rust

Oneirical · 2024-07-19T20:03:09Z

Part of #121876 and the associated Google Summer of Code project.

try-job: aarch64-apple
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-mingw
try-job: x86_64-msvc
try-job: x86_64-gnu-llvm-18

rustbot · 2024-07-19T20:03:16Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-07-19T20:03:18Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

Urgau · 2024-07-19T21:43:08Z

@bors try

bors · 2024-07-19T21:44:18Z

⌛ Trying commit b6b975d with merge a1f38cb...

Migrate `interdependent-c-libraries`, `compiler-rt-works-on-mingw` and `incr-foreign-head-span` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-mingw try-job: test-various

bors · 2024-07-19T22:21:04Z

💔 Test failed - checks-actions

bors · 2024-07-20T12:02:43Z

☔ The latest upstream changes (presumably #127998) made this pull request unmergeable. Please resolve the merge conflicts.

Oneirical · 2024-07-22T14:09:57Z

@rustbot review
Please run bors try, ignore restored in interdependent-c-libraries.

jieyouxu · 2024-07-22T14:14:21Z

@bors try

jieyouxu · 2024-07-22T14:14:28Z

@bors delegate+ (for try jobs)

bors · 2024-07-22T14:14:30Z

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

bors · 2024-07-22T14:15:32Z

⌛ Trying commit ba78a9e with merge 29179f4...

Migrate `interdependent-c-libraries`, `compiler-rt-works-on-mingw` and `incr-foreign-head-span` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-mingw

bors · 2024-07-22T16:12:03Z

☀️ Try build successful - checks-actions
Build commit: 29179f4 (29179f451c2a88521b890f20e1ca206619ef49dd)

jieyouxu

Thanks, the changes look reasonable, just some minor nits.

tests/run-make/compiler-rt-works-on-mingw/rmake.rs

src/tools/run-make-support/src/external_deps/cc.rs

tests/run-make/compiler-rt-works-on-mingw/rmake.rs

jieyouxu · 2024-07-22T16:47:29Z

@rustbot author

jieyouxu · 2024-07-22T17:27:13Z

@bors try

Migrate `interdependent-c-libraries`, `compiler-rt-works-on-mingw` and `incr-foreign-head-span` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: aarch64-apple try-job: armhf-gnu try-job: test-various try-job: x86_64-mingw try-job: x86_64-msvc try-job: x86_64-gnu-llvm-18

bors · 2024-07-22T17:28:25Z

⌛ Trying commit 3085334 with merge 6ab1b97...

bors · 2024-07-22T19:41:12Z

☀️ Try build successful - checks-actions
Build commit: 6ab1b97 (6ab1b972313b2135e0622b3cd9f4a1d36fb4d1d5)

jieyouxu

Thanks!

jieyouxu · 2024-07-25T01:55:34Z

This needs a rebase for the tidy list, r=me after that.
@bors delegate+

bors · 2024-07-25T01:55:36Z

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

jieyouxu · 2024-07-25T01:56:14Z

@bors rollup=iffy (cxx, incremental, native libs)

jieyouxu · 2024-07-25T01:56:50Z

@rustbot author

Oneirical · 2024-07-25T15:10:05Z

@bors r=@jieyouxu

bors · 2024-07-25T15:10:07Z

📌 Commit e175b83 has been approved by jieyouxu

It is now in the queue for this repository.

Rollup of 7 pull requests Successful merges: - rust-lang#126575 (Make it crystal clear what lint `type_alias_bounds` actually signifies) - rust-lang#127017 (Extend rules of dead code analysis for impls for adts to impls for types refer to adts) - rust-lang#127523 (Migrate `dump-ice-to-disk` and `panic-abort-eh_frame` `run-make` tests to rmake) - rust-lang#127557 (Add a label to point to the lacking macro name definition) - rust-lang#127989 (Migrate `interdependent-c-libraries`, `compiler-rt-works-on-mingw` and `incr-foreign-head-span` `run-make` tests to rmake) - rust-lang#128099 (migrate tests/run-make/extern-flag-disambiguates to rmake) - rust-lang#128170 (Make Clone::clone a lang item) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#127989 - Oneirical:testricted-area, r=jieyouxu Migrate `interdependent-c-libraries`, `compiler-rt-works-on-mingw` and `incr-foreign-head-span` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: aarch64-apple try-job: armhf-gnu try-job: test-various try-job: x86_64-mingw try-job: x86_64-msvc try-job: x86_64-gnu-llvm-18

rustbot assigned jieyouxu Jul 19, 2024

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2024

jieyouxu mentioned this pull request Jul 20, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Closed

Oneirical force-pushed the testricted-area branch 2 times, most recently from 669f6cd to ba78a9e Compare July 22, 2024 14:09

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2024

jieyouxu approved these changes Jul 22, 2024

View reviewed changes

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2024

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 22, 2024

Oneirical force-pushed the testricted-area branch from ba78a9e to 3085334 Compare July 22, 2024 17:18

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2024

jieyouxu approved these changes Jul 25, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2024

Oneirical added 3 commits July 25, 2024 11:07

rewrite interdependent-c-libraries to rmake

4dad2a3

rewrite compiler-rt-works-on-mingw to rmake

c424bc6

rewrite incr-foreign-head-span to rmake

e175b83

Oneirical force-pushed the testricted-area branch from 3085334 to e175b83 Compare July 25, 2024 15:09

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 25, 2024

tgross35 mentioned this pull request Jul 26, 2024

Rollup of 7 pull requests #128222

Merged

bors merged commit 4290de8 into rust-lang:master Jul 26, 2024

rustbot added this to the 1.82.0 milestone Jul 26, 2024

Uh oh!

Conversation

Oneirical commented Jul 19, 2024 • edited by jieyouxu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 19, 2024

Uh oh!

rustbot commented Jul 19, 2024

Uh oh!

Urgau commented Jul 19, 2024

Uh oh!

bors commented Jul 19, 2024

Uh oh!

This comment has been minimized.

bors commented Jul 19, 2024

Uh oh!

bors commented Jul 20, 2024

Uh oh!

Oneirical commented Jul 22, 2024

Uh oh!

jieyouxu commented Jul 22, 2024

Uh oh!

jieyouxu commented Jul 22, 2024

Uh oh!

bors commented Jul 22, 2024

Uh oh!

bors commented Jul 22, 2024

Uh oh!

bors commented Jul 22, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Jul 22, 2024

Uh oh!

jieyouxu commented Jul 22, 2024

Uh oh!

bors commented Jul 22, 2024

Uh oh!

bors commented Jul 22, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jul 25, 2024

Uh oh!

bors commented Jul 25, 2024

Uh oh!

jieyouxu commented Jul 25, 2024

Uh oh!

jieyouxu commented Jul 25, 2024

Uh oh!

Oneirical commented Jul 25, 2024

Uh oh!

bors commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Oneirical commented Jul 19, 2024 •

edited by jieyouxu

Loading