Closed
Conversation
doing so requires overwriting global cache entries and generally adds significant complexity to the solver. This is also only ever done for root goals, so it feels easier to wrap the `evaluate_canonical_goal` in an ordinary query if necessary.
this allows us to only sometimes disable the global cache.
this makes it easier to maintain and modify going forward. There may be a small performance cost as we now need to access the provisional cache *and* walk through the stack to detect cycles. However, the provisional cache should be mostly empty and the stack should only have a few elements so the performance impact is likely minimal. Given the complexity of the search graph maintainability trumps linear performance improvements.
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
Collaborator
|
☔ The latest upstream changes (presumably #127042) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
approved these changes
Aug 5, 2024
Contributor
compiler-errors
left a comment
compiler-errors
left a comment
There was a problem hiding this comment.
r=me. sorry, I thought I approved this.
| [] dtorck_constraint: rustc_middle::traits::query::DropckConstraint<'tcx>, | ||
| [] candidate_step: rustc_middle::traits::query::CandidateStep<'tcx>, | ||
| [] autoderef_bad_ty: rustc_middle::traits::query::MethodAutoderefBadTy<'tcx>, | ||
| [] canonical_goal_evaluation: |
Contributor
There was a problem hiding this comment.
such cleanup
(un)surprised to see how much additional complexity caching proof trees was adding lol
compiler-errors
added
S-waiting-on-author
Contributor
|
Closing in favor of #128828 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commits should be reviewed individually. this PR does yet again not contain any behavior changes. continues the work from #127627. the fuzzer implementation can be found in https://github.com/lcnr/search_graph_fuzz, even if that repository is not documented yet.
r? @compiler-errors