Add a set of tests for LLVM 19 by dianqk · Pull Request #128584 · rust-lang/rust

dianqk · 2024-08-03T04:52:23Z

Close #107681. Close #118306. Close #126585.

r? compiler

dianqk · 2024-08-03T04:53:00Z

tests/codegen/issues/issue-107681-unwrap_unchecked.rs

+    // CHECK-NOT: select
+    // CHECK: [[RET:%.*]] = load i32, ptr
+    // CHECK-NEXT: ret i32 [[RET]]
+    x.next().unwrap_unchecked()


https://godbolt.org/z/86WcqPssP

dianqk · 2024-08-03T04:53:25Z

tests/codegen/issues/issue-118306.rs

+    // CHECK-NEXT:    [[SWITCH_GEP:%.*]] = getelementptr inbounds [4 x i64], ptr @switch.table.branchy, i64 0, i64 [[_2]]
+    // CHECK-NEXT:    [[SWITCH_LOAD:%.*]] = load i64, ptr [[SWITCH_GEP]]
+    // CHECK-NEXT:    ret i64 [[SWITCH_LOAD]]
+    match input % 4 {


https://godbolt.org/z/4zqePjKbo

dianqk · 2024-08-03T04:53:42Z

tests/assembly/issues/issue-126585.rs

+    // CHECK: [[L1]]:
+    // CHECK-NOT: .{{.*}}:
+    // CHECK: ret
+    match b {


https://rust.godbolt.org/z/s9arM1vcW

nikic · 2024-08-03T07:44:43Z

tests/assembly/issues/issue-126585.rs

+#![crate_type = "lib"]
+
+#[no_mangle]
+fn checked_div_round(a: u64, b: u64) -> Option<u64> {


I think it would be better to check that the IR does not have the extra undef phi input.

At least for this case, I think so.

nikic · 2024-08-03T10:25:49Z

@bors r+ rollup=iffy

bors · 2024-08-03T10:25:51Z

📌 Commit 272bfb9 has been approved by nikic

It is now in the queue for this repository.

yotamofek · 2024-08-03T11:50:10Z

tests/codegen/issues/issue-126585.rs

+// Ensure that this IR doesn't has extra undef phi input, which also guarantees that this asm
+// doesn't has subsequent labels and unnecessary `jmp` instructions.


Drive-by spellchecking 😄

Suggested change

// Ensure that this IR doesn't has extra undef phi input, which also guarantees that this asm

// doesn't has subsequent labels and unnecessary `jmp` instructions.

// Ensure that this IR doesn't have extra undef phi input, which also guarantees that this asm

// doesn't have subsequent labels and unnecessary `jmp` instructions.

Oops, thanks!

dianqk · 2024-08-03T12:05:05Z

@bors r-

nikic · 2024-08-03T18:25:29Z

@bors r+

bors · 2024-08-03T18:25:31Z

📌 Commit 3e5429e has been approved by nikic

It is now in the queue for this repository.

bors · 2024-08-04T21:12:49Z

⌛ Testing commit 3e5429e with merge df62a42...

Add a set of tests for LLVM 19 Close rust-lang#107681. Close rust-lang#118306. Close rust-lang#126585. r? compiler

bors · 2024-08-04T21:55:30Z

💔 Test failed - checks-actions

dianqk · 2024-08-04T23:22:35Z

@bors try

Add a set of tests for LLVM 19 Close rust-lang#107681. Close rust-lang#118306. Close rust-lang#126585. r? compiler try-job: i686-msvc try-job: arm-android try-job: test-various

bors · 2024-08-04T23:23:45Z

⌛ Trying commit 5a25b05 with merge 193a169...

bors · 2024-08-05T00:17:28Z

💔 Test failed - checks-actions

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#128384 (Add tests to ensure MTE tags are preserved across FFI boundaries) - rust-lang#128407 (Migrate `min-global-align` and `no-alloc-shim` `run-make` tests to rmake) - rust-lang#128584 (Add a set of tests for LLVM 19) - rust-lang#128636 (migrate `thumb-none-cortex-m` to rmake) - rust-lang#128696 (Migrate `staticlib-dylib-linkage` `run-make` test to rmake) Failed merges: - rust-lang#128639 (migrate `thumb-none-qemu` to rmake) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-08-07T17:34:04Z

@bors r-
#128785 (comment)

dianqk · 2024-08-08T02:44:16Z

It appears to be caused by the ABI of i686, which should also be fixable. However, for this test, I'm not sure which is more appropriate: ignore-x86, only-64bit, or only-x86_64.

nikic · 2024-08-08T09:07:13Z

I'd go back to the original version without no-jump-table and only-x86_64.

dianqk · 2024-08-08T10:14:11Z

Sounds good, thanks, done at https://github.com/rust-lang/rust/compare/d432330181ba1d2cecc72238abde6d7abc3c1272..b5c453d7a28ab156dd6e2ed81674500cb1dbe7ec.

nikic · 2024-08-08T20:15:39Z

@bors r+ rollup=never

bors · 2024-08-08T20:15:41Z

📌 Commit b5c453d has been approved by nikic

It is now in the queue for this repository.

bors · 2024-08-09T07:33:51Z

⌛ Testing commit b5c453d with merge c80d992...

Add a set of tests for LLVM 19 Close rust-lang#107681. Close rust-lang#118306. Close rust-lang#126585. r? compiler

rust-log-analyzer · 2024-08-09T11:34:47Z

The job dist-apple-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2024-08-09T11:34:55Z

💔 Test failed - checks-actions

dianqk · 2024-08-09T12:27:40Z

@bors retry

bors · 2024-08-10T01:59:58Z

⌛ Testing commit b5c453d with merge 69b380d...

bors · 2024-08-10T04:25:26Z

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 69b380d to master...

rust-timer · 2024-08-10T06:39:08Z

Finished benchmarking commit (69b380d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 5.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.1%	[3.3%, 6.0%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 762.964s -> 763.399s (0.06%)
Artifact size: 339.32 MiB -> 339.30 MiB (-0.01%)

rustbot assigned wesleywiser Aug 3, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2024

dianqk commented Aug 3, 2024

View reviewed changes

nikic reviewed Aug 3, 2024

View reviewed changes

dianqk force-pushed the tests-for-llvm-19 branch from 6a37129 to 272bfb9 Compare August 3, 2024 08:09

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2024

yotamofek reviewed Aug 3, 2024

View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 3, 2024

dianqk force-pushed the tests-for-llvm-19 branch from 272bfb9 to 3e5429e Compare August 3, 2024 12:06

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 3, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 4, 2024

Auto merge of rust-lang#128584 - DianQK:tests-for-llvm-19, r=nikic

df62a42

Add a set of tests for LLVM 19 Close rust-lang#107681. Close rust-lang#118306. Close rust-lang#126585. r? compiler

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 4, 2024

dianqk force-pushed the tests-for-llvm-19 branch from 3e5429e to 5a25b05 Compare August 4, 2024 22:16

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 7, 2024

dianqk force-pushed the tests-for-llvm-19 branch from d432330 to 6251df7 Compare August 8, 2024 10:06

Add a set of tests for LLVM 19

b5c453d

dianqk force-pushed the tests-for-llvm-19 branch from 6251df7 to b5c453d Compare August 8, 2024 10:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 8, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 9, 2024

Auto merge of rust-lang#128584 - DianQK:tests-for-llvm-19, r=nikic

c80d992

Add a set of tests for LLVM 19 Close rust-lang#107681. Close rust-lang#118306. Close rust-lang#126585. r? compiler

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 10, 2024

bors merged commit 69b380d into rust-lang:master Aug 10, 2024

rustbot added this to the 1.82.0 milestone Aug 10, 2024

dianqk deleted the tests-for-llvm-19 branch August 10, 2024 05:06

		// Ensure that this IR doesn't has extra undef phi input, which also guarantees that this asm
		// doesn't has subsequent labels and unnecessary `jmp` instructions.

Uh oh!

Conversation

dianqk commented Aug 3, 2024 • edited by nikic Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikic commented Aug 3, 2024

Uh oh!

bors commented Aug 3, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dianqk commented Aug 3, 2024

Uh oh!

nikic commented Aug 3, 2024

Uh oh!

bors commented Aug 3, 2024

Uh oh!

bors commented Aug 4, 2024

Uh oh!

This comment has been minimized.

bors commented Aug 4, 2024

Uh oh!

dianqk commented Aug 4, 2024

Uh oh!

bors commented Aug 4, 2024

Uh oh!

This comment has been minimized.

bors commented Aug 5, 2024

Uh oh!

matthiaskrgr commented Aug 7, 2024

Uh oh!

dianqk commented Aug 8, 2024

Uh oh!

nikic commented Aug 8, 2024

Uh oh!

dianqk commented Aug 8, 2024

Uh oh!

nikic commented Aug 8, 2024

Uh oh!

bors commented Aug 8, 2024

Uh oh!

bors commented Aug 9, 2024

Uh oh!

rust-log-analyzer commented Aug 9, 2024

Uh oh!

bors commented Aug 9, 2024

Uh oh!

dianqk commented Aug 9, 2024

Uh oh!

bors commented Aug 10, 2024

Uh oh!

bors commented Aug 10, 2024

Uh oh!

rust-timer commented Aug 10, 2024

Overall result: no relevant changes - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

dianqk commented Aug 3, 2024 •

edited by nikic

Loading