Conversation
compiler-errors
left a comment
There was a problem hiding this comment.
This needs a better title that actually explained why it ICEd in the first place.
Hmm I am not sure what has caused the ICE even after checking #125918, so feel free to suggest any suitable title. |
|
there are at least 2 important questions here imo:
for the name of the test, something like |
|
Thanks for the guidance! I will ping you again after applying the change. @rustbot author |
|
I tested it on: It still ICE without Note: The compiler version used in the original issue is As of the latest nightly: It no longer ICE with or without |
|
@rustbot ready |
|
thanks @bors r+ rollup |
Add regression test Fixes rust-lang#125873
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#128306 (Update NonNull::align_offset quarantees) - rust-lang#128612 (Make `validate_mir` ensure the final MIR for all bodies) - rust-lang#128648 (Add regression test) - rust-lang#128791 (Don't implement `AsyncFn` for `FnDef`/`FnPtr` that wouldnt implement `Fn`) - rust-lang#128795 (Update E0517 message to reflect RFC 2195.) - rust-lang#128825 (rm `declared_features` field in resolver) - rust-lang#128826 (Only suggest `#[allow]` for `--warn` and `--deny` lint level flags) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#128306 (Update NonNull::align_offset quarantees) - rust-lang#128612 (Make `validate_mir` ensure the final MIR for all bodies) - rust-lang#128648 (Add regression test) - rust-lang#128749 (Mark `{f32,f64}::{next_up,next_down,midpoint}` inline) - rust-lang#128795 (Update E0517 message to reflect RFC 2195.) - rust-lang#128825 (rm `declared_features` field in resolver) - rust-lang#128826 (Only suggest `#[allow]` for `--warn` and `--deny` lint level flags) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#128648 - tiif:issue-125873, r=lcnr Add regression test Fixes rust-lang#125873
Fixes #125873