Switch to using the v2 resolver in the library #128724
Closed
tgross35 wants to merge 2 commits intorust-lang:masterfrom
Closed
Switch to using the v2 resolver in the library #128724tgross35 wants to merge 2 commits intorust-lang:masterfrom
tgross35 wants to merge 2 commits intorust-lang:masterfrom
Conversation
Pinning the resolver to v1 was done in 5abff37 ("Explicit set workspace.resolver ...") in order to suppress warnings. Since there is no specific reason not to use the new resolver and since it fixes issues, change to `resolver = "2"` in `library/`.
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
v2 resolves some dependencies differently. Run `cargo update` to make sure everything is in sync.
461a006 to
bce5f2c
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
Author
|
This will need more of the fixes from #128359. |
Collaborator
|
☔ The latest upstream changes (presumably #128805) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
@tgross35 any updates on this? thanks |
Contributor
Author
|
Unfortunately this got a bit painful with the chances to features, I never got a chance to circle back. I don't plan on working on it so anyone else is welcome to pick this up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinning the resolver to v1 was done in 5abff37 ("Explicit set workspace.resolver ...") in order to suppress warnings. Since there is no specific reason not to use the new resolver and since it fixes issues, change to
resolver = "2"inlibrary/.Split from #128359, goes with #128722 that updates the root workspace.