improve submodule updates by onur-ozkan · Pull Request #129231 · rust-lang/rust

onur-ozkan · 2024-08-18T11:29:07Z

During config parsing, some bootstrap logic (e.g., download-ci-llvm) checks certain sources (for download-ci-llvm, it's src/llvm-project) and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the update_submodule function from the Build to Config, so we can access to it during the parsing process.

Closes #122787

During config parsing, some bootstrap logic (e.g., `download-ci-llvm`) checks certain sources and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the `update_submodule` function from the `Build` to `Config` instance, so we can access to it during the parsing process. Signed-off-by: onur-ozkan <work@onurozkan.dev>

Signed-off-by: onur-ozkan <work@onurozkan.dev>

rustbot · 2024-08-18T11:29:16Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-08-18T11:29:17Z

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

Signed-off-by: onur-ozkan <work@onurozkan.dev>

Mark-Simulacrum · 2024-08-18T18:43:56Z

@bors r+

bors · 2024-08-18T18:43:59Z

📌 Commit 1ca2708 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…es, r=Mark-Simulacrum improve submodule updates During config parsing, some bootstrap logic (e.g., `download-ci-llvm`) checks certain sources (for `download-ci-llvm`, it's `src/llvm-project`) and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the `update_submodule` function from the `Build` to `Config`, so we can access to it during the parsing process. Closes rust-lang#122787

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#128084 (Suggest adding Result return type for associated method in E0277.) - rust-lang#128902 (doc: std::env::var: Returns None for names with '=' or NUL byte) - rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation) - rust-lang#129194 (Fix bootstrap test `detect_src_and_out` on Windows) - rust-lang#129231 (improve submodule updates) - rust-lang#129235 (Check that `#[may_dangle]` is properly applied) - rust-lang#129245 (Typo) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2024-08-19T05:08:02Z

@bors r- (need to update intra-doc links #129256 (comment))

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan · 2024-08-19T15:47:29Z

@bors r- (need to update intra-doc links #129256 (comment))

Thanks, done that with d2d8fa4.

@bors r=Mark-Simulacrum

bors · 2024-08-19T15:47:32Z

📌 Commit d2d8fa4 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…es, r=Mark-Simulacrum improve submodule updates During config parsing, some bootstrap logic (e.g., `download-ci-llvm`) checks certain sources (for `download-ci-llvm`, it's `src/llvm-project`) and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the `update_submodule` function from the `Build` to `Config`, so we can access to it during the parsing process. Closes rust-lang#122787

Rollup of 6 pull requests Successful merges: - rust-lang#127623 (fix: fs::remove_dir_all: treat internal ENOENT as success) - rust-lang#128627 (Special case DUMMY_SP to emit line 0/column 0 locations on DWARF platforms.) - rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation) - rust-lang#129190 (Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs) - rust-lang#129231 (improve submodule updates) - rust-lang#129257 (Allow rust staticlib to work with MSVC's /WHOLEARCHIVE) r? `@ghost` `@rustbot` modify labels: rollup

…es, r=Mark-Simulacrum improve submodule updates During config parsing, some bootstrap logic (e.g., `download-ci-llvm`) checks certain sources (for `download-ci-llvm`, it's `src/llvm-project`) and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the `update_submodule` function from the `Build` to `Config`, so we can access to it during the parsing process. Closes rust-lang#122787

Rollup of 6 pull requests Successful merges: - rust-lang#127623 (fix: fs::remove_dir_all: treat internal ENOENT as success) - rust-lang#128627 (Special case DUMMY_SP to emit line 0/column 0 locations on DWARF platforms.) - rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation) - rust-lang#129190 (Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs) - rust-lang#129231 (improve submodule updates) - rust-lang#129284 (rustdoc: animate the `:target` highlight) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127279 (use old ctx if has same expand environment during decode span) - rust-lang#127945 (Implement `debug_more_non_exhaustive`) - rust-lang#128941 ( Improve diagnostic-related lints: `untranslatable_diagnostic` & `diagnostic_outside_of_impl`) - rust-lang#129070 (Point at explicit `'static` obligations on a trait) - rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation) - rust-lang#129231 (improve submodule updates) - rust-lang#129264 (Update `library/Cargo.toml` in weekly job) - rust-lang#129284 (rustdoc: animate the `:target` highlight) - rust-lang#129302 (compiletest: use `std::fs::remove_dir_all` now that it is available) r? `@ghost` `@rustbot` modify labels: rollup

…es, r=Mark-Simulacrum improve submodule updates During config parsing, some bootstrap logic (e.g., `download-ci-llvm`) checks certain sources (for `download-ci-llvm`, it's `src/llvm-project`) and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the `update_submodule` function from the `Build` to `Config`, so we can access to it during the parsing process. Closes rust-lang#122787

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127279 (use old ctx if has same expand environment during decode span) - rust-lang#127945 (Implement `debug_more_non_exhaustive`) - rust-lang#128941 ( Improve diagnostic-related lints: `untranslatable_diagnostic` & `diagnostic_outside_of_impl`) - rust-lang#129070 (Point at explicit `'static` obligations on a trait) - rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation) - rust-lang#129231 (improve submodule updates) - rust-lang#129264 (Update `library/Cargo.toml` in weekly job) - rust-lang#129284 (rustdoc: animate the `:target` highlight) - rust-lang#129302 (compiletest: use `std::fs::remove_dir_all` now that it is available) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#129231 - onur-ozkan:improve-submodule-updates, r=Mark-Simulacrum improve submodule updates During config parsing, some bootstrap logic (e.g., `download-ci-llvm`) checks certain sources (for `download-ci-llvm`, it's `src/llvm-project`) and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the `update_submodule` function from the `Build` to `Config`, so we can access to it during the parsing process. Closes rust-lang#122787

onur-ozkan added 2 commits August 18, 2024 11:34

bypass dry_run if the command is run_always

3d0f3b2

Signed-off-by: onur-ozkan <work@onurozkan.dev>

rustbot assigned Mark-Simulacrum Aug 18, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 18, 2024

onur-ozkan force-pushed the improve-submodule-updates branch from c2b65c6 to 184fd6f Compare August 18, 2024 12:04

sync llvm submodule during config parse

1ca2708

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan force-pushed the improve-submodule-updates branch from 184fd6f to 1ca2708 Compare August 18, 2024 12:16

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2024

matthiaskrgr mentioned this pull request Aug 18, 2024

Rollup of 7 pull requests #129256

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 19, 2024

fix broken bootstrap documentation

d2d8fa4

Signed-off-by: onur-ozkan <work@onurozkan.dev>

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 19, 2024

jieyouxu mentioned this pull request Aug 20, 2024

Rollup of 6 pull requests #129300

Closed

jieyouxu mentioned this pull request Aug 20, 2024

Rollup of 6 pull requests #129304

Closed

matthiaskrgr mentioned this pull request Aug 21, 2024

Rollup of 9 pull requests #129365

Merged

jieyouxu mentioned this pull request Aug 22, 2024

Rollup of 8 pull requests #129393

Closed

bors merged commit a08a2ef into rust-lang:master Aug 22, 2024

rustbot added this to the 1.82.0 milestone Aug 22, 2024

onur-ozkan deleted the improve-submodule-updates branch August 22, 2024 08:58

Zalathar mentioned this pull request Sep 6, 2024

use download-ci-llvm=true in the default compiler config #129473

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

improve submodule updates#129231

improve submodule updates#129231
bors merged 4 commits intorust-lang:masterfrom
onur-ozkan:improve-submodule-updates

onur-ozkan commented Aug 18, 2024

Uh oh!

rustbot commented Aug 18, 2024

Uh oh!

rustbot commented Aug 18, 2024

Uh oh!

Mark-Simulacrum commented Aug 18, 2024

Uh oh!

bors commented Aug 18, 2024

Uh oh!

jieyouxu commented Aug 19, 2024

Uh oh!

onur-ozkan commented Aug 19, 2024

Uh oh!

bors commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

onur-ozkan commented Aug 18, 2024

Uh oh!

rustbot commented Aug 18, 2024

Uh oh!

rustbot commented Aug 18, 2024

Uh oh!

Mark-Simulacrum commented Aug 18, 2024

Uh oh!

bors commented Aug 18, 2024

Uh oh!

jieyouxu commented Aug 19, 2024

Uh oh!

onur-ozkan commented Aug 19, 2024

Uh oh!

bors commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants