Deny `wasm_c_abi` lint to nudge the last 25% by workingjubilee · Pull Request #129534 · rust-lang/rust

workingjubilee · 2024-08-24T22:40:46Z

This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes --cap-lints=allow when building dependencies.

The motivation is that the ecosystem has mostly taken up the versions of wasm-bindgen that are compatible in general, but ~25% or so of recent downloads remain on lower versions. However, this change might still be unnecessarily disruptive. I mostly propose it as a discussion point.

rustbot · 2024-08-24T22:40:53Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

workingjubilee · 2024-08-24T22:41:55Z

cc @daxpedda Thoughts?

daxpedda

I was considering opening a stabilization PR soon, but I think doing this first is a good idea.

alexcrichton · 2024-08-26T21:37:53Z

@bors: r=daxpedda,me

bors · 2024-08-26T21:37:56Z

📌 Commit af05882 has been approved by daxpedda,me

It is now in the queue for this repository.

bjorn3 · 2024-08-26T21:44:37Z

Shouldn't it be r=daxpedda,alexcrichton?

alexcrichton · 2024-08-26T21:46:20Z

@bors: r-

alexcrichton · 2024-08-26T21:46:39Z

@bors: r=daxpedda,alexcrichton

I am clearly a bors pro

bors · 2024-08-26T21:46:41Z

📌 Commit af05882 has been approved by daxpedda,alexcrichton

It is now in the queue for this repository.

…fcw-to-deny, r=daxpedda,alexcrichton Deny `wasm_c_abi` lint to nudge the last 25% This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes `--cap-lints=allow` when building dependencies. The motivation is that the ecosystem has mostly taken up the versions of wasm-bindgen that are compatible in general, but ~25% or so of recent downloads remain on lower versions. However, this change might still be unnecessarily disruptive. I mostly propose it as a discussion point.

…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals) - rust-lang#127912 (std: make `thread::current` available in all `thread_local!` destructors) - rust-lang#128166 (Improved `checked_isqrt` and `isqrt` methods) - rust-lang#129123 (rustdoc-json: Add test for `Self` type) - rust-lang#129366 (linker: Synchronize native library search in rustc and linker) - rust-lang#129527 (Don't use `TyKind` in a lint) - rust-lang#129534 (Deny `wasm_c_abi` lint to nudge the last 25%) - rust-lang#129640 (Re-enable android tests/benches in alloc/core) - rust-lang#129675 (allow BufReader::peek to be called on unsized types) r? `@ghost` `@rustbot` modify labels: rollup

…fcw-to-deny, r=daxpedda,alexcrichton Deny `wasm_c_abi` lint to nudge the last 25% This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes `--cap-lints=allow` when building dependencies. The motivation is that the ecosystem has mostly taken up the versions of wasm-bindgen that are compatible in general, but ~25% or so of recent downloads remain on lower versions. However, this change might still be unnecessarily disruptive. I mostly propose it as a discussion point.

…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals) - rust-lang#129123 (rustdoc-json: Add test for `Self` type) - rust-lang#129366 (linker: Synchronize native library search in rustc and linker) - rust-lang#129527 (Don't use `TyKind` in a lint) - rust-lang#129534 (Deny `wasm_c_abi` lint to nudge the last 25%) - rust-lang#129640 (Re-enable android tests/benches in alloc/core) - rust-lang#129675 (allow BufReader::peek to be called on unsized types) - rust-lang#129731 (Allow running `./x.py test compiler`) r? `@ghost` `@rustbot` modify labels: rollup

…fcw-to-deny, r=daxpedda,alexcrichton Deny `wasm_c_abi` lint to nudge the last 25% This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes `--cap-lints=allow` when building dependencies. The motivation is that the ecosystem has mostly taken up the versions of wasm-bindgen that are compatible in general, but ~25% or so of recent downloads remain on lower versions. However, this change might still be unnecessarily disruptive. I mostly propose it as a discussion point.

…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#126183 (Separate core search logic with search ui) - rust-lang#129366 (linker: Synchronize native library search in rustc and linker) - rust-lang#129403 (Ban non-array SIMD) - rust-lang#129527 (Don't use `TyKind` in a lint) - rust-lang#129534 (Deny `wasm_c_abi` lint to nudge the last 25%) - rust-lang#129640 (Re-enable android tests/benches in alloc/core) - rust-lang#129731 (Allow running `./x.py test compiler`) - rust-lang#129754 (wasi: Fix sleeping for `Duration::MAX`) r? `@ghost` `@rustbot` modify labels: rollup

…fcw-to-deny, r=daxpedda,alexcrichton Deny `wasm_c_abi` lint to nudge the last 25% This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes `--cap-lints=allow` when building dependencies. The motivation is that the ecosystem has mostly taken up the versions of wasm-bindgen that are compatible in general, but ~25% or so of recent downloads remain on lower versions. However, this change might still be unnecessarily disruptive. I mostly propose it as a discussion point.

…iaskrgr Rollup of 15 pull requests Successful merges: - rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals) - rust-lang#126183 (Separate core search logic with search ui) - rust-lang#129123 (rustdoc-json: Add test for `Self` type) - rust-lang#129366 (linker: Synchronize native library search in rustc and linker) - rust-lang#129527 (Don't use `TyKind` in a lint) - rust-lang#129534 (Deny `wasm_c_abi` lint to nudge the last 25%) - rust-lang#129640 (Re-enable android tests/benches in alloc/core) - rust-lang#129642 (Bump backtrace to 0.3.74~ish) - rust-lang#129675 (allow BufReader::peek to be called on unsized types) - rust-lang#129723 (Simplify some extern providers) - rust-lang#129724 (Remove `Option<!>` return types.) - rust-lang#129725 (Stop using `ty::GenericPredicates` for non-predicates_of queries) - rust-lang#129731 (Allow running `./x.py test compiler`) - rust-lang#129751 (interpret/visitor: make memory order iteration slightly more efficient) - rust-lang#129754 (wasi: Fix sleeping for `Duration::MAX`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#129534 - workingjubilee:ratchet-wasm-c-abi-fcw-to-deny, r=daxpedda,alexcrichton Deny `wasm_c_abi` lint to nudge the last 25% This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes `--cap-lints=allow` when building dependencies. The motivation is that the ecosystem has mostly taken up the versions of wasm-bindgen that are compatible in general, but ~25% or so of recent downloads remain on lower versions. However, this change might still be unnecessarily disruptive. I mostly propose it as a discussion point.

lqd · 2024-10-02T10:42:07Z

This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes --cap-lints=allow when building dependencies.

IIRC this lint opts out of this by being a "report in deps" FCW, right?

workingjubilee · 2024-10-03T04:06:53Z

hm. perhaps I misunderstood something then about the interactions here?

daxpedda · 2024-10-03T09:04:32Z

I played around with this a bit, but I couldn't actually see any difference between deny and warning no matter if the dependency is direct or indirect, they all end up as FCW warnings. But compiling old versions of wasm-bindgen directly does trigger a deny lint.

So this change only affects compiling wasm-bindgen directly, but not as a dependency, ergo unfortunately this PR doesn't do anything practically useful :/

I assume this needs a change in Cargo as well to work as intended?
https://github.com/rust-lang/cargo/blob/8725e78484d62c4dd0ef22bb64fb22e4af2f4a1c/src/cargo/core/compiler/future_incompat.rs#L421

workingjubilee · 2024-10-03T19:09:21Z

...well, at least it doesn't break anyone! 🫠

bjorn3 · 2024-10-03T20:17:43Z

Isn't the code that has the ABI incompatibility produced by macro expansion of #[wasm_bindgen] inside the user crate? So it would warn for every user of an old version of wasm_bindgen, but be silenced when the user of wasm_bindgen is itself a non-local dependency.

… r=workingjubilee Make the wasm_c_abi future compat warning a hard error This is the next step in getting rid of the broken C abi for wasm32-unknown-unknown. The lint was made deny-by-default in rust-lang#129534 3 months ago. This still keeps the `-Zwasm-c-abi` flag set to `legacy` by default. It will be flipped in a future PR. cc rust-lang#122532

Rollup merge of rust-lang#133951 - bjorn3:wasm_c_abi_lint_hard_error, r=workingjubilee Make the wasm_c_abi future compat warning a hard error This is the next step in getting rid of the broken C abi for wasm32-unknown-unknown. The lint was made deny-by-default in rust-lang#129534 3 months ago. This still keeps the `-Zwasm-c-abi` flag set to `legacy` by default. It will be flipped in a future PR. cc rust-lang#122532

Deny wasm_c_abi lint to nudge the last 25%

af05882

This shouldn't affect projects indirectly depending on wasm-bindgen because cargo passes `--cap-lints=allow` when building dependencies.

rustbot assigned davidtwco Aug 24, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 24, 2024

daxpedda approved these changes Aug 24, 2024

View reviewed changes

workingjubilee mentioned this pull request Aug 24, 2024

Tracking Issue for perma-unstable wasm-c-abi flag #122532

Closed

2 tasks

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2024

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 26, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2024

workingjubilee mentioned this pull request Aug 29, 2024

Rollup of 6 pull requests #129728

Closed

workingjubilee mentioned this pull request Aug 29, 2024

Rollup of 9 pull requests #129729

Closed

workingjubilee mentioned this pull request Aug 29, 2024

Rollup of 8 pull requests #129735

Closed

workingjubilee mentioned this pull request Aug 30, 2024

Rollup of 8 pull requests #129773

Closed

This was referenced Aug 31, 2024

Rollup of 17 pull requests #129807

Closed

Rollup of 15 pull requests #129809

Merged

bors merged commit 8f35a4f into rust-lang:master Aug 31, 2024

rustbot added this to the 1.82.0 milestone Aug 31, 2024

Mark-Simulacrum added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 2, 2024

rustbot mentioned this pull request Oct 2, 2024

Tracking issue for release notes of #129534: Deny wasm_c_abi lint to nudge the last 25% #131132

Closed

3 tasks

workingjubilee deleted the ratchet-wasm-c-abi-fcw-to-deny branch October 2, 2024 04:12

bjorn3 mentioned this pull request Dec 6, 2024

Make the wasm_c_abi future compat warning a hard error #133951

Merged

Uh oh!

Conversation

workingjubilee commented Aug 24, 2024

Uh oh!

rustbot commented Aug 24, 2024

Uh oh!

workingjubilee commented Aug 24, 2024

Uh oh!

daxpedda left a comment

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Aug 26, 2024

Uh oh!

bors commented Aug 26, 2024

Uh oh!

bjorn3 commented Aug 26, 2024

Uh oh!

alexcrichton commented Aug 26, 2024

Uh oh!

alexcrichton commented Aug 26, 2024

Uh oh!

bors commented Aug 26, 2024

Uh oh!

lqd commented Oct 2, 2024

Uh oh!

workingjubilee commented Oct 3, 2024

Uh oh!

daxpedda commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

workingjubilee commented Oct 3, 2024

Uh oh!

bjorn3 commented Oct 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

daxpedda commented Oct 3, 2024 •

edited

Loading