Skip to content

Do not request sanitizers for naked functions#129891

Merged
bors merged 1 commit intorust-lang:masterfrom
nikic:naked-no-san
Sep 7, 2024
Merged

Do not request sanitizers for naked functions#129891
bors merged 1 commit intorust-lang:masterfrom
nikic:naked-no-san

Conversation

@nikic
Copy link
Contributor

@nikic nikic commented Sep 2, 2024 •
edited
Loading

Naked functions can only contain inline asm, so any instrumentation inserted by sanitizers is illegal. Don't request it.

Fixes #129224.

@rustbot
Copy link
Collaborator

rustbot commented Sep 2, 2024

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 2, 2024
@jackh726
Copy link
Member

jackh726 commented Sep 2, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 2, 2024

📌 Commit cf08447 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 2, 2024
@matthiaskrgr
Rollup merge of rust-lang#129891 - nikic:naked-no-san, r=jackh726
19a6bf3 
Do not request sanitizers for naked functions

Naked functions can only contain inline asm, so any instrumentation inserted by sanitizers is illegal. Don't request it.

Fixes rust-lang#129224.
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 2, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 2, 2024
@bors
Auto merge of rust-lang#129898 - matthiaskrgr:rollup-eexd2g8, r=matth…
67e8365 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#129152 (custom/external clippy support for bootstrapping)
 - rust-lang#129529 (Add test to build crates used by r-a on stable)
 - rust-lang#129829 (Make decoding non-optional `LazyArray` panic if not set)
 - rust-lang#129860 (update `object` dependency to remove duplicate `wasmparser`)
 - rust-lang#129875 (chore: Fix typos in 'compiler' (batch 1))
 - rust-lang#129877 (chore: Fix typos in 'compiler' (batch 2))
 - rust-lang#129878 (chore: Fix typos in 'compiler' (batch 3))
 - rust-lang#129891 (Do not request sanitizers for naked functions)
 - rust-lang#129892 (Clarify language around ptrs in slice::raw)

Failed merges:

 - rust-lang#129777 (Add `unreachable_pub`, round 4)
 - rust-lang#129868 (Remove kobzol vacation status)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Sep 2, 2024

@bors r-
#129898 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2024
@nikic
Copy link
Contributor Author

nikic commented Sep 4, 2024

Adjusted whitespace so it matches both with -C opt-level=0 and -C opt-level=3.

@bors r=jackh726

@bors
Copy link
Collaborator

bors commented Sep 4, 2024

📌 Commit 1c8f5db has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 4, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#129891 - nikic:naked-no-san, r=jackh726
c6fb9d3 
Do not request sanitizers for naked functions

Naked functions can only contain inline asm, so any instrumentation inserted by sanitizers is illegal. Don't request it.

Fixes rust-lang#129224.
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 5, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 5, 2024
@bors
Auto merge of rust-lang#129985 - matthiaskrgr:rollup-trpflqk, r=matth…
d56a1a2 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#129529 (Add test to build crates used by r-a on stable)
 - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`)
 - rust-lang#129720 (Simplify DestProp memory management)
 - rust-lang#129796 (Unify scraped examples with other code examples)
 - rust-lang#129891 (Do not request sanitizers for naked functions)
 - rust-lang#129938 (Elaborate on deriving vs implementing `Copy`)

Failed merges:

 - rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Sep 5, 2024

@bors r- rollup=iffy

#129985 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2024
@nikic
Do not request sanitizers for naked functions
54ebb9d 
Naked functions can only contain inline asm, so any instrumentation
inserted by sanitizers is illegal. Don't request it.

Fixes rust-lang#129224.
@nikic
Copy link
Contributor Author

nikic commented Sep 6, 2024

@bors try

@bors
Copy link
Collaborator

bors commented Sep 6, 2024

⌛ Trying commit 54ebb9d with merge a916be2...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 6, 2024
@bors
Auto merge of rust-lang#129891 - nikic:naked-no-san, r=<try>
a916be2 
Do not request sanitizers for naked functions

Naked functions can only contain inline asm, so any instrumentation inserted by sanitizers is illegal. Don't request it.

Fixes rust-lang#129224.

try-job: test-various
@bors
Copy link
Collaborator

bors commented Sep 6, 2024

☀️ Try build successful - checks-actions
Build commit: a916be2 (a916be2a421d617b17cd2b0bd006e2f5f83cc163)

@nikic
Copy link
Contributor Author

nikic commented Sep 6, 2024

Added -Ctarget-feature=-crt-static... third time's the charm?

@bors r=jackh726

@bors
Copy link
Collaborator

bors commented Sep 6, 2024

📌 Commit 54ebb9d has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 6, 2024
@compiler-errors compiler-errors mentioned this pull request Sep 7, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2024
@bors
Auto merge of rust-lang#130066 - compiler-errors:rollup-sq6l0va, r=co…
07776a9 
…mpiler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#128871 (bypass linker configuration and cross target check for specific commands)
 - rust-lang#129468 ([testsuite][cleanup] Remove all usages of `dont_merge` hack to avoid function merging)
 - rust-lang#129614 (Adjust doc comment of Condvar::wait_while)
 - rust-lang#129840 (Implement suggestions for `elided_named_lifetimes`)
 - rust-lang#129891 (Do not request sanitizers for naked functions)
 - rust-lang#129899 (Add Suggestions for Misspelled Keywords)
 - rust-lang#129940 (s390x: Fix a regression related to backchain feature)
 - rust-lang#129987 (Don't store region in `CapturedPlace`)
 - rust-lang#130054 (Add missing quotation marks)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2024
@bors
Auto merge of rust-lang#130066 - compiler-errors:rollup-sq6l0va, r=co…
4ff16a9 
…mpiler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#128871 (bypass linker configuration and cross target check for specific commands)
 - rust-lang#129468 ([testsuite][cleanup] Remove all usages of `dont_merge` hack to avoid function merging)
 - rust-lang#129614 (Adjust doc comment of Condvar::wait_while)
 - rust-lang#129840 (Implement suggestions for `elided_named_lifetimes`)
 - rust-lang#129891 (Do not request sanitizers for naked functions)
 - rust-lang#129899 (Add Suggestions for Misspelled Keywords)
 - rust-lang#129940 (s390x: Fix a regression related to backchain feature)
 - rust-lang#129987 (Don't store region in `CapturedPlace`)
 - rust-lang#130054 (Add missing quotation marks)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6dd07e4 into rust-lang:master Sep 7, 2024
@rustbot rustbot added this to the 1.83.0 milestone Sep 7, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2024
@rust-timer
Unrolled build for rust-lang#129891
f7e7a1a 
Rollup merge of rust-lang#129891 - nikic:naked-no-san, r=jackh726

Do not request sanitizers for naked functions

Naked functions can only contain inline asm, so any instrumentation inserted by sanitizers is illegal. Don't request it.

Fixes rust-lang#129224.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.83.0

Development

Successfully merging this pull request may close these issues.

using extern "x86-interrupt" + #[naked] + kernel address sanitizer crashes compiler

6 participants

@nikic @rustbot @jackh726 @bors @matthiaskrgr @petrochenkov