Do not skip linker configuration for check builds#130135
Do not skip linker configuration for check builds#130135bors merged 1 commit intorust-lang:masterfrom
check builds#130135Conversation
|
rustbot has assigned @albertlarsan68. Use |
onur-ozkan
left a comment
There was a problem hiding this comment.
r=me once the CI is green
|
@bors p=1 |
This comment has been minimized.
This comment has been minimized.
ff4f4d2 to
9ce492f
Compare
This comment has been minimized.
This comment has been minimized.
It was causing unexpected rebuilds.
9ce492f to
c33aa86
Compare
|
@bors r=onur-ozkan |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (38e3a57): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (secondary -3.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 756.978s -> 757.15s (0.02%) |
This essentially reverts a part of #128871, to fix #130108. This is mostly a hotfix until we can figure out a better way to both avoid rebuilds and avoid configuring the linker for
x check.Skipping linker for check builds was causing unexpected rebuilds.
Fixes: #130108