Skip to content

[Clippy] Swap map_entry to use diagnostic items instead of paths#130523

Closed
GnomedDev wants to merge 1 commit intorust-lang:masterfrom
GnomedDev:clippy-map-entry-paths
Closed

[Clippy] Swap map_entry to use diagnostic items instead of paths#130523
GnomedDev wants to merge 1 commit intorust-lang:masterfrom
GnomedDev:clippy-map-entry-paths

Conversation

@GnomedDev
Copy link
Contributor

@GnomedDev GnomedDev commented Sep 18, 2024

Part of rust-lang/rust-clippy#5393, just a chore.

@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2024

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 18, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@compiler-errors
Copy link
Contributor

compiler-errors commented Sep 18, 2024

r=me when 🍏

@compiler-errors
Copy link
Contributor

compiler-errors commented Sep 18, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 18, 2024

📌 Commit 039d103 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2024
@workingjubilee workingjubilee mentioned this pull request Sep 18, 2024
Closed
@workingjubilee
Copy link
Member

workingjubilee commented Sep 19, 2024

homu thinks this can be rolled up. homu is wrong.
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2024
@bors
Copy link
Collaborator

bors commented Sep 19, 2024

☔ The latest upstream changes (presumably #130534) made this pull request unmergeable. Please resolve the merge conflicts.

@GnomedDev
Copy link
Contributor Author

GnomedDev commented Sep 19, 2024

Merging this into a larger PR to avoid merge conflicts.

@GnomedDev GnomedDev closed this Sep 19, 2024
@GnomedDev GnomedDev deleted the clippy-map-entry-paths branch September 19, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@compiler-errors compiler-errors compiler-errors approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@compiler-errors compiler-errors

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GnomedDev @rustbot @compiler-errors @bors @workingjubilee @wesleywiser