Conversation
fix grammatical issues
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Co-authored-by: Jeff Parsons <jeff@parsons.io>
|
|
||
| ## Installing from Source | ||
|
|
||
| If you really want to install from source (though this is not recommended), see |
There was a problem hiding this comment.
this is intended, as installing from source is not encouraged and not what the average user is supposed to do
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
|
Is this good to merge? @jeffparsons / @Mark-Simulacrum / @Noratrieb |
|
#130859 (comment) still seems unresolved? |
|
@AzharMithani
|
Thanks, updated |
|
@AzharMithani by resolving it they meant you need to undo that change because the »really« was there for emphasis. |
Ah, I see, however, that would be grammatically incorrect. For example, in the above statement, I could have said "that really would be grammatically incorrect" but the meaning doesn't change 👍 |
|
☔ The latest upstream changes (presumably #134096) made this pull request unmergeable. Please resolve the merge conflicts. |
@AzharMithani Also could you please resolve conflict |
|
@AzharMithani |
fixed grammatical issues