[crater] validate impact of marking more types as #[rustc_insignificant_dtor] on tail expr drop order lint

[compiler-errors]

Validate impact of #130914 on #129864 and the tail expr drop order lint.

r? @ghost

[compiler-errors]

@bors try

[bors]

⌛ Trying commit b46b6bf with merge c387b04...

[compiler-errors]

for later:

craterbot run mode=check-only p=1 crates=https://gist.githubusercontent.com/compiler-errors/cc84423a4a9fbc5eb598383fe2555467/raw/a11fe3433fefddaab0038ee75cd2e0ab8852748a/crates start=master#a3f76a26e045a760bb1163b7eab36872985242d5 end=try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order

[rust-log-analyzer]

The job x86_64-gnu-llvm-18 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

------
 > importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:30ca74372d8b771363f68f939a58b017a592fae4f69398600dc51145997160f03e9652051f957840c41898984a88855e9757fa23464703a5a4ba21316ddebb04:
------
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
  Downloaded boml v0.3.1
   Compiling boml v0.3.1
   Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
    Finished `release` profile [optimized] target(s) in 3.59s
     Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc
---

warning: unused variable: `another_droppy`
##[warning]  --> lint_example.rs:17:9
   |
17 |     let another_droppy = Droppy(0);
   |         ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_another_droppy`
   = note: `#[warn(unused_variables)]` on by default


warning: 1 warning emitted
---

warning: unused variable: `another_droppy`
##[warning]  --> lint_example.rs:17:9
   |
17 |     let another_droppy = Droppy(0);
   |         ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_another_droppy`
   = note: `#[warn(unused_variables)]` on by default


warning: 1 warning emitted
warning: 1 warning emitted



This error was generated by the lint-docs tool.
This tool extracts documentation for lints from the source code and places
them in the rustc book. See the declare_lint! documentation
https://doc.rust-lang.org/nightly/nightly-rustc/rustc_lint_defs/macro.declare_lint.html


To re-run these tests, run: ./x.py test --keep-stage=0 src/tools/lint-docs
The --keep-stage flag should be used if you have already built the compiler


Command has failed. Rerun with -v to see more details.
  local time: Fri Sep 27 16:55:24 UTC 2024
  network time: Fri, 27 Sep 2024 16:55:24 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

[bors]

☀️ Try build successful - checks-actions
Build commit: c387b04 (c387b04bf028733cd561d62128c8a5eee4bc1458)

[compiler-errors]

@craterbot run mode=check-only p=1 crates=https://gist.githubusercontent.com/compiler-errors/cc84423a4a9fbc5eb598383fe2555467/raw/a11fe3433fefddaab0038ee75cd2e0ab8852748a/crates start=master#a3f76a26e045a760bb1163b7eab36872985242d5 end=try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order

[craterbot]

🚨 Error: missing desired crates: {"bee-rs", "delegation-tst"}

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[compiler-errors]

@craterbot run mode=check-only p=1 crates=https://gist.githubusercontent.com/compiler-errors/7f071df0f0c3829f0c83deaf72938cb9/raw/7898cbff8609338a0a32193949d262d4f2d6de84/gistfile1.txt start=master#a3f76a26e045a760bb1163b7eab36872985242d5 end=try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order

[craterbot]

👌 Experiment pr-130930 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-130930 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-130930 is completed!
📊 10310 regressed and 1 fixed (70613 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more