Use wide pointers consistenly across the compiler by Urgau · Pull Request #131202 · rust-lang/rust

Urgau · 2024-10-03T14:12:46Z

This PR replace every use of "fat pointer" for the more recent "wide pointer" terminology.

As T-lang as preferred the "wide pointer" terminology, as can be seen on the last RFCs, on some lints, but also in the reference.

Currently we have a mix of both (including in error messages), which isn't great, but with this PR no more.

r? @jieyouxu (feel free to re-roll)

rustbot · 2024-10-03T14:12:56Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

jieyouxu · 2024-10-03T14:17:08Z

@Urgau is there any kind of meeting or decision we can look at that shows T-lang preferred "wide pointers" over "fat pointers"?

Urgau · 2024-10-03T14:19:14Z

A part from the indirect usage described in the PR description, I don't think so (at least I haven't found one). I think it just sort of happened.

cc @traviscross

jieyouxu · 2024-10-03T14:23:55Z

A part from the indirect usage described in the PR description, I don't think so (at least I haven't found one). I think it just sort of happened.

Yeah personally I'm fine with sticking with one of "wide pointers" or "fat pointers" instead of mixing both terms, but I think we want this to be an explicit T-lang decision of migrating over to "wide pointers" with a clear definition in the reference that users can look at if they want clarity of what that concretely means.

For T-lang

Do we want to use "wide pointers" terminology over "fat pointers"? Is this term documented in the Reference?

Note that the Reference seems to use "wide pointers" in at least https://doc.rust-lang.org/reference/expressions/operator-expr.html?highlight=wide#semantics.

@rustbot label +I-lang-nominated +I-lang-easy-decision

If @traviscross knows that T-lang already prefers "wide pointers" over "fat pointers" then this is fine.

Urgau · 2024-10-03T16:25:48Z

@jieyouxu actually, T-lang explicitly discussed fat vs wide for the naming of the ambiguous_wide_pointer_comparison lint in #117758 (comment), #117758 (comment), #117758 (comment) and they FCP-ed it

jieyouxu · 2024-10-03T16:29:31Z

Ok great, in that case this seems fine.

jieyouxu

LGTM with some nits, incl. consts and enums that still refers to FAT_PTR.

compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs

compiler/rustc_middle/src/ty/layout.rs

jieyouxu · 2024-10-03T16:44:06Z

@rustbot author

compiler/rustc_hir_typeck/messages.ftl

compiler/rustc_middle/src/ty/adjustment.rs

Urgau · 2024-10-04T08:32:20Z

@rustbot ready

jieyouxu

Thanks!

jieyouxu · 2024-10-04T11:35:01Z

@bors r+ rollup

bors · 2024-10-04T11:35:04Z

📌 Commit c2f8071 has been approved by jieyouxu

It is now in the queue for this repository.

jieyouxu · 2024-10-04T11:37:09Z

@bors rollup=maybe

compiler/rustc_codegen_gcc/src/type_of.rs

jieyouxu · 2024-10-04T11:50:25Z

Ah yeah.
@bors r-
Feel free to r=me after the tiny nit.

Urgau · 2024-10-04T13:29:14Z

@bors r=@jieyouxu

bors · 2024-10-04T13:29:17Z

📌 Commit 018ba05 has been approved by jieyouxu

It is now in the queue for this repository.

…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#131034 (Implement RFC3695 Allow boolean literals as cfg predicates) - rust-lang#131202 (Use wide pointers consistenly across the compiler) - rust-lang#131230 (Enable `--no-sandbox` option by default for rustdoc GUI tests) - rust-lang#131232 (Week off of reviews to focus on docs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#131202 - Urgau:wide-ptrs-compiler, r=jieyouxu Use wide pointers consistenly across the compiler This PR replace every use of "fat pointer" for the more recent "wide pointer" terminology. Since some time T-lang as preferred the "wide pointer" terminology, as can be seen on [the last RFCs](https://github.com/search?q=repo%3Arust-lang%2Frfcs+%22wide+pointer%22&type=code), on some [lints](https://doc.rust-lang.org/rustc/lints/listing/warn-by-default.html#ambiguous-wide-pointer-comparisons), but also in [the reference](https://doc.rust-lang.org/stable/reference/expressions/operator-expr.html?highlight=wide%20pointer#pointer-to-pointer-cast). Currently we have a [mix of both](https://github.com/search?q=repo%3Arust-lang%2Frust+%22wide+pointer%22&type=code) (including in error messages), which isn't great, but with this PR no more. r? `@jieyouxu` (feel free to re-roll)

rustbot assigned jieyouxu Oct 3, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 3, 2024

Urgau force-pushed the wide-ptrs-compiler branch from 25a1bd3 to 2de4f21 Compare October 3, 2024 14:39

jieyouxu approved these changes Oct 3, 2024

View reviewed changes

compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs Outdated Show resolved Hide resolved

compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs Outdated Show resolved Hide resolved

compiler/rustc_middle/src/ty/layout.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2024

lqd reviewed Oct 3, 2024

View reviewed changes

compiler/rustc_hir_typeck/messages.ftl Outdated Show resolved Hide resolved

lqd reviewed Oct 3, 2024

View reviewed changes

compiler/rustc_middle/src/ty/adjustment.rs Outdated Show resolved Hide resolved

lqd reviewed Oct 3, 2024

View reviewed changes

compiler/rustc_middle/src/ty/adjustment.rs Outdated Show resolved Hide resolved

Urgau force-pushed the wide-ptrs-compiler branch from 2de4f21 to c2f8071 Compare October 4, 2024 07:45

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 4, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2024

jieyouxu approved these changes Oct 4, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2024

lqd reviewed Oct 4, 2024

View reviewed changes

compiler/rustc_codegen_gcc/src/type_of.rs Outdated Show resolved Hide resolved

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 4, 2024

Use wide pointers consistenly across the compiler

018ba05

Urgau force-pushed the wide-ptrs-compiler branch from c2f8071 to 018ba05 Compare October 4, 2024 12:16

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2024

GuillaumeGomez mentioned this pull request Oct 4, 2024

Rollup of 4 pull requests #131237

Merged

bors merged commit ba94a2a into rust-lang:master Oct 4, 2024

rustbot added this to the 1.83.0 milestone Oct 4, 2024

Uh oh!

Conversation

Urgau commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 3, 2024

Uh oh!

jieyouxu commented Oct 3, 2024

Uh oh!

Urgau commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

For T-lang

Uh oh!

Urgau commented Oct 3, 2024

Uh oh!

jieyouxu commented Oct 3, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Oct 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Urgau commented Oct 4, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Oct 4, 2024

Uh oh!

bors commented Oct 4, 2024

Uh oh!

jieyouxu commented Oct 4, 2024

Uh oh!

Uh oh!

jieyouxu commented Oct 4, 2024

Uh oh!

Urgau commented Oct 4, 2024

Uh oh!

bors commented Oct 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Urgau commented Oct 3, 2024 •

edited

Loading

Urgau commented Oct 3, 2024 •

edited

Loading

jieyouxu commented Oct 3, 2024 •

edited

Loading