compiletest: Simplify the choice of --emit mode for assembly tests#131525
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 11, 2024
Merged
compiletest: Simplify the choice of --emit mode for assembly tests#131525bors merged 1 commit intorust-lang:masterfrom
--emit mode for assembly tests#131525bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
A-testsuite
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
Member
Author
|
Side note: the |
Zalathar
changed the title
--emit mode for assembly tests--emit mode for assembly tests
jieyouxu
approved these changes
Oct 11, 2024
Member
jieyouxu
left a comment
jieyouxu
left a comment
There was a problem hiding this comment.
Thanks! This seems like a nice cleanup.
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 11, 2024
Rollup of 3 pull requests Successful merges: - rust-lang#131305 (make `llvm::is_ci_llvm_modified` logic more precise) - rust-lang#131524 (compiletest: Remove the magic hacks for finding output with `lto=thin`) - rust-lang#131525 (compiletest: Simplify the choice of `--emit` mode for assembly tests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 11, 2024
Rollup merge of rust-lang#131525 - Zalathar:emit-asm, r=jieyouxu compiletest: Simplify the choice of `--emit` mode for assembly tests Tiny little cleanup that I noticed while working on rust-lang#131524. No functional change. Historically, the original code structure (rust-lang#58791) predates the `Emit` enum (rust-lang#103298), so it was manually adding `--emit` flags to the compiler invocation. But now the match can just evaluate to the appropriate `Emit` value directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny little cleanup that I noticed while working on #131524. No functional change.
Historically, the original code structure (#58791) predates the
Emitenum (#103298), so it was manually adding--emitflags to the compiler invocation. But now the match can just evaluate to the appropriateEmitvalue directly.