Add a test case for #131164

[dianqk]

The upstream has already been fixed, but it won't be backported to LLVM 19.

r? jieyouxu or compiler

try-job: x86_64-gnu-stable

[rustbot]

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

[jieyouxu]

Thanks, you can r=me after PR CI is green.

[jieyouxu]

@bors delegate+

[bors]

✌️ @dianqk, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

[jieyouxu]

@bors r+ rollup

[bors]

📌 Commit ff00622 has been approved by jieyouxu

It is now in the queue for this repository.

[dianqk]

#132042 (comment)
@bors r-

[dianqk]

Weird, I can’t reproduce it locally.

@bors try

[bors]

⌛ Trying commit ff00622 with merge 3e8141c...

[jieyouxu]

@dianqk the directive //@ needs-rust-lld only checks if rust-lld is available I believe, whereas the test I think looks for ld, which is not always available, i.e. in the CI jobs that don't have it.

[jieyouxu]

You may need to add a directive like //@ needs-ld which does a capability check (e.g. tries to run ld --version to check if ld is available or by other means) and conditionally runs the test if ld is in fact available.

[bors]

☀️ Try build successful - checks-actions
Build commit: 3e8141c (3e8141cdb58a22154bcbe9f9db945688f8706c7a)

[dianqk]

You may need to add a directive like //@ needs-ld which does a capability check (e.g. tries to run ld --version to check if ld is available or by other means) and conditionally runs the test if ld is in fact available.

I think ld is always available because this image has installed ld during installing g++.

[dianqk]

Ah, I believe this is lld is unavailable. A simple way to reproduce it: remove lld in PATH then run gcc -fuse-ld=lld main.c.

[dianqk]

Ah, I believe this is lld is unavailable. A simple way to reproduce it: remove lld in PATH then run gcc -fuse-ld=lld main.c.

Edit: I should pass -Clink-self-contained=+linker, see:

rust/compiler/rustc_codegen_ssa/src/back/link.rs

Lines 3299 to 3315 in e1f3068

	if self_contained_linker && !sess.opts.cg.link_self_contained.is_linker_disabled() {
	let mut linker_path_exists = false;
	for path in sess.get_tools_search_paths(false) {
	let linker_path = path.join("gcc-ld");
	linker_path_exists |= linker_path.exists();
	cmd.cc_arg({
	let mut arg = OsString::from("-B");
	arg.push(linker_path);
	arg
	});
	}
	if !linker_path_exists {
	// As a sanity check, we emit an error if none of these paths exist: we want
	// self-contained linking and have no linker.
	sess.dcx().emit_fatal(errors::SelfContainedLinkerMissing);
	}
	}

.

[jieyouxu]

Cool, you can r=me after PR CI is green.

[jieyouxu]

@bors rollup=iffy (linkers)

[dianqk]

@bors r=@jieyouxu

[bors]

📌 Commit 6570a6f has been approved by jieyouxu

It is now in the queue for this repository.