Added regression test for generics index out of bounds by ranger-ross · Pull Request #132523 · rust-lang/rust

ranger-ross · 2024-11-02T13:22:27Z

Added a regression test for #117446
This ICE was fixed in Rust 1.75 but a regression test was never added.

This PR adds a UI test with a reduced version of the original bug report that does not rely on external crates.

rustbot · 2024-11-02T13:22:35Z

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler-errors

This was fixed by #124187, for the record.

compiler-errors · 2024-11-02T14:32:25Z

tests/ui/traits/ice-index-out-of-bounds-issue-117446.rs

@@ -0,0 +1,24 @@
+//@ check-fail


In the future, no need to mark tests as //@ check-fail. It's redundant.

compiler-errors · 2024-11-02T14:34:58Z

tests/ui/traits/ice-index-out-of-bounds-issue-117446.rs

+impl<'a, T> Foo<'a> for Repeated<T> {
+    fn outer() -> Option<()> {
+        //~^ ERROR  associated function `outer` has 0 type parameters but its trait declaration has 1 type parameter [E0049]
+        //~^^ ERROR mismatched types [E0308]


Prefer //~| for continuing lines.

compiler-errors · 2024-11-02T14:35:19Z

@bors r+ rollup

bors · 2024-11-02T14:35:22Z

📌 Commit b919675 has been approved by compiler-errors

It is now in the queue for this repository.

…ompiler-errors Added regression test for generics index out of bounds Added a regression test for rust-lang#117446 This ICE was fixed in Rust 1.75 but a regression test was never added. This PR adds a UI test with a reduced version of the original bug report that does not rely on external crates.

…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#132153 (Stabilise `const_char_encode_utf16`.) - rust-lang#132419 (PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b) - rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate) - rust-lang#132458 (get rid of a whole bunch of unnecessary rustc_const_unstable attributes) - rust-lang#132520 (NFC add known bug nr to test) - rust-lang#132522 (make codegen help output more consistent) - rust-lang#132523 (Added regression test for generics index out of bounds) - rust-lang#132528 (Use `*_opt` typeck results fns to not ICE in fallback suggestion) Failed merges: - rust-lang#132511 (stabilize const_arguments_as_str) r? `@ghost` `@rustbot` modify labels: rollup

…ompiler-errors Added regression test for generics index out of bounds Added a regression test for rust-lang#117446 This ICE was fixed in Rust 1.75 but a regression test was never added. This PR adds a UI test with a reduced version of the original bug report that does not rely on external crates.

…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#132419 (PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b) - rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate) - rust-lang#132458 (get rid of a whole bunch of unnecessary rustc_const_unstable attributes) - rust-lang#132520 (NFC add known bug nr to test) - rust-lang#132522 (make codegen help output more consistent) - rust-lang#132523 (Added regression test for generics index out of bounds) - rust-lang#132528 (Use `*_opt` typeck results fns to not ICE in fallback suggestion) Failed merges: - rust-lang#132511 (stabilize const_arguments_as_str) r? `@ghost` `@rustbot` modify labels: rollup

…ompiler-errors Added regression test for generics index out of bounds Added a regression test for rust-lang#117446 This ICE was fixed in Rust 1.75 but a regression test was never added. This PR adds a UI test with a reduced version of the original bug report that does not rely on external crates.

…kingjubilee Rollup of 12 pull requests Successful merges: - rust-lang#132393 (Docs: added brief colon explanation) - rust-lang#132419 (PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b) - rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate) - rust-lang#132458 (get rid of a whole bunch of unnecessary rustc_const_unstable attributes) - rust-lang#132499 (unicode_data.rs: show command for generating file) - rust-lang#132503 (better test for const HashMap; remove const_hash leftovers) - rust-lang#132514 (Port most of `--print=target-cpus` to Rust) - rust-lang#132520 (NFC add known bug nr to test) - rust-lang#132522 (make codegen help output more consistent) - rust-lang#132523 (Added regression test for generics index out of bounds) - rust-lang#132526 (Subtree sync for rustc_codegen_cranelift) - rust-lang#132528 (Use `*_opt` typeck results fns to not ICE in fallback suggestion) - rust-lang#132540 (Do not format generic consts) Failed merges: - rust-lang#132511 (stabilize const_arguments_as_str) r? `@ghost` `@rustbot` modify labels: rollup

…ompiler-errors Added regression test for generics index out of bounds Added a regression test for rust-lang#117446 This ICE was fixed in Rust 1.75 but a regression test was never added. This PR adds a UI test with a reduced version of the original bug report that does not rely on external crates.

…kingjubilee Rollup of 15 pull requests Successful merges: - rust-lang#129329 (Implement `From<&mut {slice}>` for `Box/Rc/Arc<{slice}>`) - rust-lang#131377 (Add LowerExp and UpperExp implementations to NonZero) - rust-lang#132275 (Register `~const` preds for `Deref` adjustments in HIR typeck) - rust-lang#132393 (Docs: added brief colon explanation) - rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate) - rust-lang#132499 (unicode_data.rs: show command for generating file) - rust-lang#132503 (better test for const HashMap; remove const_hash leftovers) - rust-lang#132520 (NFC add known bug nr to test) - rust-lang#132522 (make codegen help output more consistent) - rust-lang#132523 (Added regression test for generics index out of bounds) - rust-lang#132528 (Use `*_opt` typeck results fns to not ICE in fallback suggestion) - rust-lang#132537 (PassWrapper: adapt for llvm/llvm-project@5445edb5d) - rust-lang#132540 (Do not format generic consts) - rust-lang#132543 (add and update some crashtests) - rust-lang#132550 (compiler: Continue introducing rustc_abi to the compiler) r? `@ghost` `@rustbot` modify labels: rollup

…ompiler-errors Added regression test for generics index out of bounds Added a regression test for rust-lang#117446 This ICE was fixed in Rust 1.75 but a regression test was never added. This PR adds a UI test with a reduced version of the original bug report that does not rely on external crates.

…iaskrgr Rollup of 16 pull requests Successful merges: - rust-lang#129329 (Implement `From<&mut {slice}>` for `Box/Rc/Arc<{slice}>`) - rust-lang#131377 (Add LowerExp and UpperExp implementations to NonZero) - rust-lang#132393 (Docs: added brief colon explanation) - rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate) - rust-lang#132499 (unicode_data.rs: show command for generating file) - rust-lang#132503 (better test for const HashMap; remove const_hash leftovers) - rust-lang#132511 (stabilize const_arguments_as_str) - rust-lang#132520 (NFC add known bug nr to test) - rust-lang#132522 (make codegen help output more consistent) - rust-lang#132523 (Added regression test for generics index out of bounds) - rust-lang#132528 (Use `*_opt` typeck results fns to not ICE in fallback suggestion) - rust-lang#132537 (PassWrapper: adapt for llvm/llvm-project@5445edb5d) - rust-lang#132540 (Do not format generic consts) - rust-lang#132543 (add and update some crashtests) - rust-lang#132544 (Use backticks instead of single quotes for library feature names in diagnostics) - rust-lang#132550 (compiler: Continue introducing rustc_abi to the compiler) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 15 pull requests Successful merges: - rust-lang#129329 (Implement `From<&mut {slice}>` for `Box/Rc/Arc<{slice}>`) - rust-lang#131377 (Add LowerExp and UpperExp implementations to NonZero) - rust-lang#132393 (Docs: added brief colon explanation) - rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate) - rust-lang#132499 (unicode_data.rs: show command for generating file) - rust-lang#132503 (better test for const HashMap; remove const_hash leftovers) - rust-lang#132511 (stabilize const_arguments_as_str) - rust-lang#132520 (NFC add known bug nr to test) - rust-lang#132522 (make codegen help output more consistent) - rust-lang#132523 (Added regression test for generics index out of bounds) - rust-lang#132528 (Use `*_opt` typeck results fns to not ICE in fallback suggestion) - rust-lang#132537 (PassWrapper: adapt for llvm/llvm-project@5445edb5d) - rust-lang#132540 (Do not format generic consts) - rust-lang#132543 (add and update some crashtests) - rust-lang#132550 (compiler: Continue introducing rustc_abi to the compiler) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#132523 - ranger-ross:test-issue-117446, r=compiler-errors Added regression test for generics index out of bounds Added a regression test for rust-lang#117446 This ICE was fixed in Rust 1.75 but a regression test was never added. This PR adds a UI test with a reduced version of the original bug report that does not rely on external crates.

Added regression test for 117446

b919675

rustbot assigned petrochenkov Nov 2, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 2, 2024

compiler-errors approved these changes Nov 2, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2024

fmease linked an issue Nov 2, 2024 that may be closed by this pull request

index out of bounds #117446

Closed

GuillaumeGomez mentioned this pull request Nov 2, 2024

Rollup of 8 pull requests #132538

Closed

GuillaumeGomez mentioned this pull request Nov 2, 2024

Rollup of 7 pull requests #132539

Closed

workingjubilee mentioned this pull request Nov 2, 2024

Rollup of 12 pull requests #132546

Closed

workingjubilee mentioned this pull request Nov 3, 2024

Rollup of 12 pull requests #132548

Closed

workingjubilee mentioned this pull request Nov 3, 2024

Rollup of 15 pull requests #132551

Closed

matthiaskrgr mentioned this pull request Nov 3, 2024

Rollup of 16 pull requests #132554

Closed

matthiaskrgr mentioned this pull request Nov 3, 2024

Rollup of 15 pull requests #132555

Merged

bors merged commit 6252643 into rust-lang:master Nov 3, 2024

rustbot added this to the 1.84.0 milestone Nov 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added regression test for generics index out of bounds#132523

Added regression test for generics index out of bounds#132523
bors merged 1 commit intorust-lang:masterfrom
ranger-ross:test-issue-117446

ranger-ross commented Nov 2, 2024

Uh oh!

rustbot commented Nov 2, 2024

Uh oh!

compiler-errors left a comment

Uh oh!

compiler-errors Nov 2, 2024

Uh oh!

compiler-errors Nov 2, 2024

Uh oh!

compiler-errors commented Nov 2, 2024

Uh oh!

bors commented Nov 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

ranger-ross commented Nov 2, 2024

Uh oh!

rustbot commented Nov 2, 2024

Uh oh!

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

compiler-errors Nov 2, 2024

Choose a reason for hiding this comment

Uh oh!

compiler-errors Nov 2, 2024

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented Nov 2, 2024

Uh oh!

bors commented Nov 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants