Only copy, rename and link llvm-objcopy if llvm tools are enabled#132720
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 11, 2024
Merged
Only copy, rename and link llvm-objcopy if llvm tools are enabled#132720bors merged 1 commit intorust-lang:masterfrom
llvm-objcopy if llvm tools are enabled#132720bors merged 1 commit intorust-lang:masterfrom
Conversation
Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
rustbot
added
S-waiting-on-review
This was referenced Nov 7, 2024
Contributor
|
@rustbot label llvm-main This fixes our LLVM HEAD builder so we need the label to get back to green while we wait for this to land. |
rustbot
added
the
llvm-main
Contributor
|
This LG to me, but I'll let someone that knows bootstrap better take a look |
icmccorm
added a commit
to BorrowSanitizer/rust
that referenced
this pull request
Nov 9, 2024
davidtwco
approved these changes
Nov 11, 2024
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Contributor
|
@bors p=5 Fixes regression for local development. |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (de27914): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -2.5%, secondary -2.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -2.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 785.736s -> 786.551s (0.10%) |
mati865
pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
Only copy, rename and link `llvm-objcopy` if llvm tools are enabled Fixes rust-lang#132719. cc `@bjorn3` who reported the bootstrapping problem for cg_clif. cc `@davidtwco` in case this might be problematic for linux -> macOS cross-compile builds, but seems very unlikely. cc `@albertlarsan68` (co-reviewed rust-lang#131405) r? bootstrap
icmccorm
added a commit
to BorrowSanitizer/rust
that referenced
this pull request
Nov 22, 2024
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 13, 2024
Only dist `llvm-objcopy` if llvm tools are enabled This uses the same condition that rust-lang#132720 added in the compilation phase. r? `@jieyouxu`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2024
Only dist `llvm-objcopy` if llvm tools are enabled This uses the same condition that rust-lang#132720 added in the compilation phase. r? ``@jieyouxu``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2024
Only dist `llvm-objcopy` if llvm tools are enabled This uses the same condition that rust-lang#132720 added in the compilation phase. r? ```@jieyouxu```
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 14, 2024
Rollup merge of rust-lang#134240 - cuviper:dist-llvm-tools, r=jieyouxu Only dist `llvm-objcopy` if llvm tools are enabled This uses the same condition that rust-lang#132720 added in the compilation phase. r? ``@jieyouxu``
icmccorm
added a commit
to BorrowSanitizer/rust
that referenced
this pull request
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132719.
cc @bjorn3 who reported the bootstrapping problem for cg_clif.
cc @davidtwco in case this might be problematic for linux -> macOS cross-compile builds, but seems very unlikely.
cc @albertlarsan68 (co-reviewed #131405)
r? bootstrap