Closed
Conversation
Collaborator
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
S-waiting-on-review
The enclosing check already ensured we're on an is_like_solaris path, so this inner `if` will always be false. Inlined the local variable into its only use, but preserved the comment at the top of the block because it seems like it's still relevant.
durin42
force-pushed
the
strip-cleanup
branch
from
781210f to
8b65325
Compare
Contributor
|
Isn't outer is checks for |
Contributor
Author
|
shoot, you're right. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enclosing check already ensured we're on an is_like_solaris path, so this inner
ifwill always be false. Inlined the local variable into its only use, but preserved the comment at the top of the block because it seems like it's still relevant.I noticed this while sorting out a CI failure that ended up being identical to #132719.
cc @jieyouxu (author of #131405)
cc @albertlarsan68 (co-reviewed #131405)