Refactor where predicates, and reserve for attributes support

[frank-king]

Refactor WherePredicate to WherePredicateKind, and reserve for attributes support in where predicates.

This is a part of #115590 and is split from #132388.

r? petrochenkov

[rustbot]

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

HIR ty lowering was modified

cc @fmease

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

[frank-king]

@rustbot ready

[petrochenkov]

r? @cjgillot

[bors]

☔ The latest upstream changes (presumably #133205) made this pull request unmergeable. Please resolve the merge conflicts.

[rustbot]

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

Some changes occurred in src/tools/cargo

cc @ehuss

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 5bb8061 with merge 41a5793...

[bors]

☀️ Try build successful - checks-actions
Build commit: 41a5793 (41a5793fd9ac2b2ba2c6a23961e2914fcfe2f357)

[rust-timer]

Finished benchmarking commit (41a5793): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.1%, secondary 3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.3%	[3.3%, 3.3%]	1
Improvements ✅ (primary)	-3.1%	[-3.5%, -2.8%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.1%	[-3.5%, -2.8%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 796.222s -> 798.07s (0.23%)
Artifact size: 336.06 MiB -> 336.08 MiB (0.00%)

[cjgillot]

@bors r+

[bors]

📌 Commit 161221d has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit 161221d with merge f2abf82...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing f2abf82 to master...

[rust-timer]

Finished benchmarking commit (f2abf82): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 796.797s -> 795.777s (-0.13%)
Artifact size: 336.29 MiB -> 336.33 MiB (0.01%)