only store valid proc macro item for doc link

[bvanjoi]

Fixes #132743

The definition item can be detected if it is exported in the doc, so store these items rather than skipping.

r? @petrochenkov

[petrochenkov]

How does this gets to an ICE?
The logic in fn resolve_and_cache_rustdoc_path tries to never resolve external doc links in proc macro crates.

[petrochenkov]

Storing these def ids goes against our (likely?) general direction of making proc macro crates more isolated and less needed after macro expansion (#125721).
cc @bjorn3

[bvanjoi]

How does this gets to an ICE?

During the compilation of a proc macro crate, the fn resolve_and_cache_rustdoc_path records the information mod m {} because it is not considered an external crate.

However, when building the docs for current crate, it attempts to use the information mod m {}. This information is not actually stored, leading to a panic.

Storing these def ids goes against our (likely?) general direction of making proc macro crates more isolated and less needed after macro expansion

Following these principles, removing the check def.is_local might be a better solution.

[bvanjoi]

UPDATE: now it will only store the valid proc macro item

[bvanjoi]

@rustbot ready

[petrochenkov]

Thanks!
@bors r+

[bors]

📌 Commit 30d68eb has been approved by petrochenkov

It is now in the queue for this repository.