add a test for target-feature-ABI warnings in closures and when calling extern fn#133384
Merged
bors merged 2 commits intorust-lang:masterfrom Nov 25, 2024
Merged
add a test for target-feature-ABI warnings in closures and when calling extern fn#133384bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
Member
|
r? jieyouxu @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
jieyouxu
added
A-closures
Member
Author
bors
added
S-waiting-on-author
RalfJung
force-pushed
the
vector-abi-check-tests
branch
from
134f13b to
3440505
Compare
Member
Author
|
@bors r=jieyouxu rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#132730 (std: allow after-main use of synchronization primitives) - rust-lang#133105 (only store valid proc macro item for doc link) - rust-lang#133260 (Constify the `Deref`/`DerefMut` traits, too) - rust-lang#133297 (Remove legacy bitcode for iOS) - rust-lang#133298 (Mention that std::fs::remove_dir_all fails on files) - rust-lang#133384 (add a test for target-feature-ABI warnings in closures and when calling extern fn) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 25, 2024
Rollup merge of rust-lang#133384 - RalfJung:vector-abi-check-tests, r=jieyouxu add a test for target-feature-ABI warnings in closures and when calling extern fn Also update the comment regarding the inheritance of target features into closures, to make it more clear that we really shouldn't do this right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also update the comment regarding the inheritance of target features into closures, to make it more clear that we really shouldn't do this right now.