rename fn member_constraint to fn add_member_constraint#133909
Closed
lcnr wants to merge 1 commit intorust-lang:masterfrom
Closed
rename fn member_constraint to fn add_member_constraint#133909lcnr wants to merge 1 commit intorust-lang:masterfrom
fn member_constraint to fn add_member_constraint#133909lcnr wants to merge 1 commit intorust-lang:masterfrom
Conversation
also assert that we're not in a snapshot
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
Author
|
the assert actually triggers because we always use |
Member
|
r=me if you want to remove the assert and stick with just the name change, otherwise will review if you make more changes |
Contributor
Author
|
moved to #134412 with the assert removed |
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Dec 17, 2024
…ackh726 small borrowck cleanup the already approved parts of rust-lang#133909 and rust-lang#133961 r? `@jackh726`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 17, 2024
Rollup merge of rust-lang#134412 - lcnr:borrowck-cleanup-trivial, r=jackh726 small borrowck cleanup the already approved parts of rust-lang#133909 and rust-lang#133961 r? `@jackh726`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also assert that we're not in a snapshot, closing #109654
r? types