compiletest: change a eprintln back to println#134206
Closed
jieyouxu wants to merge 2 commits intorust-lang:masterfrom
Closed
compiletest: change a eprintln back to println#134206jieyouxu wants to merge 2 commits intorust-lang:masterfrom
eprintln back to println#134206jieyouxu wants to merge 2 commits intorust-lang:masterfrom
Conversation
Member
Author
|
Hm, there might be another |
c9f74b2 to
9fe9358
Compare
Member
Author
|
Alternatively, we could also instead revert #134040 again... |
Member
Author
|
Going to close in favor of a revert. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a bit above, we call
libtest::run_tests_consolewhich dumps the dot graphics and messages to stdout. However, there isn't an explicit stdout/stderr synchronization lock here, so when weeprintlnto stderr it interleaves with libtest. Let's just change this back toprintln!since libtest output will be to stdout anyway.r? @clubby789