[EXPERIMENTAL] Bisect cmake bootstrap issue by clubby789 · Pull Request #134558 · rust-lang/rust

clubby789 · 2024-12-20T13:46:52Z

r? @ghost
Investigating #134344
try-job: dist-apple-various

clubby789 · 2024-12-20T13:46:58Z

@bors try

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors · 2024-12-20T13:48:10Z

⌛ Trying commit e026233 with merge 61c63b9...

bors · 2024-12-20T15:40:55Z

💔 Test failed - checks-actions

clubby789 · 2024-12-20T15:44:38Z

0.1.50 is bad, trying 0.1.49
@bors try

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors · 2024-12-20T15:45:48Z

⌛ Trying commit e627f77 with merge 149f420...

bors · 2024-12-20T17:34:37Z

💔 Test failed - checks-actions

clubby789 · 2024-12-20T18:55:17Z

1.49 is bad - checking ba6b3bc4712af4cda5513f01699b00631248f576

@bors try

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors · 2024-12-20T18:56:28Z

⌛ Trying commit 9c484f7 with merge 46520ed...

bors · 2024-12-20T20:26:28Z

☀️ Try build successful - checks-actions
Build commit: 46520ed (46520ed91444db5dda462f8f4e41558cfdfab1b0)

clubby789 · 2024-12-20T20:31:38Z

ba6b3bc good, trying edc139b77

@bors try

bors · 2024-12-20T20:32:49Z

⌛ Trying commit 2a9d4c6 with merge 34774f8...

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors · 2024-12-20T22:32:39Z

💔 Test failed - checks-actions

bors · 2024-12-21T00:14:40Z

💔 Test failed - checks-actions

jieyouxu · 2024-12-21T10:29:14Z

rust-lang/cmake-rs@d668808 bad, trying rust-lang/cmake-rs@163d33f

@bors try

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors · 2024-12-21T10:30:25Z

⌛ Trying commit f968c86 with merge 4039363...

bors · 2024-12-21T12:12:41Z

☀️ Try build successful - checks-actions
Build commit: 4039363 (40393637d8bbfd2175f671bcdbb76ee300bfa82b)

clubby789 · 2024-12-21T14:39:18Z

d66808 confirmed bad. Will see if I can investigate a fix

clubby789 · 2024-12-21T15:02:28Z

This should fix it - if this works and the most recent version of cmake works, let's try and land the bump
@bors try

bors · 2024-12-21T15:03:38Z

⌛ Trying commit 1de6212 with merge f048f9e...

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

clubby789 · 2024-12-21T15:34:02Z

Oops, need to use the 'bad' version of cc

@bors try

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors · 2024-12-21T15:35:13Z

⌛ Trying commit fcee667 with merge 583f4f0...

bors · 2024-12-21T17:16:35Z

💔 Test failed - checks-actions

clubby789 · 2024-12-21T18:31:48Z

Hmm. Looks like telling Cmake we're using iOS causes it to run iOS-initalize.cmake, which errors because of

rust/src/bootstrap/src/core/build_steps/llvm.rs

Lines 400 to 402 in 387b245

    
           // These two defines prevent CMake from automatically trying to add a MacOSX sysroot, which leads to a compiler error. 
        
           cfg.define("CMAKE_OSX_SYSROOT", "/"); 
        
           cfg.define("CMAKE_OSX_DEPLOYMENT_TARGET", "");

#73903 (comment)

Let's see if this hack is unecessary now

clubby789 · 2024-12-21T18:36:41Z

@bors try

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors · 2024-12-21T18:37:52Z

⌛ Trying commit 7a9b033 with merge 0f380ea...

rust-log-analyzer · 2024-12-21T20:08:56Z

The job dist-apple-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Updating files:  98% (49925/50943)
Updating files:  99% (50434/50943)
Updating files: 100% (50943/50943)
Updating files: 100% (50943/50943), done.
Switched to a new branch 'try'
branch 'try' set up to track 'origin/try'.
[command]/usr/local/bin/git log -1 --format=%H
0f380ea86d2f090f353e780b0171816cadd698fc
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
---
file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config remote.upstream.fetch=+refs/heads/*:refs/remotes/upstream/*
file:.git/config submodule.library/backtrace.active=true
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
---
   Compiling clap_complete v4.5.40
   Compiling xz2 v0.1.7
   Compiling toml v0.5.11
   Compiling fd-lock v4.0.2
   Compiling cmake v0.1.48 (https://github.com/rust-lang/cmake-rs?rev=d6688089f1e96f5bb0ecdb770b83da4994c4b3ef#d6688089)
   Compiling home v0.5.11
   Compiling opener v0.5.2
   Compiling build_helper v0.1.0 (/Users/runner/work/rust/rust/src/build_helper)
   Compiling termcolor v1.4.1

bors · 2024-12-21T20:09:07Z

💔 Test failed - checks-actions

clubby789 · 2024-12-21T20:12:56Z

Not sure why -DCMAKE_OSX_SYSROOT=/" "-DCMAKE_OSX_DEPLOYMENT_TARGET=" " is still being passed. I'll leave this for now until I have access to a Mac to iterate faster

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 20, 2024

clubby789 added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2024

clubby789 mentioned this pull request Dec 20, 2024

Repoint cc dep in bootstrap to its latest version. #134344

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

61c63b9

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

This comment has been minimized.

Sign in to view

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 20, 2024

clubby789 force-pushed the cmake-bisect branch from e026233 to e627f77 Compare December 20, 2024 15:43

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

149f420

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

This comment has been minimized.

Sign in to view

clubby789 force-pushed the cmake-bisect branch from e627f77 to 9c484f7 Compare December 20, 2024 18:54

rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Dec 20, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

46520ed

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

clubby789 force-pushed the cmake-bisect branch from 9c484f7 to 2a9d4c6 Compare December 20, 2024 20:30

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

34774f8

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

This comment has been minimized.

Sign in to view

clubby789 force-pushed the cmake-bisect branch from 2a9d4c6 to af0a717 Compare December 20, 2024 22:36

This comment has been minimized.

Sign in to view

jieyouxu force-pushed the cmake-bisect branch from af0a717 to f968c86 Compare December 21, 2024 10:28

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

4039363

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

jieyouxu mentioned this pull request Dec 21, 2024

Latest versions break rust-lang bootstrap rust-lang/cmake-rs#228

Open

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

f048f9e

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

clubby789 added 2 commits December 21, 2024 15:32

Update cc and cmake

112a65b

bootstrap: Pass system names to cmake for iOS and Darwin

fcee667

rust-cloud-vms bot force-pushed the cmake-bisect branch from 1de6212 to fcee667 Compare December 21, 2024 15:33

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

583f4f0

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

This comment has been minimized.

Sign in to view

Remove Cmake iOS hack

7a9b033

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

0f380ea

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

clubby789 closed this Dec 21, 2024

Uh oh!

Conversation

clubby789 commented Dec 20, 2024

Uh oh!

clubby789 commented Dec 20, 2024

Uh oh!

bors commented Dec 20, 2024

Uh oh!

This comment has been minimized.

bors commented Dec 20, 2024

Uh oh!

clubby789 commented Dec 20, 2024

Uh oh!

bors commented Dec 20, 2024

Uh oh!

This comment has been minimized.

bors commented Dec 20, 2024

Uh oh!

clubby789 commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Dec 20, 2024

Uh oh!

bors commented Dec 20, 2024

Uh oh!

clubby789 commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Dec 20, 2024

Uh oh!

This comment has been minimized.

bors commented Dec 20, 2024

Uh oh!

This comment has been minimized.

bors commented Dec 21, 2024

Uh oh!

jieyouxu commented Dec 21, 2024

Uh oh!

bors commented Dec 21, 2024

Uh oh!

bors commented Dec 21, 2024

Uh oh!

clubby789 commented Dec 21, 2024

Uh oh!

clubby789 commented Dec 21, 2024

Uh oh!

bors commented Dec 21, 2024

Uh oh!

clubby789 commented Dec 21, 2024

Uh oh!

bors commented Dec 21, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Dec 21, 2024

Uh oh!

clubby789 commented Dec 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clubby789 commented Dec 21, 2024

Uh oh!

bors commented Dec 21, 2024

Uh oh!

rust-log-analyzer commented Dec 21, 2024

Uh oh!

bors commented Dec 21, 2024

Uh oh!

clubby789 commented Dec 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

clubby789 commented Dec 20, 2024 •

edited

Loading

clubby789 commented Dec 20, 2024 •

edited

Loading

clubby789 commented Dec 21, 2024 •

edited

Loading