Fix effect predicates from item bounds in old solver#134638
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 24, 2024
Merged
Fix effect predicates from item bounds in old solver#134638bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
fx-item-bounds
branch
from
51dfecd to
535bc78
Compare
lcnr
reviewed
Dec 23, 2024
| <T as Trait>::Assoc::<U>::func(); | ||
| //~^ ERROR the trait bound `<T as Trait>::Assoc<U>: ~const Trait` is not satisfied | ||
| //[current]~^ ERROR the trait bound `U: ~const Other` is not satisfied | ||
| //[next]~^^ ERROR the trait bound `<T as Trait>::Assoc<U>: ~const Trait` is not satisfied |
Contributor
There was a problem hiding this comment.
deeply_normalize_for_diagnostics?
Contributor
Author
There was a problem hiding this comment.
<T as Trait>::Assoc<U> is not U. There's no normalization happening here -- that's a rigid alias. This is due to the fact that the proof tree looks like:
<T as Trait>::Assoc<U>: ~const Otherproven via an item bound requires:U: ~const Other
but we don't go deeper in the proof tree visitor b/c the nested obligation is not considered a where clause for the purposes of proof tree visitor. This may be fixed by #132345.
Contributor
Author
|
Nothing to change here @bors r=lcnr rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 24, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#134638 (Fix effect predicates from item bounds in old solver) - rust-lang#134662 (Fix safety docs for `dyn Any + Send {+ Sync}`) - rust-lang#134689 (core: fix const ptr::swap_nonoverlapping when there are pointers at odd offsets) - rust-lang#134699 (Belay new reviews for workingjubilee) - rust-lang#134701 (Correctly note item kind in `NonConstFunctionCall` error message) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 24, 2024
Rollup merge of rust-lang#134638 - compiler-errors:fx-item-bounds, r=lcnr Fix effect predicates from item bounds in old solver r? lcnr
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? lcnr