Implement use associated items of traits#134754
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 17, 2025
Merged
Conversation
Collaborator
rustbot
added
S-waiting-on-review
frank-king
commented
Dec 25, 2024
This comment has been minimized.
This comment has been minimized.
Member
|
cc @petrochenkov as this PR has some non-trivial resolve changes. |
frank-king
force-pushed
the
feature/import_trait_associated_functions
branch
from
dc2bdee to
6905a19
Compare
fmease
reviewed
Dec 25, 2024
This comment has been minimized.
This comment has been minimized.
fmease
reviewed
Dec 25, 2024
frank-king
force-pushed
the
feature/import_trait_associated_functions
branch
2 times, most recently
from
8606eb3 to
72bc889
Compare
oli-obk
reviewed
Jan 7, 2025
frank-king
force-pushed
the
feature/import_trait_associated_functions
branch
2 times, most recently
from
d79e0e1 to
2427364
Compare
frank-king
commented
Jan 16, 2025
oli-obk
requested changes
Jan 16, 2025
rustbot
added
S-waiting-on-author
frank-king
force-pushed
the
feature/import_trait_associated_functions
branch
from
39b3949 to
e249e6c
Compare
Collaborator
|
Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @rust-lang/wg-const-eval Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval The Miri subtree was changed cc @rust-lang/miri |
frank-king
force-pushed
the
feature/import_trait_associated_functions
branch
from
e249e6c to
5079acc
Compare
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 16, 2025
…sociated_functions, r=oli-obk Implement `use` associated items of traits This PR implements rust-lang#134691.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 16, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133720 ([cfg_match] Adjust syntax) - rust-lang#134496 (Update documentation for Arc::from_raw, Arc::increment_strong_count, and Arc::decrement_strong_count to clarify allocator requirement) - rust-lang#134754 (Implement `use` associated items of traits) - rust-lang#135249 (Fix overflows in the implementation of `overflowing_literals` lint's help) - rust-lang#135251 (Only treat plain literal patterns as short) - rust-lang#135556 (Clarify note in `std::sync::LazyLock` example) - rust-lang#135560 (Update `compiler-builtins` to 0.1.144) r? `@ghost` `@rustbot` modify labels: rollup
Member
bors
added
S-waiting-on-author
Member
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 16, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#134754 (Implement `use` associated items of traits) - rust-lang#135481 (coverage: Completely overhaul counter assignment, using node-flow graphs) - rust-lang#135504 (Allow coercing safe-to-call target_feature functions to safe fn pointers) - rust-lang#135561 (Update docs for `-Clink-dead-code` to discourage its use) - rust-lang#135574 (ci: mirror ubuntu:22.04 to ghcr.io) - rust-lang#135585 (resolve symlinks of LLVM tool binaries before copying them) - rust-lang#135588 (Add license-metadata.json to rustc-src tarball.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 17, 2025
Rollup merge of rust-lang#134754 - frank-king:feature/import_trait_associated_functions, r=oli-obk Implement `use` associated items of traits This PR implements rust-lang#134691.
This was referenced Mar 19, 2025
4 tasks
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Apr 3, 2025
unstable book: document import_trait_associated_functions Documents rust-lang#134691 which was implemented in rust-lang#134754
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 3, 2025
unstable book: document import_trait_associated_functions Documents rust-lang#134691 which was implemented in rust-lang#134754
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2025
Rollup merge of rust-lang#139149 - mejrs:itaf, r=ehuss unstable book: document import_trait_associated_functions Documents rust-lang#134691 which was implemented in rust-lang#134754
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 3, 2025
resolve: Support imports of associated types and glob imports from traits Follow up to rust-lang#134754, part of rust-lang#134691. This PR also closes rust-lang#138711 now. Prohibiting `use Trait::AssocType;` at name resolution stage doesn't make sense, the name itself is perfectly resolveable. It's a type checker's problem that the necessary generic args are not passed when the imported `AssocType` is used, so an error should be reported there. And since we can import associated trait items now, glob imports from traits can also be allowed.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 3, 2025
Rollup merge of rust-lang#138712 - petrochenkov:impasst, r=fmease resolve: Support imports of associated types and glob imports from traits Follow up to rust-lang#134754, part of rust-lang#134691. This PR also closes rust-lang#138711 now. Prohibiting `use Trait::AssocType;` at name resolution stage doesn't make sense, the name itself is perfectly resolveable. It's a type checker's problem that the necessary generic args are not passed when the imported `AssocType` is used, so an error should be reported there. And since we can import associated trait items now, glob imports from traits can also be allowed.
fmease
added
the
F-import_trait_associated_functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #134691.