Spruce up the docs of several queries related to the type/trait system and const eval by fmease · Pull Request #134787 · rust-lang/rust

fmease · 2024-12-26T13:45:36Z

Editorial
- Proper rustdoc summary/synopsis line by making use of extra paragraphs: Leads to better rendered output on module pages, in search result lists and overall, too
- Use rustdoc warning blocks for admonitions of the form "do not call / avoid calling this query directly"
- Use intra-doc links of the form [`Self::$query`] to cross-link queries. Indeed, such links are generally a bit brittle due to the existence of TyCtxtFeed which only contains a subset of queries. Therefore the docs of feedable queries cannot cross-link to non-feedable ones. I'd say it's fine to use intra-doc links despite the potential/unlikely occasional future breakage (if a query with the aforementioned characteristics becomes feedable). Self:: is nicer than TyCtxt:: (which would be more stable) since it accounts for other contexts like TyCtxt{Feed,At,Ensure{,WithValue}}
Informative
- Generally add, flesh out and correct some doc comments
- Add Panic sections (to a few selected queries only). The lists of panics aren't necessarily exhaustive and focus on the more "obvious" or "important" panics.
- Where applicable add a paragraph calling attention to the relevant #[rustc_*] TEST attribute

The one non-doc change (it's internal and not observable):
Be even more defensive in query constness's impl (spiritual follow-up to #134122) (see self review comment).

Fixes #133494.

r? any(compiler-errors, oli-obk)

rustbot · 2024-12-26T13:45:40Z

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

fmease · 2024-12-26T13:48:09Z

compiler/rustc_const_eval/src/const_eval/fn_queries.rs

 fn constness(tcx: TyCtxt<'_>, def_id: LocalDefId) -> hir::Constness {
    let node = tcx.hir_node_by_def_id(def_id);

    match node {


Since #134122 this fn/query is only meant to work on function-likes. However on master it also works on local¹ impl² associated constants and all foreign items (should be: foreign functions only).

This rectifies it.

Footnotes

constness doesn't even get encoded in the metadata for associated constants (should_encode_constness). ↩

Lol, trait associated constants were excluded! smh ↩

compiler/rustc_const_eval/src/const_eval/fn_queries.rs

compiler-errors

r=me with or without nit

compiler-errors · 2024-12-26T14:24:05Z

compiler/rustc_middle/src/query/mod.rs

+    /// Returns the *type* of the definition given by `DefId`.
    ///
-    /// [`DefId`]: rustc_hir::def_id::DefId
+    /// For type aliases (whether eager or lazy), this returns the underlying aliased type.


Want to mention that it reveals the hidden type of an opaque, but type_of_opaque could be used to detect cycles? Outside of that they're functionally the same, since type_of just calls type_of_opaque.

fmease · 2024-12-27T10:28:42Z

I've added a paragraph about hidden/opaque types to type_of as suggested.

For transparency, I've further tweaked the docs (compare) because writing is hard and I couldn't help myself.

@bors r=compiler-errors rollup (no observable functional changes)

…m and const eval

fmease · 2024-12-27T10:45:11Z

@bors r=compiler-errors

bors · 2024-12-27T10:45:13Z

📌 Commit 454c09e has been approved by compiler-errors

It is now in the queue for this repository.

Rollup of 8 pull requests Successful merges: - rust-lang#134606 (ptr::copy: fix docs for the overlapping case) - rust-lang#134622 (Windows: Use WriteFile to write to a UTF-8 console) - rust-lang#134759 (compiletest: Remove the `-test` suffix from normalize directives) - rust-lang#134787 (Spruce up the docs of several queries related to the type/trait system and const eval) - rust-lang#134806 (rustdoc: use shorter paths as preferred canonical paths) - rust-lang#134815 (Sort triples by name in platform_support.md) - rust-lang#134816 (tools: fix build failure caused by PR rust-lang#134420) - rust-lang#134819 (Fix mistake in windows file open) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#134787 - fmease:spruce-up-queries, r=compiler-errors Spruce up the docs of several queries related to the type/trait system and const eval - Editorial - Proper rustdoc summary/synopsis line by making use of extra paragraphs: Leads to better rendered output on module pages, in search result lists and overall, too - Use rustdoc warning blocks for admonitions of the form "do not call / avoid calling this query directly" - Use intra-doc links of the form ``[`Self::$query`]`` to cross-link queries. Indeed, such links are generally a bit brittle due to the existence of `TyCtxtFeed` which only contains a subset of queries. Therefore the docs of `feedable` queries cannot cross-link to non-`feedable` ones. I'd say it's fine to use intra-doc links despite the potential/unlikely occasional future breakage (if a query with the aforementioned characteristics becomes `feedable`). `Self::` is nicer than `TyCtxt::` (which would be more stable) since it accounts for other contexts like `TyCtxt{Feed,At,Ensure{,WithValue}}` - Informative - Generally add, flesh out and correct some doc comments - Add *Panic* sections (to a few selected queries only). The lists of panics aren't necessarily exhaustive and focus on the more "obvious" or "important" panics. - Where applicable add a paragraph calling attention to the relevant [`#[rustc_*]` TEST attribute](https://rustc-dev-guide.rust-lang.org/compiler-debugging.html#rustc_-test-attributes) The one non-doc change (it's internal and not observable): Be even more defensive in `query constness`'s impl (spiritual follow-up to rust-lang#134122) (see self review comment). Fixes rust-lang#133494. r\? **any**(compiler-errors, oli-obk)

…er-errors Spruce up the docs of several queries related to the type/trait system and const eval - Editorial - Proper rustdoc summary/synopsis line by making use of extra paragraphs: Leads to better rendered output on module pages, in search result lists and overall, too - Use rustdoc warning blocks for admonitions of the form "do not call / avoid calling this query directly" - Use intra-doc links of the form ``[`Self::$query`]`` to cross-link queries. Indeed, such links are generally a bit brittle due to the existence of `TyCtxtFeed` which only contains a subset of queries. Therefore the docs of `feedable` queries cannot cross-link to non-`feedable` ones. I'd say it's fine to use intra-doc links despite the potential/unlikely occasional future breakage (if a query with the aforementioned characteristics becomes `feedable`). `Self::` is nicer than `TyCtxt::` (which would be more stable) since it accounts for other contexts like `TyCtxt{Feed,At,Ensure{,WithValue}}` - Informative - Generally add, flesh out and correct some doc comments - Add *Panic* sections (to a few selected queries only). The lists of panics aren't necessarily exhaustive and focus on the more "obvious" or "important" panics. - Where applicable add a paragraph calling attention to the relevant [`#[rustc_*]` TEST attribute](https://rustc-dev-guide.rust-lang.org/compiler-debugging.html#rustc_-test-attributes) The one non-doc change (it's internal and not observable): Be even more defensive in `query constness`'s impl (spiritual follow-up to rust-lang#134122) (see self review comment). Fixes rust-lang#133494. r\? **any**(compiler-errors, oli-obk)

Rollup of 8 pull requests Successful merges: - rust-lang#134606 (ptr::copy: fix docs for the overlapping case) - rust-lang#134622 (Windows: Use WriteFile to write to a UTF-8 console) - rust-lang#134759 (compiletest: Remove the `-test` suffix from normalize directives) - rust-lang#134787 (Spruce up the docs of several queries related to the type/trait system and const eval) - rust-lang#134806 (rustdoc: use shorter paths as preferred canonical paths) - rust-lang#134815 (Sort triples by name in platform_support.md) - rust-lang#134816 (tools: fix build failure caused by PR rust-lang#134420) - rust-lang#134819 (Fix mistake in windows file open) r? `@ghost` `@rustbot` modify labels: rollup

fmease assigned oli-obk and compiler-errors Dec 26, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 26, 2024

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 26, 2024

fmease commented Dec 26, 2024

View reviewed changes

fmease force-pushed the spruce-up-queries branch from f69e091 to 7cc7e6a Compare December 26, 2024 13:53

RalfJung reviewed Dec 26, 2024

View reviewed changes

compiler/rustc_const_eval/src/const_eval/fn_queries.rs Show resolved Hide resolved

fmease force-pushed the spruce-up-queries branch 7 times, most recently from 505d7e4 to 8d08447 Compare December 26, 2024 15:00

This comment has been minimized.

Sign in to view

fmease force-pushed the spruce-up-queries branch from 8d08447 to fbff86e Compare December 26, 2024 16:09

compiler-errors approved these changes Dec 26, 2024

View reviewed changes

fmease force-pushed the spruce-up-queries branch from fbff86e to c21a3ea Compare December 27, 2024 10:22

This comment was marked as outdated.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2024

This comment was marked as outdated.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 27, 2024

fmease force-pushed the spruce-up-queries branch from c21a3ea to 2cfb905 Compare December 27, 2024 10:31

This comment was marked as outdated.

Sign in to view

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 27, 2024

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 27, 2024

Spruce up the docs of several queries related to the type/trait syste…

454c09e

…m and const eval

This comment was marked as outdated.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 27, 2024

fmease force-pushed the spruce-up-queries branch from 2cfb905 to 454c09e Compare December 27, 2024 10:44

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 27, 2024

fmease unassigned oli-obk Dec 27, 2024

jieyouxu mentioned this pull request Dec 27, 2024

Rollup of 8 pull requests #134822

Merged

bors merged commit 72ef16f into rust-lang:master Dec 27, 2024
6 checks passed

rustbot added this to the 1.85.0 milestone Dec 27, 2024

fmease deleted the spruce-up-queries branch December 27, 2024 16:00

compiler-errors mentioned this pull request Jul 1, 2025

Feed explicit_predicates_of instead of predicates_of #143261

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Spruce up the docs of several queries related to the type/trait system and const eval#134787

Spruce up the docs of several queries related to the type/trait system and const eval#134787
bors merged 1 commit intorust-lang:masterfrom
fmease:spruce-up-queries

fmease commented Dec 26, 2024 •

edited

Loading

Uh oh!

rustbot commented Dec 26, 2024

Uh oh!

fmease Dec 26, 2024 •

edited

Loading

Uh oh!

Uh oh!

This comment has been minimized.

compiler-errors left a comment

Uh oh!

compiler-errors Dec 26, 2024 •

edited

Loading

Uh oh!

fmease commented Dec 27, 2024 •

edited

Loading

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

fmease commented Dec 27, 2024

Uh oh!

bors commented Dec 27, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

fmease commented Dec 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 26, 2024

Uh oh!

fmease Dec 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Footnotes

Uh oh!

Uh oh!

This comment has been minimized.

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

compiler-errors Dec 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmease commented Dec 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

fmease commented Dec 27, 2024

Uh oh!

bors commented Dec 27, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

fmease commented Dec 26, 2024 •

edited

Loading

fmease Dec 26, 2024 •

edited

Loading

compiler-errors Dec 26, 2024 •

edited

Loading

fmease commented Dec 27, 2024 •

edited

Loading