Emit single error for + use<'_> and don't suggest use<'static>#135052
Open
estebank wants to merge 1 commit intorust-lang:mainfrom
Open
Emit single error for + use<'_> and don't suggest use<'static>#135052estebank wants to merge 1 commit intorust-lang:mainfrom
+ use<'_> and don't suggest use<'static>#135052estebank wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
compiler-errors
suggested changes
Jan 3, 2025
|
|
||
| if num_params == 0 { | ||
| if in_precise_capture { | ||
| err.note("`use<...>` precise captures list require a named lifetime"); |
Contributor
There was a problem hiding this comment.
that's not true. This works fine: fn foo(x: &u8) -> impl Sized + use<'_> {}.
| LL | fn no_elided_lt() -> impl Sized + use<'_> {} | ||
| | ^^ expected named lifetime parameter | ||
| | | ||
| = help: this function's return type contains a borrowed value, but there is no value for it to be borrowed from |
Contributor
There was a problem hiding this comment.
this should probably at least keep some explanation that justifies why '_ isn't valid without another lifetime which it can resolve to in the inputs.
rustbot
added
S-waiting-on-author
estebank
added
S-waiting-on-review
| ); | ||
| if in_precise_capture { | ||
| err.note( | ||
| "this function's return type specifies a borrowed `use<'_>` with an elided \ |
Contributor
There was a problem hiding this comment.
"a borrowed use<'_>" feels really awkward. I think this can be a bit more direct. Perhaps something like:
"cannot capture elided lifetime with use<'_> when there is no lifetime in scope to capture"
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
☔ The latest upstream changes (presumably #127541) made this pull request unmergeable. Please resolve the merge conflicts. |
```
error[E0106]: missing lifetime specifier
--> $DIR/bad-lifetimes.rs:1:39
|
LL | fn no_elided_lt() -> impl Sized + use<'_> {}
| ^^ expected named lifetime parameter
|
help: consider introducing a named lifetime parameter
|
LL | fn no_elided_lt<'a>() -> impl Sized + use<'a> {}
| ++++ ~~
```
Fix rust-lang#134194.
estebank
force-pushed
the
issue-134194
branch
from
b37877c to
0b33708
Compare
Collaborator
|
☔ The latest upstream changes (presumably #139938) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #134194.
r? @compiler-errors