Add FileCheck annotations to mir-opt/copy-prop by Shunpoco · Pull Request #135099 · rust-lang/rust

Shunpoco · 2025-01-04T12:42:49Z

This resolves a part of #116971 .

This PR adds FileCheck annotations to test files under mir-opt/copy-prop.

rustbot · 2025-01-04T12:42:57Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

tests/mir-opt/copy-prop/copy_propagation_arg.rs

tests/mir-opt/copy-prop/partial_init.rs

Shunpoco · 2025-01-04T13:16:31Z

r? @cjgillot

cjgillot

Thanks a lot for the great work. A few nits.

tests/mir-opt/copy-prop/calls.rs

tests/mir-opt/copy-prop/copy_propagation_arg.rs

tests/mir-opt/copy-prop/cycle.rs

tests/mir-opt/copy-prop/dead_stores_better.rs

tests/mir-opt/copy-prop/issue_107511.rs

tests/mir-opt/copy-prop/move_projection.rs

tests/mir-opt/copy-prop/partial_init.rs

apiraino · 2025-04-08T10:27:34Z

r? compiler

BoxyUwU · 2025-04-08T14:07:16Z

r? @jieyouxu
weird test stuff

jieyouxu

The FileCheck annotations syntactically look okay but I don't know mir-opts well so rerolling a mir-opt reviewer.

jieyouxu · 2025-04-08T14:14:27Z

r? mir-opt

tests/mir-opt/copy-prop/dead_stores_better.rs

wesleywiser · 2025-10-16T14:43:44Z

r? rust-lang/compiler

davidtwco

LGTM, replied to another review comment then r=me

View changes since this review

rustbot · 2025-10-26T10:38:22Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jieyouxu · 2025-10-26T10:46:12Z

Can you please squash or otherwise reorganize the commits a bit? 20+ commits seems unnecessary.

As we discussed, it is identical with dead_stores_79191

davidtwco · 2025-11-03T16:14:46Z

@bors r+ rollup

bors · 2025-11-03T16:14:49Z

📌 Commit 620b9b1 has been approved by davidtwco

It is now in the queue for this repository.

Rollup of 8 pull requests Successful merges: - #135099 (Add FileCheck annotations to mir-opt/copy-prop) - #145903 (Give correct suggestion for a typo in raw pointers) - #147520 (Port the remaining SIMD intrinsics to const-eval) - #148068 (rustdoc: Use configured target modifiers when collecting doctests) - #148099 (Prepare to move debugger discovery from compiletest to bootstrap) - #148268 (rustdoc: fix `--emit=dep-info` on scraped examples) - #148306 (Remove double check when decoding ExpnId to avoid races) - #148378 (Fix documentation for std::panic::update_hook) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #135099 - Shunpoco:116971-mir-opt-copy-prop, r=davidtwco Add FileCheck annotations to mir-opt/copy-prop This resolves a part of #116971 . This PR adds FileCheck annotations to test files under mir-opt/copy-prop.

Rollup of 8 pull requests Successful merges: - rust-lang/rust#135099 (Add FileCheck annotations to mir-opt/copy-prop) - rust-lang/rust#145903 (Give correct suggestion for a typo in raw pointers) - rust-lang/rust#147520 (Port the remaining SIMD intrinsics to const-eval) - rust-lang/rust#148068 (rustdoc: Use configured target modifiers when collecting doctests) - rust-lang/rust#148099 (Prepare to move debugger discovery from compiletest to bootstrap) - rust-lang/rust#148268 (rustdoc: fix `--emit=dep-info` on scraped examples) - rust-lang/rust#148306 (Remove double check when decoding ExpnId to avoid races) - rust-lang/rust#148378 (Fix documentation for std::panic::update_hook) r? `@ghost` `@rustbot` modify labels: rollup

…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#135099 (Add FileCheck annotations to mir-opt/copy-prop) - rust-lang#145903 (Give correct suggestion for a typo in raw pointers) - rust-lang#147520 (Port the remaining SIMD intrinsics to const-eval) - rust-lang#148068 (rustdoc: Use configured target modifiers when collecting doctests) - rust-lang#148099 (Prepare to move debugger discovery from compiletest to bootstrap) - rust-lang#148268 (rustdoc: fix `--emit=dep-info` on scraped examples) - rust-lang#148306 (Remove double check when decoding ExpnId to avoid races) - rust-lang#148378 (Fix documentation for std::panic::update_hook) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Mark-Simulacrum Jan 4, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2025

Shunpoco commented Jan 4, 2025

View reviewed changes

tests/mir-opt/copy-prop/copy_propagation_arg.rs Show resolved Hide resolved

Shunpoco commented Jan 4, 2025

View reviewed changes

tests/mir-opt/copy-prop/partial_init.rs Show resolved Hide resolved

Shunpoco marked this pull request as ready for review January 4, 2025 13:16

rustbot assigned cjgillot and unassigned Mark-Simulacrum Jan 4, 2025

cjgillot reviewed Jan 8, 2025

View reviewed changes

rustbot assigned BoxyUwU and unassigned cjgillot Apr 8, 2025

rustbot assigned jieyouxu and unassigned BoxyUwU Apr 8, 2025

jieyouxu reviewed Apr 8, 2025

View reviewed changes

rustbot assigned wesleywiser and unassigned jieyouxu Apr 8, 2025

jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc A-mir-opt Area: MIR optimizations labels Apr 8, 2025

wesleywiser reviewed Apr 18, 2025

View reviewed changes

tests/mir-opt/copy-prop/dead_stores_better.rs Outdated Show resolved Hide resolved

rustbot assigned davidtwco and unassigned wesleywiser Oct 16, 2025

davidtwco approved these changes Oct 25, 2025

View reviewed changes

Shunpoco force-pushed the 116971-mir-opt-copy-prop branch from 7a64137 to b30493b Compare October 26, 2025 10:38

Shunpoco added 14 commits October 26, 2025 11:57

Add FileCheck to branch.rs

e36689a

Add FileCheck to calls.rs

3b1e20c

Add FileCheck to copy_propagation_arg.rs

c204231

Add FileCheck to custom_move_arg.rs

17b0d90

Add FileCheck to cycle.rs

ff260c8

Add FileCheck to dead_stores_79191.rs

109870d

remove dead_stores_better.rs

76dc555

As we discussed, it is identical with dead_stores_79191

Add FileCheck to issue_107511.rs

dd2d390

Add FileCheck to move_arg.rs

13e971e

Add FileCheck to move_projection.rs

3d12668

Add FileCheck to mutate_through_pointer.rs

6eaf4fe

Add FileCheck to non_dominate.rs

aa83f17

Add FileCheck to partial_init.rs

8ae4d57

Add FileCheck to reborrow.rs

620b9b1

Shunpoco force-pushed the 116971-mir-opt-copy-prop branch from b30493b to 620b9b1 Compare October 26, 2025 10:59

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2025

GuillaumeGomez mentioned this pull request Nov 3, 2025

Rollup of 8 pull requests #148446

Merged

bors merged commit c97bde7 into rust-lang:master Nov 3, 2025
11 checks passed

rustbot added this to the 1.93.0 milestone Nov 3, 2025

Shunpoco deleted the 116971-mir-opt-copy-prop branch November 3, 2025 19:55

Uh oh!

Conversation

Shunpoco commented Jan 4, 2025

Uh oh!

rustbot commented Jan 4, 2025

Uh oh!

Uh oh!

Uh oh!

Shunpoco commented Jan 4, 2025

Uh oh!

cjgillot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

apiraino commented Apr 8, 2025

Uh oh!

BoxyUwU commented Apr 8, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Apr 8, 2025

Uh oh!

Uh oh!

wesleywiser commented Oct 16, 2025

Uh oh!

davidtwco left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Oct 26, 2025

Uh oh!

jieyouxu commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidtwco commented Nov 3, 2025

Uh oh!

bors commented Nov 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

davidtwco left a comment •

edited by rustbot

Loading

jieyouxu commented Oct 26, 2025 •

edited

Loading