Add support for excluding tests via config.toml#135538
Add support for excluding tests via config.toml#135538Aditya-PS-05 wants to merge 2 commits intorust-lang:masterfrom Aditya-PS-05:add-config-toml-test-exclude
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
|
This PR modifies If appropriate, please update This PR modifies If appropriate, please update |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| PathSet::Set(set) => set.iter().any(|p| Self::check(p, needle, module)), | ||
| PathSet::Suite(suite) => Self::check(suite, needle, module), | ||
| PathSet::Set(set) => { | ||
| set.iter().any(|p| p.path == needle && Self::check(p, needle, module)) |
There was a problem hiding this comment.
This feels suspicious. I think we already have a mechanism for skipping things (--exclude on the CLI) so I'd expect that any config.toml mechanism matches the behavior of that. Why do you need to change anything except plumbing through the new config.toml field to match the behavior of --exclude?
|
@rustbot author |
|
☔ The latest upstream changes (presumably #137001) made this pull request unmergeable. Please resolve the merge conflicts. |
|
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands: The following commits are merge commits: |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@Aditya-PS-05 any updates on this? thanks |
|
@Aditya-PS-05 |
closes #35678