Stabilize `anonymous_pipe` by tbu- · Pull Request #135822 · rust-lang/rust

tbu- · 2025-01-21T13:38:22Z

Based on top of #135635 to avoid conflicts.

rustbot · 2025-01-21T13:38:30Z

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tbu- · 2025-01-21T13:39:34Z

Diff for the three commits unique to this PR: https://github.com/rust-lang/rust/pull/135822/files/ad28cbb423b5ab203a502ecee30d630e54ea3498..58154046a31c9af0ea7cd3131e31f7bbb470bb74.

tbu- · 2025-01-21T13:45:09Z

CC @NobodyXu

NobodyXu

Thank you!

I'm so happy that this is getting stabilised 🎉

joboet

The changes here look good to me, though I'd like to see another change before stabilization:

Currently, things like the Stdio: From<PipeWriter> implementations live in sys:: which IMHO is really confusing and dangerous (because people will forget to add these implementations when porting std). Could you move all the public trait implementations to io::pipe (and os::_::pipe for the platform-specific implementations)?

rustbot · 2025-01-24T13:02:50Z

The Miri subtree was changed

cc @rust-lang/miri

bors · 2025-01-26T04:32:39Z

☔ The latest upstream changes (presumably #136070) made this pull request unmergeable. Please resolve the merge conflicts.

Also create a section "Platform-specific behavior", don't hide required imports for code examples.

Closes rust-lang#127154.

Also get rid of the now mostly-empty `std::sys::anonymous_pipe` module. It basically just unwrapped the `AnonPipe` abstraction from `std::sys::pipe`.

rust-log-analyzer · 2025-01-26T13:51:03Z

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   --> library/std/src/io/pipe.rs:78:5
    |
76  | #[derive(Debug)]
    |          ----- in this derive macro expansion
77  | pub struct PipeReader {
78  |     inner: AnonPipe,
    |     ^^^^^^^^^^^^^^^ `AnonPipe` cannot be formatted using `{:?}`
   ::: /checkout/library/core/src/fmt/mod.rs:910:5
    |
910 |     pub macro Debug($item:item) {
    |     --------------- in this expansion of `#[derive(Debug)]`
    |     --------------- in this expansion of `#[derive(Debug)]`
    |
    = help: the trait `core::fmt::Debug` is not implemented for `AnonPipe`
    = note: add `#[derive(Debug)]` to `AnonPipe` or manually `impl core::fmt::Debug for AnonPipe`
help: consider annotating `AnonPipe` with `#[derive(Debug)]`
   --> library/std/src/sys/pal/windows/pipe.rs:19:1
19  + #[derive(Debug)]
20  | pub struct AnonPipe {
    |


error[E0277]: `AnonPipe` doesn't implement `core::fmt::Debug`
   --> library/std/src/io/pipe.rs:85:5
    |
83  | #[derive(Debug)]
    |          ----- in this derive macro expansion
84  | pub struct PipeWriter {
85  |     inner: AnonPipe,
    |     ^^^^^^^^^^^^^^^ `AnonPipe` cannot be formatted using `{:?}`
   ::: /checkout/library/core/src/fmt/mod.rs:910:5
    |
910 |     pub macro Debug($item:item) {
    |     --------------- in this expansion of `#[derive(Debug)]`
    |     --------------- in this expansion of `#[derive(Debug)]`
    |
    = help: the trait `core::fmt::Debug` is not implemented for `AnonPipe`
    = note: add `#[derive(Debug)]` to `AnonPipe` or manually `impl core::fmt::Debug for AnonPipe`
help: consider annotating `AnonPipe` with `#[derive(Debug)]`
   --> library/std/src/sys/pal/windows/pipe.rs:19:1
19  + #[derive(Debug)]
20  | pub struct AnonPipe {
    |


error[E0599]: the method `as_handle` exists for reference `&AnonPipe`, but its trait bounds were not satisfied
   --> library/std/src/os/windows/io/handle.rs:552:25
552 |         self.as_inner().as_handle()
    |                         ^^^^^^^^^
    |
   ::: library/std/src/sys/pal/windows/pipe.rs:19:1
   ::: library/std/src/sys/pal/windows/pipe.rs:19:1
    |
19  | pub struct AnonPipe {
    | ------------------- doesn't satisfy `AnonPipe: os::windows::io::handle::AsHandle`
note: trait bound `AnonPipe: os::windows::io::handle::AsHandle` was not satisfied
note: trait bound `AnonPipe: os::windows::io::handle::AsHandle` was not satisfied
   --> library/std/src/os/windows/io/handle.rs:445:9
    |
445 | impl<T: AsHandle + ?Sized> AsHandle for &T {
    |         |
    |         unsatisfied trait bound introduced here
note: the trait `os::windows::io::handle::AsHandle` must be implemented
note: the trait `os::windows::io::handle::AsHandle` must be implemented
   --> library/std/src/os/windows/io/handle.rs:426:1
426 | pub trait AsHandle {
    | ^^^^^^^^^^^^^^^^^^
    = help: items from traits can only be used if the trait is implemented and in scope
    = help: items from traits can only be used if the trait is implemented and in scope
note: `os::windows::io::handle::AsHandle` defines an item `as_handle`, perhaps you need to implement it
   --> library/std/src/os/windows/io/handle.rs:426:1
426 | pub trait AsHandle {
    | ^^^^^^^^^^^^^^^^^^


error[E0599]: the method `as_handle` exists for reference `&AnonPipe`, but its trait bounds were not satisfied
   --> library/std/src/os/windows/io/handle.rs:571:25
571 |         self.as_inner().as_handle()
    |                         ^^^^^^^^^
    |
   ::: library/std/src/sys/pal/windows/pipe.rs:19:1
   ::: library/std/src/sys/pal/windows/pipe.rs:19:1
    |
19  | pub struct AnonPipe {
    | ------------------- doesn't satisfy `AnonPipe: os::windows::io::handle::AsHandle`
note: trait bound `AnonPipe: os::windows::io::handle::AsHandle` was not satisfied
note: trait bound `AnonPipe: os::windows::io::handle::AsHandle` was not satisfied
   --> library/std/src/os/windows/io/handle.rs:445:9
    |
445 | impl<T: AsHandle + ?Sized> AsHandle for &T {
    |         |
    |         unsatisfied trait bound introduced here
note: the trait `os::windows::io::handle::AsHandle` must be implemented
note: the trait `os::windows::io::handle::AsHandle` must be implemented
   --> library/std/src/os/windows/io/handle.rs:426:1
426 | pub trait AsHandle {
    | ^^^^^^^^^^^^^^^^^^
    = help: items from traits can only be used if the trait is implemented and in scope
    = help: items from traits can only be used if the trait is implemented and in scope
note: `os::windows::io::handle::AsHandle` defines an item `as_handle`, perhaps you need to implement it
   --> library/std/src/os/windows/io/handle.rs:426:1
426 | pub trait AsHandle {
    | ^^^^^^^^^^^^^^^^^^


error[E0599]: no method named `as_raw_handle` found for reference `&AnonPipe` in the current scope
   --> library/std/src/os/windows/io/raw.rs:104:25
104 |         self.as_inner().as_raw_handle()
    |                         ^^^^^^^^^^^^^ method not found in `&AnonPipe`
    |
    = help: items from traits can only be used if the trait is implemented and in scope
    = help: items from traits can only be used if the trait is implemented and in scope
note: `os::windows::io::raw::AsRawHandle` defines an item `as_raw_handle`, perhaps you need to implement it
   --> library/std/src/os/windows/io/raw.rs:22:1
22  | pub trait AsRawHandle {
    | ^^^^^^^^^^^^^^^^^^^^^


error[E0599]: no method named `as_raw_handle` found for reference `&AnonPipe` in the current scope
   --> library/std/src/os/windows/io/raw.rs:111:25
111 |         self.as_inner().as_raw_handle()
    |                         ^^^^^^^^^^^^^ method not found in `&AnonPipe`
    |
    = help: items from traits can only be used if the trait is implemented and in scope
    = help: items from traits can only be used if the trait is implemented and in scope
note: `os::windows::io::raw::AsRawHandle` defines an item `as_raw_handle`, perhaps you need to implement it
   --> library/std/src/os/windows/io/raw.rs:22:1
22  | pub trait AsRawHandle {
    | ^^^^^^^^^^^^^^^^^^^^^

error[E0599]: no method named `into_raw_handle` found for struct `AnonPipe` in the current scope
---
19  | pub struct AnonPipe {
    | ------------------- method `into_raw_handle` not found for this struct
    |
    = help: items from traits can only be used if the trait is implemented and in scope
note: `os::windows::io::raw::IntoRawHandle` defines an item `into_raw_handle`, perhaps you need to implement it
   --> library/std/src/os/windows/io/raw.rs:78:1
78  | pub trait IntoRawHandle {
    | ^^^^^^^^^^^^^^^^^^^^^^^
help: there is a method `into_handle` with a similar name
    |
---
    |
210 |       unsafe fn from_raw_handle(raw_handle: RawHandle) -> io::PipeWriter {
    |                                                           -------------- expected `PipeWriter` because of return type
...
213 | /             io::PipeReader::from_inner(FromInner::from_inner(FromInner::from_inner(
214 | |                 OwnedHandle::from_raw_handle(handle),
    | |_______________^ expected `PipeWriter`, found `PipeReader`

error[E0599]: no method named `into_raw_handle` found for struct `AnonPipe` in the current scope
   --> library/std/src/os/windows/io/raw.rs:222:27
---
19  | pub struct AnonPipe {
    | ------------------- method `into_raw_handle` not found for this struct
    |
    = help: items from traits can only be used if the trait is implemented and in scope
note: `os::windows::io::raw::IntoRawHandle` defines an item `into_raw_handle`, perhaps you need to implement it
   --> library/std/src/os/windows/io/raw.rs:78:1
78  | pub trait IntoRawHandle {
    | ^^^^^^^^^^^^^^^^^^^^^^^
help: there is a method `into_handle` with a similar name
    |

NobodyXu · 2025-02-21T13:34:07Z

Hi @tbu- If you are busy and don't have time to continue this, I can open separate PRs to stablise annoynous_pipe and do the refactoring

Prevent `rmake.rs` from using unstable features, and fix 3 run-make tests that currently do Addresses (mostly) rust-lang#137532. Follow-up to rust-lang#137373. ### Summary - Fix 3 run-make tests that currently use unstable features: 1. `tests/run-make/issue-107495-archive-permissions/rmake.rs` uses `#![feature(rustc_private)]` for `libc` on `unix`, but `run_make_support` already exports `libc`, so just use that. 2. `tests/run-make/cross-lang-lto/rmake.rs` uses `#![feature(path_file_prefix)]` for convenience, replaced with similar filename prefix logic. 3. `tests/run-make/broken-pipe-no-ice/rmake.rs` uses `#![feature(anonymous_pipe)]` for anonymous pipes. This is more complicated[^race-condition], and I decided to temporarily introduce a dependency on [`os_pipe`] before std's `anonymous_pipe` library feature is stabilized[^pipe-stab]. I left a FIXME tracked by rust-lang#137532 to make the switch once `anonymous_pipe` stabilizes and reaches beta. - Use `RUSTC_BOOTSTRAP=-1` when building `rmake.rs` to have the stage 0 rustc reject any unstable features used in `rmake.rs`. - The requirement that `rmake.rs` may not use any unstable features is now documented in rustc-dev-guide. - This PR does not impose `RUSTC_BOOTSTRAP=-1` when building `run-make-support`, but I suppose we could. r? `@Kobzol` [`os_pipe`]: https://github.com/oconnor663/os_pipe.rs [^race-condition]: We can't just try to spawn `rustc` and immediate close the stderr handle because of race condition, as there's no guarantee `rustc` will not try to print to stderr before the handle gets closed. [^pipe-stab]: In-progress stabilization PR over at rust-lang#135822.

Prevent `rmake.rs` from using unstable features, and fix 3 run-make tests that currently do Addresses (mostly) rust-lang#137532. Follow-up to rust-lang#137373. ### Summary - Fix 3 run-make tests that currently use unstable features: 1. `tests/run-make/issue-107495-archive-permissions/rmake.rs` uses `#![feature(rustc_private)]` for `libc` on `unix`, but `run_make_support` already exports `libc`, so just use that. 2. `tests/run-make/cross-lang-lto/rmake.rs` uses `#![feature(path_file_prefix)]` for convenience, replaced with similar filename prefix logic. 3. `tests/run-make/broken-pipe-no-ice/rmake.rs` uses `#![feature(anonymous_pipe)]` for anonymous pipes. This is more complicated[^race-condition], and I decided to temporarily introduce a dependency on [`os_pipe`] before std's `anonymous_pipe` library feature is stabilized[^pipe-stab]. I left a FIXME tracked by rust-lang#137532 to make the switch once `anonymous_pipe` stabilizes and reaches beta. - Use `RUSTC_BOOTSTRAP=-1` when building `rmake.rs` to have the stage 0 rustc reject any unstable features used in `rmake.rs`. - The requirement that `rmake.rs` may not use any unstable features is now documented in rustc-dev-guide. - This PR does not impose `RUSTC_BOOTSTRAP=-1` when building `run-make-support`, but I suppose we could. r? `@Kobzol` try-job: x86_64-msvc-1 try-job: x86_64-mingw-1 [`os_pipe`]: https://github.com/oconnor663/os_pipe.rs [^race-condition]: We can't just try to spawn `rustc` and immediate close the stderr handle because of race condition, as there's no guarantee `rustc` will not try to print to stderr before the handle gets closed. [^pipe-stab]: In-progress stabilization PR over at rust-lang#135822.

Rollup merge of rust-lang#137537 - jieyouxu:daily-rmake, r=Kobzol Prevent `rmake.rs` from using unstable features, and fix 3 run-make tests that currently do Addresses (mostly) rust-lang#137532. Follow-up to rust-lang#137373. ### Summary - Fix 3 run-make tests that currently use unstable features: 1. `tests/run-make/issue-107495-archive-permissions/rmake.rs` uses `#![feature(rustc_private)]` for `libc` on `unix`, but `run_make_support` already exports `libc`, so just use that. 2. `tests/run-make/cross-lang-lto/rmake.rs` uses `#![feature(path_file_prefix)]` for convenience, replaced with similar filename prefix logic. 3. `tests/run-make/broken-pipe-no-ice/rmake.rs` uses `#![feature(anonymous_pipe)]` for anonymous pipes. This is more complicated[^race-condition], and I decided to temporarily introduce a dependency on [`os_pipe`] before std's `anonymous_pipe` library feature is stabilized[^pipe-stab]. I left a FIXME tracked by rust-lang#137532 to make the switch once `anonymous_pipe` stabilizes and reaches beta. - Use `RUSTC_BOOTSTRAP=-1` when building `rmake.rs` to have the stage 0 rustc reject any unstable features used in `rmake.rs`. - The requirement that `rmake.rs` may not use any unstable features is now documented in rustc-dev-guide. - This PR does not impose `RUSTC_BOOTSTRAP=-1` when building `run-make-support`, but I suppose we could. r? `@Kobzol` try-job: x86_64-msvc-1 try-job: x86_64-mingw-1 [`os_pipe`]: https://github.com/oconnor663/os_pipe.rs [^race-condition]: We can't just try to spawn `rustc` and immediate close the stderr handle because of race condition, as there's no guarantee `rustc` will not try to print to stderr before the handle gets closed. [^pipe-stab]: In-progress stabilization PR over at rust-lang#135822.

…r=joshtriplett Stablize anonymous pipe Since rust-lang#135822 is staled, I create this PR to stablise anonymous pipe Closes rust-lang#127154

Prevent `rmake.rs` from using unstable features, and fix 3 run-make tests that currently do Addresses (mostly) #137532. Follow-up to #137373. ### Summary - Fix 3 run-make tests that currently use unstable features: 1. `tests/run-make/issue-107495-archive-permissions/rmake.rs` uses `#![feature(rustc_private)]` for `libc` on `unix`, but `run_make_support` already exports `libc`, so just use that. 2. `tests/run-make/cross-lang-lto/rmake.rs` uses `#![feature(path_file_prefix)]` for convenience, replaced with similar filename prefix logic. 3. `tests/run-make/broken-pipe-no-ice/rmake.rs` uses `#![feature(anonymous_pipe)]` for anonymous pipes. This is more complicated[^race-condition], and I decided to temporarily introduce a dependency on [`os_pipe`] before std's `anonymous_pipe` library feature is stabilized[^pipe-stab]. I left a FIXME tracked by #137532 to make the switch once `anonymous_pipe` stabilizes and reaches beta. - Use `RUSTC_BOOTSTRAP=-1` when building `rmake.rs` to have the stage 0 rustc reject any unstable features used in `rmake.rs`. - The requirement that `rmake.rs` may not use any unstable features is now documented in rustc-dev-guide. - This PR does not impose `RUSTC_BOOTSTRAP=-1` when building `run-make-support`, but I suppose we could. r? `@Kobzol` try-job: x86_64-msvc-1 try-job: x86_64-mingw-1 [`os_pipe`]: https://github.com/oconnor663/os_pipe.rs [^race-condition]: We can't just try to spawn `rustc` and immediate close the stderr handle because of race condition, as there's no guarantee `rustc` will not try to print to stderr before the handle gets closed. [^pipe-stab]: In-progress stabilization PR over at rust-lang/rust#135822.

bors · 2025-03-13T14:15:55Z

☔ The latest upstream changes (presumably #138448) made this pull request unmergeable. Please resolve the merge conflicts.

…<try> Stablize anonymous pipe Since rust-lang#135822 is staled, I create this PR to stablise anonymous pipe Closes rust-lang#127154 try-job: test-various

…r=joshtriplett Stablize anonymous pipe Since rust-lang#135822 is staled, I create this PR to stablise anonymous pipe Closes rust-lang#127154 try-job: test-various

Rollup merge of rust-lang#137793 - NobodyXu:stablise-annoymous-pipe, r=joshtriplett Stablize anonymous pipe Since rust-lang#135822 is staled, I create this PR to stablise anonymous pipe Closes rust-lang#127154 try-job: test-various

tbu- · 2025-03-17T14:05:40Z

Superseded by #137793.

Sorry to the additional delay from my stalled PR, @NobodyXu.

NobodyXu · 2025-03-17T23:05:04Z

No worries, we all have our own lives and just doing this over spare time

…r=joshtriplett Stablize anonymous pipe Since rust-lang#135822 is staled, I create this PR to stablise anonymous pipe Closes rust-lang#127154 try-job: test-various

rustbot assigned joboet Jan 21, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 21, 2025

jieyouxu added the F-anonymous_pipe `#![feature(anonymous_pipe)]` label Jan 21, 2025

NobodyXu approved these changes Jan 21, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

tbu- force-pushed the pr_io_pipe_stabilisation branch from 42584e1 to aba3017 Compare January 24, 2025 10:26

This comment has been minimized.

Sign in to view

joboet mentioned this pull request Jan 24, 2025

Tracking Issue for anonymous pipe API #127154

Closed

5 tasks

joboet requested changes Jan 24, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2025

tbu- force-pushed the pr_io_pipe_stabilisation branch from aba3017 to 887fb7f Compare January 24, 2025 13:02

tbu- added 4 commits January 26, 2025 12:40

Move std::io::pipe code into its own file

68e983f

Update std::io::{pipe, PipeReader, PipeWriter} docs the new location

ad28cbb

Also create a section "Platform-specific behavior", don't hide required imports for code examples.

pipe: Remove unnecessary miri exclusions from no_run code

e1f9370

Stabilize anonymous_pipe

604faa6

Closes rust-lang#127154.

tbu- force-pushed the pr_io_pipe_stabilisation branch from 887fb7f to 604faa6 Compare January 26, 2025 11:46

This comment has been minimized.

Sign in to view

Move trait impls for Pipe{Reader,Writer} to std::io::pipe

0778f24

Also get rid of the now mostly-empty `std::sys::anonymous_pipe` module. It basically just unwrapped the `AnonPipe` abstraction from `std::sys::pipe`.

tbu- force-pushed the pr_io_pipe_stabilisation branch from 5815404 to 0778f24 Compare January 26, 2025 13:42

rustbot added O-unix Operating system: Unix-like O-windows Operating system: Windows labels Jan 26, 2025

jieyouxu mentioned this pull request Feb 24, 2025

Prevent run-make test recipes (rmake.rs) from using *any* unstable features #137532

Closed

6 tasks

NobodyXu mentioned this pull request Feb 28, 2025

Stablize anonymous pipe #137793

Merged

tbu- closed this Mar 17, 2025

Uh oh!

Conversation

tbu- commented Jan 21, 2025

Uh oh!

rustbot commented Jan 21, 2025

Uh oh!

tbu- commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tbu- commented Jan 21, 2025

Uh oh!

NobodyXu left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

joboet left a comment

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jan 24, 2025

Uh oh!

bors commented Jan 26, 2025

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Jan 26, 2025

Uh oh!

NobodyXu commented Feb 21, 2025

Uh oh!

bors commented Mar 13, 2025

Uh oh!

tbu- commented Mar 17, 2025

Uh oh!

NobodyXu commented Mar 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tbu- commented Jan 21, 2025 •

edited

Loading