Implement pattern type ffi checks by oli-obk · Pull Request #136193 · rust-lang/rust

oli-obk · 2025-01-28T15:22:16Z

Previously we just rejected pattern types outright in FFI, but that was never meant to be a permanent situation. We'll need them supported to use them as the building block for NonZero and NonNull after all (both of which are FFI safe).

best reviewed commit by commit.

rustbot · 2025-01-28T15:22:26Z

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

chenyukang · 2025-02-05T02:29:35Z

@bors r=chenyukang

bors · 2025-02-05T02:29:38Z

📌 Commit 937866a has been approved by chenyukang

It is now in the queue for this repository.

oli-obk · 2025-02-05T09:59:53Z

@bors rollup

…=chenyukang Implement pattern type ffi checks Previously we just rejected pattern types outright in FFI, but that was never meant to be a permanent situation. We'll need them supported to use them as the building block for `NonZero` and `NonNull` after all (both of which are FFI safe). best reviewed commit by commit.

jieyouxu · 2025-02-05T10:35:49Z

Seems to have failed in rollup, I think it's this PR?

error[E0599]: no method named `try_to_bits` found for struct `rustc_middle::ty::Const` in the current scope
   --> compiler/rustc_lint/src/types.rs:878:35
    |
878 | ...                   start.try_to_bits(tcx, typing_env).is_some_and(|i| i > 0)
    |                             ^^^^^^^^^^^ method not found in `Const<'_>`

@bors r-

oli-obk · 2025-02-05T11:20:43Z

@bors r=chenyukang

bors · 2025-02-05T11:20:47Z

📌 Commit 60ed9db has been approved by chenyukang

It is now in the queue for this repository.

workingjubilee · 2025-02-06T03:51:30Z

@bors rollup=maybe

…=chenyukang Implement pattern type ffi checks Previously we just rejected pattern types outright in FFI, but that was never meant to be a permanent situation. We'll need them supported to use them as the building block for `NonZero` and `NonNull` after all (both of which are FFI safe). best reviewed commit by commit.

…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#135439 (Make `-O` mean `OptLevel::Aggressive`) - rust-lang#136193 (Implement pattern type ffi checks) - rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern) - rust-lang#136311 (Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types) - rust-lang#136315 (Use short ty string for binop and unop errors) - rust-lang#136393 (Fix accidentally not emitting overflowing literals lints anymore in patterns) - rust-lang#136530 (Implement `x perf` directly in bootstrap) - rust-lang#136580 (Couple of changes to run rustc in miri) - rust-lang#136589 (Enable "jump to def" feature on rustc docs) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#134367 (Stabilize `feature(trait_upcasting)`) - rust-lang#135354 ([Debuginfo] Add MSVC Synthetic and Summary providers to LLDB) - rust-lang#135940 (Update toolstate maintainers) - rust-lang#135945 (Remove some unnecessary parens in `assert!` conditions) - rust-lang#136577 (Pattern Migration 2024: try to suggest eliding redundant binding modifiers) - rust-lang#136598 (Fix suggestion for `dependency_on_unit_never_type_fallback` involving closures + format args expansions) - rust-lang#136653 (Remove dead code from rustc_codegen_llvm and the LLVM wrapper) - rust-lang#136664 (replace one `.map_or(true, ...)` with `.is_none_or(...)`) Failed merges: - rust-lang#136193 (Implement pattern type ffi checks) r? `@ghost` `@rustbot` modify labels: rollup

…=chenyukang Implement pattern type ffi checks Previously we just rejected pattern types outright in FFI, but that was never meant to be a permanent situation. We'll need them supported to use them as the building block for `NonZero` and `NonNull` after all (both of which are FFI safe). best reviewed commit by commit.

bors · 2025-02-07T21:36:18Z

☔ The latest upstream changes (presumably #136697) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2025-02-11T08:56:06Z

@bors r=chenyukang

bors · 2025-02-11T08:56:09Z

📌 Commit f1f996a has been approved by chenyukang

It is now in the queue for this repository.

…=chenyukang Implement pattern type ffi checks Previously we just rejected pattern types outright in FFI, but that was never meant to be a permanent situation. We'll need them supported to use them as the building block for `NonZero` and `NonNull` after all (both of which are FFI safe). best reviewed commit by commit.

Rollup of 7 pull requests Successful merges: - rust-lang#134090 (Stabilize target_feature_11) - rust-lang#134999 (Add cygwin target.) - rust-lang#135025 (Cast allocas to default address space) - rust-lang#135408 (x86: make SSE2 required for i686 hardfloat targets and use it to pass SIMD types) - rust-lang#135549 (Document some safety constraints and use more safe wrappers) - rust-lang#136193 (Implement pattern type ffi checks) - rust-lang#136699 (std: replace the `FromInner` implementation for addresses with private conversion functions) Failed merges: - rust-lang#136758 (tests: `-Copt-level=3` instead of `-O` in assembly tests) r? `@ghost` `@rustbot` modify labels: rollup

…=chenyukang Implement pattern type ffi checks Previously we just rejected pattern types outright in FFI, but that was never meant to be a permanent situation. We'll need them supported to use them as the building block for `NonZero` and `NonNull` after all (both of which are FFI safe). best reviewed commit by commit.

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#135549 (Document some safety constraints and use more safe wrappers) - rust-lang#135965 (In "specify type" suggestion, skip type params that are already known) - rust-lang#136193 (Implement pattern type ffi checks) - rust-lang#136646 (Add a TyPat in the AST to reuse the generic arg lowering logic) - rust-lang#136699 (std: replace the `FromInner` implementation for addresses with private conversion functions) - rust-lang#136874 (Change the issue number for `likely_unlikely` and `cold_path`) - rust-lang#136884 (Lower fn items as ZST valtrees and delay a bug) - rust-lang#136885 (i686-linux-android: increase CPU baseline to Pentium 4 (without an actual change) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#135549 (Document some safety constraints and use more safe wrappers) - rust-lang#135965 (In "specify type" suggestion, skip type params that are already known) - rust-lang#136193 (Implement pattern type ffi checks) - rust-lang#136646 (Add a TyPat in the AST to reuse the generic arg lowering logic) - rust-lang#136874 (Change the issue number for `likely_unlikely` and `cold_path`) - rust-lang#136884 (Lower fn items as ZST valtrees and delay a bug) - rust-lang#136885 (i686-linux-android: increase CPU baseline to Pentium 4 (without an actual change) - rust-lang#136891 (Check sig for errors before checking for unconstrained anonymous lifetime) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#136193 - oli-obk:pattern-type-ffi-checks, r=chenyukang Implement pattern type ffi checks Previously we just rejected pattern types outright in FFI, but that was never meant to be a permanent situation. We'll need them supported to use them as the building block for `NonZero` and `NonNull` after all (both of which are FFI safe). best reviewed commit by commit.

rustbot assigned chenyukang Jan 28, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 28, 2025

oli-obk force-pushed the pattern-type-ffi-checks branch from 784bbfa to 937866a Compare January 29, 2025 16:37

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2025

jieyouxu mentioned this pull request Feb 5, 2025

Rollup of 12 pull requests #136569

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 5, 2025

jieyouxu closed this Feb 5, 2025

jieyouxu reopened this Feb 5, 2025

This comment has been minimized.

Sign in to view

oli-obk force-pushed the pattern-type-ffi-checks branch from 937866a to 60ed9db Compare February 5, 2025 11:20

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 5, 2025

workingjubilee mentioned this pull request Feb 6, 2025

Rollup of 9 pull requests #136614

Closed

matthiaskrgr mentioned this pull request Feb 7, 2025

Rollup of 8 pull requests #136673

Closed

matthiaskrgr mentioned this pull request Feb 7, 2025

Rollup of 8 pull requests #136711

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2025

oli-obk added 4 commits February 11, 2025 08:30

Add ffi tests for pattern types

644c694

Correctly handle pattern types in FFI safety

473352d

Correctly handle pattern types in FFI redeclaration lints

5bae8ca

Handle pattern types wrapped in Option in FFI checks

f1f996a

oli-obk force-pushed the pattern-type-ffi-checks branch from 60ed9db to f1f996a Compare February 11, 2025 08:52

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2025

fmease mentioned this pull request Feb 11, 2025

Rollup of 7 pull requests #136872

Closed

matthiaskrgr mentioned this pull request Feb 11, 2025

Rollup of 8 pull requests #136887

Closed

matthiaskrgr mentioned this pull request Feb 12, 2025

Rollup of 8 pull requests #136905

Merged

bors merged commit 2f3f83a into rust-lang:master Feb 12, 2025
6 checks passed

rustbot added this to the 1.86.0 milestone Feb 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement pattern type ffi checks#136193

Implement pattern type ffi checks#136193
bors merged 4 commits intorust-lang:masterfrom
oli-obk:pattern-type-ffi-checks

oli-obk commented Jan 28, 2025

Uh oh!

rustbot commented Jan 28, 2025

Uh oh!

chenyukang commented Feb 5, 2025

Uh oh!

bors commented Feb 5, 2025

Uh oh!

oli-obk commented Feb 5, 2025

Uh oh!

jieyouxu commented Feb 5, 2025

Uh oh!

This comment has been minimized.

oli-obk commented Feb 5, 2025

Uh oh!

bors commented Feb 5, 2025

Uh oh!

workingjubilee commented Feb 6, 2025

Uh oh!

bors commented Feb 7, 2025

Uh oh!

oli-obk commented Feb 11, 2025

Uh oh!

bors commented Feb 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

oli-obk commented Jan 28, 2025

Uh oh!

rustbot commented Jan 28, 2025

Uh oh!

chenyukang commented Feb 5, 2025

Uh oh!

bors commented Feb 5, 2025

Uh oh!

oli-obk commented Feb 5, 2025

Uh oh!

jieyouxu commented Feb 5, 2025

Uh oh!

This comment has been minimized.

oli-obk commented Feb 5, 2025

Uh oh!

bors commented Feb 5, 2025

Uh oh!

workingjubilee commented Feb 6, 2025

Uh oh!

bors commented Feb 7, 2025

Uh oh!

oli-obk commented Feb 11, 2025

Uh oh!

bors commented Feb 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants