Merged
Conversation
rustbot
added
S-waiting-on-review
Member
|
The implementation looks reasonable to me, but this will need T-libs-api approval. r? libs-api |
rustbot
added
the
T-libs-api
Collaborator
|
☔ The latest upstream changes (presumably #138873) made this pull request unmergeable. Please resolve the merge conflicts. |
sorairolake
force-pushed
the
add-random-for-tuple
branch
from
b0098b7 to
8f97955
Compare
Collaborator
|
☔ The latest upstream changes (presumably #138881) made this pull request unmergeable. Please resolve the merge conflicts. |
Implement `Random` for tuples of arity 12 or less. Each element is expected to implement `Random`.
sorairolake
force-pushed
the
add-random-for-tuple
branch
from
8f97955 to
07e8b28
Compare
Member
|
Seems reasonable given the current unstable trait. Whether we end up with this exact trait is another question, but this seems reasonable for unstable. @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 1, 2025
Rollup of 12 pull requests Successful merges: - #136801 (Implement `Random` for tuple) - #141867 (Describe Future invariants more precisely) - #142760 (docs(fs): Touch up grammar on lock api) - #143181 (Improve testing and error messages for malformed attributes) - #143210 (`tests/ui`: A New Order [19/N] ) - #143212 (`tests/ui`: A New Order [20/N]) - #143230 ([COMPILETEST-UNTANGLE 2/N] Make some compiletest errors/warnings/help more visually obvious) - #143240 (Port `#[rustc_object_lifetime_default]` to the new attribute parsing …) - #143255 (Do not enable LLD by default in the dist profile) - #143262 (mir: Mark `Statement` and `BasicBlockData` as `#[non_exhaustive]`) - #143269 (bootstrap: make comment more clear) - #143279 (Remove `ItemKind::descr` method) Failed merges: - #143237 (Port `#[no_implicit_prelude]` to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 1, 2025
Rollup merge of #136801 - sorairolake:add-random-for-tuple, r=joshtriplett Implement `Random` for tuple Implement `Random` for tuples of arity 12 or less. Each element is expected to implement `Random`. I think it's OK to implement this trait for the following types: - Primitive integer types and `bool` - Arrays and tuples of the above values - ~~`NonZero<T>`~~, `Saturating<T>` and `Wrapping<T>` The necessity of this trait is debated (<#130703 (comment)>), but if we decide to keep it in the future when the `random` module is stabilized, I think it would be useful to have this trait implemented for tuples. Tracking issue: #130703 r? `@joboet`
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jul 4, 2025
…r=joshtriplett Implement `Random` for tuple Implement `Random` for tuples of arity 12 or less. Each element is expected to implement `Random`. I think it's OK to implement this trait for the following types: - Primitive integer types and `bool` - Arrays and tuples of the above values - ~~`NonZero<T>`~~, `Saturating<T>` and `Wrapping<T>` The necessity of this trait is debated (<rust-lang#130703 (comment)>), but if we decide to keep it in the future when the `random` module is stabilized, I think it would be useful to have this trait implemented for tuples. Tracking issue: rust-lang#130703 r? `@joboet`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
Randomfor tuples of arity 12 or less. Each element is expected to implementRandom.I think it's OK to implement this trait for the following types:
boolNonZero<T>Saturating<T>andWrapping<T>The necessity of this trait is debated (#130703 (comment)), but if we decide to keep it in the future when the
randommodule is stabilized, I think it would be useful to have this trait implemented for tuples.Tracking issue: #130703
r? @joboet