Add std support to cygwin target by Berrysoft · Pull Request #137621 · rust-lang/rust

Berrysoft · 2025-02-25T15:37:39Z

Most changes are ported from Ookiineko's repo.

Needed:

rustbot · 2025-02-25T15:37:47Z

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Kreijstal · 2025-02-28T15:06:05Z

Thank you!

joboet

Thank you for the PR! This looks really good to me – I can't help but be impressed by the astounding level of support that Cygwin has for even niche POSIX APIs...

library/std/src/sys/random/mod.rs

library/std/src/sys/pal/unix/stack_overflow.rs

library/std/src/os/cygwin/fs.rs

library/std/src/os/cygwin/raw.rs

rustbot · 2025-03-07T15:26:17Z

These commits modify compiler targets.
(See the Target Tier Policy.)

Need rust-lang/rust#137621 to test. --------- Co-authored-by: Joe Richey <dev@richey.us>

bors · 2025-03-09T22:29:06Z

☔ The latest upstream changes (presumably #138279) made this pull request unmergeable. Please resolve the merge conflicts.

Signed-off-by: Ookiineko <chiisaineko@protonmail.com>

bors · 2025-03-11T09:37:52Z

📌 Commit 9cab8c2 has been approved by joboet

It is now in the queue for this repository.

Add std support to cygwin target

Rollup of 25 pull requests Successful merges: - rust-lang#134076 (Stabilize `std::io::ErrorKind::InvalidFilename`) - rust-lang#136842 (Add libstd support for Trusty targets) - rust-lang#137314 (change definitely unproductive cycles to error) - rust-lang#137504 (Move methods from Map to TyCtxt, part 4.) - rust-lang#137621 (Add std support to cygwin target) - rust-lang#137701 (Convert `ShardedHashMap` to use `hashbrown::HashTable`) - rust-lang#138109 (make precise capturing args in rustdoc Json typed) - rust-lang#138161 (Add PeekMut::refresh) - rust-lang#138162 (Update the standard library to Rust 2024) - rust-lang#138174 (Elaborate trait assumption in `receiver_is_dispatchable`) - rust-lang#138175 (Support rmeta inputs for --crate-type=bin --emit=obj) - rust-lang#138269 (uefi: fs: Implement FileType, FilePermissions and FileAttr) - rust-lang#138313 (Update books) - rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js) - rust-lang#138331 (Use `RUSTC_LINT_FLAGS` more) - rust-lang#138333 (Rebuild llvm spuriously less frequently) - rust-lang#138343 (Enable `f16` tests for `powf`) - rust-lang#138345 (Some autodiff cleanups) - rust-lang#138346 (naked functions: on windows emit `.endef` without the symbol name) - rust-lang#138347 (Reduce `kw::Empty` usage, part 2) - rust-lang#138360 (Fix false-positive in `expr_or_init` and in the `invalid_from_utf8` lint) - rust-lang#138371 (Update compiletest's `has_asm_support` to match rustc) - rust-lang#138372 (Refactor `pick2_mut` & `pick3_mut` to use `get_disjoint_mut`) - rust-lang#138376 (Item-related cleanups) - rust-lang#138377 (Remove unnecessary lifetime from `PatInfo`.) r? `@ghost` `@rustbot` modify labels: rollup

Berrysoft · 2025-03-12T08:45:13Z

Thank you for your approval @joboet, but I have pushed one more commit to fix the panic handling for cygwin. It should be the same as *-windows-gnu.

Berrysoft · 2025-03-13T02:16:01Z

@rustbot ready

Berrysoft · 2025-03-13T02:16:28Z

@rustbot label -S-waiting-on-bors

joboet · 2025-03-17T08:52:08Z

@bors r+

bors · 2025-03-17T08:52:11Z

📌 Commit bd385f3 has been approved by joboet

It is now in the queue for this repository.

Rollup of 9 pull requests Successful merges: - rust-lang#136355 (Add `*_value` methods to proc_macro lib) - rust-lang#137621 (Add std support to cygwin target) - rust-lang#137793 (Stablize anonymous pipe) - rust-lang#138341 (std: Mention clone-on-write mutation in Arc<T>) - rust-lang#138517 (Improve upvar analysis for deref of child capture) - rust-lang#138584 (Update Rust Foundation links in Readme) - rust-lang#138586 (Document `#![register_tool]`) - rust-lang#138590 (Flatten and simplify some control flow 🫓) - rust-lang#138592 (update change entry for rust-lang#137147) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#137621 - Berrysoft:cygwin-std, r=joboet Add std support to cygwin target

Kreijstal · 2025-03-17T15:17:40Z

finally :)

riking · 2025-03-21T21:14:47Z

library/std/src/sys/net/connection/socket/unix.rs

+    pub fn set_linger(&self, linger: Option<Duration>) -> io::Result<()> {
+        let linger = libc::linger {
+            l_onoff: linger.is_some() as libc::c_ushort,
+            l_linger: linger.unwrap_or_default().as_secs() as libc::c_ushort,


should this be a try_into().map_error(|_| libc::ERANGE)?

It's just an imitation of the code above, for other platforms. Other platforms also use as.

Add std support to cygwin target

Need rust-lang/rust#137621 to test. --------- Co-authored-by: Joe Richey <dev@richey.us>

rustbot assigned joboet Feb 25, 2025

Berrysoft changed the title ~~Cygwin std~~ Add std support to cygwin target Feb 25, 2025

Berrysoft mentioned this pull request Feb 25, 2025

feat: add cygwin support nix-rust/nix#2610

Merged

7 tasks

This comment has been minimized.

Sign in to view

Berrysoft mentioned this pull request Feb 28, 2025

Add cygwin target. #134999

Merged

workingjubilee mentioned this pull request Feb 28, 2025

Experimental cygwin host support #137819

Open

3 tasks

joboet reviewed Mar 6, 2025

View reviewed changes

Berrysoft force-pushed the cygwin-std branch from 130641f to bc680af Compare March 7, 2025 07:53

Berrysoft marked this pull request as ready for review March 7, 2025 15:26

Berrysoft requested a review from joboet March 7, 2025 15:26

This was referenced Mar 7, 2025

Support cygwin fish-shell/fish-shell#11238

Closed

Add cygwin support rust-random/getrandom#626

Merged

josephlr added a commit to rust-random/getrandom that referenced this pull request Mar 9, 2025

Add cygwin support (#626)

526aff1

Need rust-lang/rust#137621 to test. --------- Co-authored-by: Joe Richey <dev@richey.us>

Berrysoft and others added 9 commits March 10, 2025 21:23

Initial STD support for Cygwin

c9ccec9

Signed-off-by: Ookiineko <chiisaineko@protonmail.com>

Fix std::sys::unix::set_linger for Cygwin

e3e98c8

Signed-off-by: Ookiineko <chiisaineko@protonmail.com>

Fix building for cygwin

1aad114

Update metadata for cygwin target

886fb15

Revert changes for rtstartup

abcbd88

Fix code style

d24c6a2

Remove std::os::cygwin::raw

7d80aaa

Impl cygwin rand with getrandom

268e734

Unify cygwin & horizon random impl

c3051b1

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2025

Berrysoft mentioned this pull request Mar 11, 2025

Add cygwin support bytecodealliance/rustix#1410

Merged

3 tasks

jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 12, 2025

Rollup merge of rust-lang#137621 - Berrysoft:cygwin-std, r=joboet

5017577

Add std support to cygwin target

jieyouxu mentioned this pull request Mar 12, 2025

Rollup of 26 pull requests #138382

Closed

jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 12, 2025

Rollup merge of rust-lang#137621 - Berrysoft:cygwin-std, r=joboet

8d52064

Add std support to cygwin target

jieyouxu mentioned this pull request Mar 12, 2025

Rollup of 25 pull requests #138383

Closed

Fix panic handler for cygwin

bd385f3

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 13, 2025

rustbot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 13, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2025

jhpratt mentioned this pull request Mar 17, 2025

Rollup of 9 pull requests #138595

Merged

bors merged commit b3b7a3b into rust-lang:master Mar 17, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Mar 17, 2025

Berrysoft deleted the cygwin-std branch March 17, 2025 13:56

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2025

Unrolled build for rust-lang#137621

1efbe7f

Rollup merge of rust-lang#137621 - Berrysoft:cygwin-std, r=joboet Add std support to cygwin target

riking reviewed Mar 21, 2025

View reviewed changes

github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 26, 2025

Rollup merge of rust-lang#137621 - Berrysoft:cygwin-std, r=joboet

edd0a06

Add std support to cygwin target

jieyouxu added the O-cygwin Target: *-pc-cygwin label Apr 25, 2025

takumi-earth pushed a commit to earthlings-dev/getrandom that referenced this pull request Jan 27, 2026

Add cygwin support (rust-random#626)

37f8522

Need rust-lang/rust#137621 to test. --------- Co-authored-by: Joe Richey <dev@richey.us>

Uh oh!

Conversation

Berrysoft commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 25, 2025

Uh oh!

This comment has been minimized.

Kreijstal commented Feb 28, 2025

Uh oh!

joboet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Mar 7, 2025

Uh oh!

bors commented Mar 9, 2025

Uh oh!

bors commented Mar 11, 2025

Uh oh!

Berrysoft commented Mar 12, 2025

Uh oh!

Berrysoft commented Mar 13, 2025

Uh oh!

Berrysoft commented Mar 13, 2025

Uh oh!

joboet commented Mar 17, 2025

Uh oh!

bors commented Mar 17, 2025

Uh oh!

Uh oh!

Kreijstal commented Mar 17, 2025

Uh oh!

riking Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

Berrysoft Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Berrysoft commented Feb 25, 2025 •

edited

Loading