Skip to content

Spruce up AttributeKind docs#137694

Merged
bors merged 1 commit intorust-lang:masterfrom
aDotInTheVoid:aDotInTheVoid-patch-1
Feb 28, 2025
Merged

Spruce up AttributeKind docs#137694
bors merged 1 commit intorust-lang:masterfrom
aDotInTheVoid:aDotInTheVoid-patch-1

Conversation

@aDotInTheVoid
Copy link
Member

@aDotInTheVoid aDotInTheVoid commented Feb 26, 2025

  • Remove dead link to rustc_attr crate.
  • Add link to rustc_attr_parsing crate.
  • Split up first paragraph so it looks better at crate-level summary

r? @jdonszelmann

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2025

Failed to set assignee to jdonszelmann: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2025

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

aDotInTheVoid
aDotInTheVoid commented Feb 26, 2025
View reviewed changes
compiler/rustc_attr_data_structures/src/attributes.rs
@@ -153,7 +154,9 @@ impl Deprecation {
/// the place where `must_use` is checked) little to no extra parsing or validating needs to
Copy link
Member Author

@aDotInTheVoid aDotInTheVoid Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tangentially related: Is #[must_use] represented as hir::Attribute::Unparsed? It's not clear where it's defined in this enum.

Copy link
Contributor

@jdonszelmann jdonszelmann Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, no it's just a good example but I didn't get to it yet. But, that's an easy one I might just do it tomorrow or something like that :)

Copy link
Contributor

@jdonszelmann jdonszelmann Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the reference also used must use as an example so that matches somewhat nicely

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@aDotInTheVoid
Spruce up AttributeKind docs
df845c9 
- Remove dead link to `rustc_attr` crate.
- Add link to `rustc_attr_parsing` crate.
- Split up first paragraph so it looks better at crate-level summary
@rust-cloud-vms rust-cloud-vms bot force-pushed the aDotInTheVoid-patch-1 branch from 8f3af0f to df845c9 Compare February 26, 2025 22:21
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Feb 26, 2025

Sorry, can't "officially" review yet but I'll give it a go anyway 😊

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Feb 26, 2025 •
edited
Loading

I see nothing wrong with this, nice change. I would @bors r+ but alas

@bors
Copy link
Collaborator

bors commented Feb 26, 2025

@jdonszelmann: 🔑 Insufficient privileges: Not in reviewers

@aDotInTheVoid
Copy link
Member Author

aDotInTheVoid commented Feb 26, 2025

I would bors r+ but alas

@bors delegate=jdonszelmann

@bors
Copy link
Collaborator

bors commented Feb 26, 2025

✌️ @jdonszelmann, you can now approve this pull request!

If @aDotInTheVoid told you to "r=me" after making some further change, please make that change, then do @bors r=@aDotInTheVoid

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Feb 26, 2025

@bors r=aDotInTheVoid

@bors
Copy link
Collaborator

bors commented Feb 26, 2025

📌 Commit df845c9 has been approved by aDotInTheVoid

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2025
@aDotInTheVoid
Copy link
Member Author

aDotInTheVoid commented Feb 26, 2025

Sorry, should have been more clear.

@bors r=jdonszelmann

@bors
Copy link
Collaborator

bors commented Feb 26, 2025

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Feb 26, 2025

📌 Commit df845c9 has been approved by jdonszelmann

It is now in the queue for this repository.

@aDotInTheVoid
Copy link
Member Author

aDotInTheVoid commented Feb 26, 2025

@bors rollup=always

@matthiaskrgr matthiaskrgr mentioned this pull request Feb 27, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 27, 2025
@bors
Auto merge of rust-lang#137710 - matthiaskrgr:rollup-3vmxxu9, r=matth…
8346456 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#136542 ([`compiletest`-related cleanups 4/7] Make the distinction between root build directory vs test suite specific build directory in compiletest less confusing)
 - rust-lang#136579 (Fix UB in ThinVec::flat_map_in_place)
 - rust-lang#136688 (require trait impls to have matching const stabilities as the traits)
 - rust-lang#136846 (Make `AssocOp` more like `ExprKind`)
 - rust-lang#137304 (add `IntoBounds::intersect` and `RangeBounds::is_empty`)
 - rust-lang#137455 (Reuse machinery from `tail_expr_drop_order` for `if_let_rescope`)
 - rust-lang#137480 (Return unexpected termination error instead of panicing in `Thread::join`)
 - rust-lang#137694 (Spruce up `AttributeKind` docs)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 27, 2025
@matthiaskrgr
Rollup merge of rust-lang#137694 - aDotInTheVoid:aDotInTheVoid-patch-…
c90d8df 
…1, r=jdonszelmann

Spruce up `AttributeKind` docs

- Remove dead link to `rustc_attr` crate.
- Add link to `rustc_attr_parsing` crate.
- Split up first paragraph so it looks better at crate-level summary

r? ``@jdonszelmann``
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 27, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 27, 2025
@bors
Auto merge of rust-lang#137717 - matthiaskrgr:rollup-ejtd189, r=<try>
be046d7 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#136579 (Fix UB in ThinVec::flat_map_in_place)
 - rust-lang#137455 (Reuse machinery from `tail_expr_drop_order` for `if_let_rescope`)
 - rust-lang#137480 (Return unexpected termination error instead of panicing in `Thread::join`)
 - rust-lang#137694 (Spruce up `AttributeKind` docs)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: i686-msvc-1
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 27, 2025
@bors
Auto merge of rust-lang#137710 - matthiaskrgr:rollup-3vmxxu9, r=matth…
b4657c0 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#136542 ([`compiletest`-related cleanups 4/7] Make the distinction between root build directory vs test suite specific build directory in compiletest less confusing)
 - rust-lang#136579 (Fix UB in ThinVec::flat_map_in_place)
 - rust-lang#136688 (require trait impls to have matching const stabilities as the traits)
 - rust-lang#136846 (Make `AssocOp` more like `ExprKind`)
 - rust-lang#137304 (add `IntoBounds::intersect` and `RangeBounds::is_empty`)
 - rust-lang#137455 (Reuse machinery from `tail_expr_drop_order` for `if_let_rescope`)
 - rust-lang#137480 (Return unexpected termination error instead of panicing in `Thread::join`)
 - rust-lang#137694 (Spruce up `AttributeKind` docs)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 28, 2025
@bors
Auto merge of rust-lang#137710 - matthiaskrgr:rollup-3vmxxu9, r=matth…
cb08599 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#136542 ([`compiletest`-related cleanups 4/7] Make the distinction between root build directory vs test suite specific build directory in compiletest less confusing)
 - rust-lang#136579 (Fix UB in ThinVec::flat_map_in_place)
 - rust-lang#136688 (require trait impls to have matching const stabilities as the traits)
 - rust-lang#136846 (Make `AssocOp` more like `ExprKind`)
 - rust-lang#137304 (add `IntoBounds::intersect` and `RangeBounds::is_empty`)
 - rust-lang#137455 (Reuse machinery from `tail_expr_drop_order` for `if_let_rescope`)
 - rust-lang#137480 (Return unexpected termination error instead of panicing in `Thread::join`)
 - rust-lang#137694 (Spruce up `AttributeKind` docs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 89a202d into rust-lang:master Feb 28, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 28, 2025
@rust-timer
Unrolled build for rust-lang#137694
f936ca6 
Rollup merge of rust-lang#137694 - aDotInTheVoid:aDotInTheVoid-patch-1, r=jdonszelmann

Spruce up `AttributeKind` docs

- Remove dead link to `rustc_attr` crate.
- Add link to `rustc_attr_parsing` crate.
- Split up first paragraph so it looks better at crate-level summary

r? `@jdonszelmann`
@rustbot rustbot added this to the 1.87.0 milestone Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdonszelmann jdonszelmann jdonszelmann left review comments

Assignees

No one assigned

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.87.0

Development

Successfully merging this pull request may close these issues.

5 participants

@aDotInTheVoid @rustbot @rust-log-analyzer @jdonszelmann @bors