bootstrap: allow to set clippy.toml for x.py clippy#137785
bootstrap: allow to set clippy.toml for x.py clippy#137785klensy wants to merge 4 commits intorust-lang:mainfrom
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
|
This PR modifies If appropriate, please update |
Mark-Simulacrum
left a comment
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
r? bootstrap
Maybe someone has stronger opinions about clippy...
| let config = LintConfig::new(run.builder); | ||
| let config = LintConfig::new( | ||
| run.builder, | ||
| Some("src/etc/clippy_configs/compiler/clippy.toml".into()), |
There was a problem hiding this comment.
This seems like a bit of an odd place to put clippy configs.. maybe we can move them to e.g. src/bootstrap, similar to profile files?
I'm also wondering if there's any clippy-native feature for these configs that we could be using instead? For example package-specific configs or something like that?
There was a problem hiding this comment.
Yes, location not really important, i can move it.
Lints can be set via https://doc.rust-lang.org/nightly/cargo/reference/manifest.html#the-lints-section, but not config for them https://doc.rust-lang.org/clippy/lint_configuration.html, as i understand.
There was a problem hiding this comment.
Hm, I thought we had user-configurable config for e.g. the cfg lints. Maybe those are special cased though.
| // FIXME: this skip merging clippy.toml, | ||
| // but maybe there is a better way? |
There was a problem hiding this comment.
What does this comment mean?
There was a problem hiding this comment.
Function named merge, but it don't merge 1 field, so i left this as note, better rephrase this?
There was a problem hiding this comment.
Why don't we want to merge this field?
|
☔ The latest upstream changes (presumably #142581) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@rustbot author (due to the outstanding comment and conflict) |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
|
Hi @klensy, ping from triage team. Are there any further updates on this PR? |
6 participants
First two commits adds ability to set
clippy.tomlforx.py clippy, to be able to tune clippy lints, and setavoid-breaking-exported-api = falsefor bootstrap and compiler as example.3rd commit fixes wrong displayed name for rustdoc - now it will be named
rustdocwhen runningpython x.py clippy librustdoc, notclippy.I don't like copypasted paths for lint targets in CI, but can't find better way for it.