Use warn(unused_crate_dependencies) in compiler crates.#137911
Closed
nnethercote wants to merge 1 commit intorust-lang:masterfrom
Closed
Use warn(unused_crate_dependencies) in compiler crates.#137911nnethercote wants to merge 1 commit intorust-lang:masterfrom
warn(unused_crate_dependencies) in compiler crates.#137911nnethercote wants to merge 1 commit intorust-lang:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
3 tasks
The commit also removes fifteen unnecessary dependencies from `Cargo.toml` files that this finds. And tweaks some conditional dependencies. There are three crates with false positives, relating to tests and doc comments. For these three crates `allow(unused_crate_dependencies)` is used along with an explanatory comment.
4c4501f to
d65cd4f
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
Perhaps investigate whether it's possible to globally enable the warnign for all compiler crates in somewhere like here: https://github.com/rust-lang/rust/blob/master/src/bootstrap/src/core/builder/cargo.rs#L1074 Then we can allow it in just the crates that need to be special, and we get it for free in new crates that get introduced ot the compiler. |
Contributor
Author
I've done this in #137930, I think it worked out pretty well. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit also removes fifteen unnecessary dependencies from
Cargo.tomlfiles that this finds. And tweaks some conditional dependencies.There are three crates with false positives, relating to tests and doc comments. For these three crates
allow(unused_crate_dependencies)is used along with an explanatory comment.r? @ghost