Rollup of 6 pull requests by workingjubilee · Pull Request #138021 · rust-lang/rust

workingjubilee · 2025-03-04T22:50:43Z

Successful merges:

Postprocess bootstrap metrics into GitHub job summary #137077 (Postprocess bootstrap metrics into GitHub job summary)
Compile run-make-support and run-make tests with the bootstrap compiler #137373 (Compile run-make-support and run-make tests with the bootstrap compiler)
Update compiler-builtins to 0.1.149 #137634 (Update compiler-builtins to 0.1.149)
Add dist::Gcc build step #137667 (Add dist::Gcc build step)
librustdoc: 2024 edition! 🎊 #137722 (librustdoc: 2024 edition! 🎊)
Do not install rustup on Rust for Linux job #137947 (Do not install rustup on Rust for Linux job)

r? @ghost
@rustbot modify labels: rollup

To distribute the prebuilt libgccjit.so from CI.

Includes a change to make a subset of math symbols available on all platforms [1], and disables `f16` on aarch64 without neon [2]. [1]: rust-lang/compiler-builtins#763 [2]: rust-lang/compiler-builtins#775

Get rid of the `Captures` hack

…oieni Postprocess bootstrap metrics into GitHub job summary This PR adds a postprocessing step to each CI job that writes the build and test step bootstrap metrics into [GitHub job summary](https://github.blog/news-insights/product-news/supercharging-github-actions-with-job-summaries/). You can see an example result for dist and test jobs [here](https://github.com/rust-lang-ci/rust/actions/runs/13619495480). r? ``@ghost`` try-job: dist-x86_64-illumos try-job: x86_64-gnu

…ouxu Compile run-make-support and run-make tests with the bootstrap compiler It does not seem necessary to have to recompile run-make-support on changes to the local compiler/stdlib. This PR simplifies the implementation of a few tools, then switches rms to stage0 and also makes the handling of environment variables in run-make tests simpler. Best reviewed commit-by-commit. I can split it into multiple PRs if you want. Also tested that `COMPILETEST_FORCE_STAGE0=1 ./x test tests/run-make --stage 0` still works. Incredibly, it looks like it even passes more tests than on `master` 😆 r? ``@jieyouxu``

Update `compiler-builtins` to 0.1.149 Includes a change to make a subset of math symbols available on all platforms [1], and disables `f16` on aarch64 without neon [2]. [1]: rust-lang/compiler-builtins#763 [2]: rust-lang/compiler-builtins#775 try-job: aarch64-gnu try-job: aarch64-gnu-debug try-job: armhf-gnu try-job: dist-various-1 try-job: dist-various-2 try-job: dist-aarch64-linux try-job: dist-arm-linux try-job: dist-armv7-linux try-job: dist-x86_64-linux try-job: test-various

Add `dist::Gcc` build step This PR adds a `dist:Gcc` bootstrap step to distribute a prebuilt `libgccjit.so` from CI on x64 Linux. With primed sccache, the build takes ~4 minutes on CI, and produces a 50 MiB archive. I want to land this before adding something akin to `[gcc] download-ci-gcc = true`, to already have the artifacts available on CI, to make it easier to setup the download merge-base logic. r? ``@ghost``

… r=notriddle `librustdoc`: 2024 edition! 🎊 Like rust-lang#137333 , but for rustdoc 😁

Do not install rustup on Rust for Linux job Trying to fix the RfL job after the recent rustup update. r? ``@ghost`` try-job: x86_64-rust-for-linux

workingjubilee · 2025-03-04T22:50:56Z

@bors r+ rollup=never p=5

bors · 2025-03-04T22:50:58Z

📌 Commit 7ba7cc8 has been approved by workingjubilee

It is now in the queue for this repository.

workingjubilee · 2025-03-04T22:55:58Z

actually one of these already failed
@bors r-

workingjubilee · 2025-03-04T22:56:26Z

oh, no, I'm mistaken

@bors r+

bors · 2025-03-04T22:56:28Z

📌 Commit 7ba7cc8 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2025-03-05T02:43:19Z

⌛ Testing commit 7ba7cc8 with merge ac951d3...

bors · 2025-03-05T06:04:41Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing ac951d3 to master...

rust-timer · 2025-03-05T06:06:25Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#137077	Postprocess bootstrap metrics into GitHub job summary	`757c518d8fb6e28ef48715c662e82c8fe091468e` (link)
#137373	Compile run-make-support and run-make tests with the bootst…	`2579da4ca62a1a6ef8719a9ada3f9bcc3a75bd28` (link)
#137634	Update `compiler-builtins` to 0.1.149	`358be5fa4fb386c54fa7a7b869c7d41e91e36a3c` (link)
#137667	Add `dist::Gcc` build step	`7abb02616dfe42521916476ed89954c520c933e1` (link)
#137722	`librustdoc`: 2024 edition! 🎊	`c4e2a4c5e6e0aafe7f5e1a7e625afbc23cf01cba` (link)
#137947	Do not install rustup on Rust for Linux job	`93346181796c2287963e1a41c364167bf99cb60e` (link)

previous master: 08db600e8e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-03-05T07:22:54Z

Finished benchmarking commit (ac951d3): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	1

Max RSS (memory usage)

Results (secondary 1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.5%	[1.7%, 5.1%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.6%	[-1.9%, -1.0%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 6.8%, secondary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	6.8%	[6.8%, 6.8%]	1
Regressions ❌ (secondary)	1.0%	[1.0%, 1.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	6.8%	[6.8%, 6.8%]	1

Binary size

Results (primary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	7
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	7

Bootstrap: 775.839s -> 777.698s (0.24%)
Artifact size: 362.04 MiB -> 362.14 MiB (0.03%)

workingjubilee · 2025-03-05T07:42:14Z

doc-only

yotamofek · 2025-03-05T08:09:29Z

doc-only

Probably caused by #137722 (that's the only one that touched rustdoc), which is weird since it's almost completely cosmetic. Thankfully, the regressions are just for the helloworld and some secondary benchmarks, so hopefully this is acceptable.
(cc @notriddle just for visibility)

Kobzol · 2025-03-11T08:15:01Z

Tiny doc regressions on the smallest benchmarks, probably caused by #137722. I don't think we need to investigate more here.

@rustbot label: +perf-regression-triaged

Kobzol and others added 23 commits February 28, 2025 09:42

Add dist:Gcc build step

4c45285

To distribute the prebuilt libgccjit.so from CI.

Build GCC on the Linux x64 dist runner

e4bfad2

Create the OptimizedDist tool with a macro

6563437

Allow specifying that tools build a library, not a binary

96a9197

Implement RunMakeSupport tool using the bootstrap_tool! macro

807f6ff

Implement RunMake test suite using the test! macro

4af94f8

Update compiler-builtins to 0.1.150

8b4007a

Includes a change to make a subset of math symbols available on all platforms [1], and disables `f16` on aarch64 without neon [2]. [1]: rust-lang/compiler-builtins#763 [2]: rust-lang/compiler-builtins#775

Compile run-make recipes using the stage0 compiler

0034d6c

Ignore a-b-a-linker-guard during cross-compilation

9d6ca5f

Do not use rustup to build Rust for Linux

e3117e6

Re-enable Rust for Linux CI job

4f4cbff

librustdoc: 2024 edition! 🎊

00523bf

Adapt librustdoc to 2024 edition lifetieme capture rules

6e86aa1

Get rid of the `Captures` hack

Postprocess test suite metrics into GitHub summary

6463590

Store bootstrap command-line into metrics

2e5ab4e

Move BuildStep and metric logging into build_helper

ead58ea

Record bootstrap step durations into GitHub summary in citool

7b53ac7

Rollup merge of rust-lang#137722 - yotamofek:pr/rustdoc/edition-2024,…

dcc85e3

… r=notriddle `librustdoc`: 2024 edition! 🎊 Like rust-lang#137333 , but for rustdoc 😁

Rollup merge of rust-lang#137947 - Kobzol:fix-rfl, r=marcoieni

7ba7cc8

Do not install rustup on Rust for Linux job Trying to fix the RfL job after the recent rustup update. r? ``@ghost`` try-job: x86_64-rust-for-linux

rustbot added T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. rollup A PR which is a rollup labels Mar 4, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 4, 2025

This was referenced Mar 5, 2025

compiler: add ExternAbi::is_rustic_abi #138028

Merged

Make rust.description more general-purpose and pass CFG_VER_DESCRIPTION #137723

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 5, 2025

bors merged commit ac951d3 into rust-lang:master Mar 5, 2025
7 checks passed

rustbot added this to the 1.87.0 milestone Mar 5, 2025

This was referenced Mar 5, 2025

Generating a documentation for tests #130463

Closed

Add post-merge analysis CI workflow #138013

Merged

rustbot added the perf-regression Performance regression. label Mar 5, 2025

workingjubilee deleted the rollup-brhnycu branch March 5, 2025 07:41

rustbot added the perf-regression-triaged The performance regression has been triaged. label Mar 11, 2025

Uh oh!

Conversation

workingjubilee commented Mar 4, 2025

Uh oh!

workingjubilee commented Mar 4, 2025

Uh oh!

bors commented Mar 4, 2025

Uh oh!

workingjubilee commented Mar 4, 2025

Uh oh!

workingjubilee commented Mar 4, 2025

Uh oh!

bors commented Mar 4, 2025

Uh oh!

bors commented Mar 5, 2025

Uh oh!

bors commented Mar 5, 2025

Uh oh!

Uh oh!

rust-timer commented Mar 5, 2025

Uh oh!

rust-timer commented Mar 5, 2025

Overall result: ❌ regressions - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

workingjubilee commented Mar 5, 2025

Uh oh!

yotamofek commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented Mar 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

yotamofek commented Mar 5, 2025 •

edited

Loading