Implement pick[23]_mut via get_disjoint_mut [rustc cleanup] #138196#138204
Closed
UjwalReddyKotla wants to merge 2 commits intorust-lang:masterfrom
Closed
Implement pick[23]_mut via get_disjoint_mut [rustc cleanup] #138196#138204UjwalReddyKotla wants to merge 2 commits intorust-lang:masterfrom
UjwalReddyKotla wants to merge 2 commits intorust-lang:masterfrom
Conversation
Collaborator
rustbot
added
S-waiting-on-review
Member
|
I think it'd make more sense to just replace |
BoxyUwU
added
S-waiting-on-author
Collaborator
|
☔ The latest upstream changes (presumably #138388) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
already implemented here: #138372 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the manual implementation of 'pick2_mut' and 'pick3_mut' in 'IndexSlice' with 'get_disjoint_mut', which provides a safer and more concise way to get multiple mutable references into the slice.
All relevant tests in 'rustc_index' pass, and 'tidy' checks have been verified.