[bootstrap] Distribute split debuginfo if present by wesleywiser · Pull Request #138321 · rust-lang/rust

wesleywiser · 2025-03-10T21:59:09Z

If debuginfo has been requested in config.toml, it should be packaged alongside the appropriate binary when running x.py dist.

Currently, this is only implemented for msvc environments where split debuginfo is (basically) the only option. I've tested that this correctly packages the .pdb for each binary in the various dist packages.

rustbot · 2025-03-10T21:59:16Z

r? @onur-ozkan

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

src/bootstrap/src/core/build_steps/tool.rs

onur-ozkan · 2025-03-11T10:45:45Z

There is a merge conflict.

@rustbot author

bors · 2025-03-11T11:38:25Z

☔ The latest upstream changes (presumably #135651) made this pull request unmergeable. Please resolve the merge conflicts.

onur-ozkan · 2025-03-14T21:10:09Z

Looks awesome, thank you!

@bors r+

bors · 2025-03-14T21:10:11Z

📌 Commit 3e466e3 has been approved by onur-ozkan

It is now in the queue for this repository.

bors · 2025-03-15T06:32:39Z

☔ The latest upstream changes (presumably #138523) made this pull request unmergeable. Please resolve the merge conflicts.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133870 (Stabilize `asm_goto` feature gate) - rust-lang#137449 (Denote `ControlFlow` as `#[must_use]`) - rust-lang#137465 (mir_build: Avoid some useless work when visiting "primary" bindings) - rust-lang#138349 (Emit function declarations for functions with `#[linkage="extern_weak"]`) - rust-lang#138412 (Install licenses into `share/doc/rust/licenses`) - rust-lang#138577 (rustdoc-json: Don't also include `#[deprecated]` in `Item::attrs`) - rust-lang#138588 (Avoid double lowering of idents) Failed merges: - rust-lang#138321 ([bootstrap] Distribute split debuginfo if present) r? `@ghost` `@rustbot` modify labels: rollup

If debuginfo has been requested in `config.toml`, it should be packaged alongside the appropriate binary when running `x.py dist`. Currently, this is only implemented for msvc environments where split debuginfo is (basically) the only option. I've tested that this correctly packages the `.pdb` for each binary in the various dist packages.

wesleywiser · 2025-03-17T23:43:12Z

Rebased

@rustbot ready

onur-ozkan · 2025-03-18T02:16:49Z

@bors r+

bors · 2025-03-18T02:16:51Z

📌 Commit 6362851 has been approved by onur-ozkan

It is now in the queue for this repository.

…, r=onur-ozkan [bootstrap] Distribute split debuginfo if present If debuginfo has been requested in `config.toml`, it should be packaged alongside the appropriate binary when running `x.py dist`. Currently, this is only implemented for msvc environments where split debuginfo is (basically) the only option. I've tested that this correctly packages the `.pdb` for each binary in the various dist packages.

Rollup of 15 pull requests Successful merges: - rust-lang#138321 ([bootstrap] Distribute split debuginfo if present) - rust-lang#138364 (ports the compiler test cases to new rust_intrinsic format) - rust-lang#138410 (Couple mir building cleanups) - rust-lang#138435 (Add support for postfix yield expressions) - rust-lang#138536 (stable_mir: Add `MutMirVisitor`) - rust-lang#138623 ([bootstrap] Use llvm_runtimes for compiler-rt) - rust-lang#138650 (Optimize `io::Write::write_fmt` for constant strings) - rust-lang#138652 (Reintroduce remote-test support in run-make tests) - rust-lang#138685 (Use `Option<Ident>` for lowered param names.) - rust-lang#138694 (Fix: add ohos target notes) - rust-lang#138700 (Suggest `-Whelp` when pass `--print lints` to rustc) - rust-lang#138709 (Update GCC submodule) - rust-lang#138724 (Check attrs: Don't try to retrieve the name of list stems) - rust-lang#138731 (coverage: Add LLVM plumbing for expansion regions) - rust-lang#138732 (Use `def_path_str` for def id arg in `UnsupportedOpInfo`) r? `@ghost` `@rustbot` modify labels: rollup

…, r=onur-ozkan [bootstrap] Distribute split debuginfo if present If debuginfo has been requested in `config.toml`, it should be packaged alongside the appropriate binary when running `x.py dist`. Currently, this is only implemented for msvc environments where split debuginfo is (basically) the only option. I've tested that this correctly packages the `.pdb` for each binary in the various dist packages.

Rollup of 10 pull requests Successful merges: - rust-lang#137736 (Don't attempt to export compiler-builtins symbols from rust dylibs) - rust-lang#138236 (uefi: Add OwnedEvent abstraction) - rust-lang#138321 ([bootstrap] Distribute split debuginfo if present) - rust-lang#138410 (Couple mir building cleanups) - rust-lang#138490 (Forward `stream_position` in `Arc<File>` as well) - rust-lang#138535 (Cleanup `LangString::parse`) - rust-lang#138536 (stable_mir: Add `MutMirVisitor`) - rust-lang#138580 (resolve: Avoid some unstable iteration 2) - rust-lang#138601 (add FCW to warn about wasm ABI transition) - rust-lang#138631 (Update test for SGX now implementing `read_buf`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - rust-lang#137593 (fix download-llvm logic for subtree sync branches) - rust-lang#137736 (Don't attempt to export compiler-builtins symbols from rust dylibs) - rust-lang#138135 (Simplify `PartialOrd` on tuples containing primitives) - rust-lang#138321 ([bootstrap] Distribute split debuginfo if present) - rust-lang#138574 (rustdoc: be more strict about "Methods from Deref") - rust-lang#138606 (Fix missing rustfmt in msi installer - cont) - rust-lang#138671 (Fix `FileType` `PartialEq` implementation on Windows) - rust-lang#138728 (Update `compiler-builtins` to 0.1.152) - rust-lang#138783 (Cache current_dll_path output) - rust-lang#138846 (Tweaks to writeback and `Obligation -> Goal` conversion) Failed merges: - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#138321 - wesleywiser:bootstrap_package_pdbs, r=onur-ozkan [bootstrap] Distribute split debuginfo if present If debuginfo has been requested in `config.toml`, it should be packaged alongside the appropriate binary when running `x.py dist`. Currently, this is only implemented for msvc environments where split debuginfo is (basically) the only option. I've tested that this correctly packages the `.pdb` for each binary in the various dist packages.

rustbot assigned onur-ozkan Mar 10, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 10, 2025

onur-ozkan reviewed Mar 11, 2025

View reviewed changes

src/bootstrap/src/core/build_steps/tool.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2025

wesleywiser force-pushed the bootstrap_package_pdbs branch from f15261b to 8924f63 Compare March 14, 2025 19:44

This comment has been minimized.

Sign in to view

wesleywiser force-pushed the bootstrap_package_pdbs branch from 8924f63 to 3e466e3 Compare March 14, 2025 20:09

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 14, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 15, 2025

matthiaskrgr mentioned this pull request Mar 17, 2025

Rollup of 7 pull requests #138611

Merged

wesleywiser force-pushed the bootstrap_package_pdbs branch from 3e466e3 to 6362851 Compare March 17, 2025 23:21

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 17, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2025

jieyouxu mentioned this pull request Mar 20, 2025

Rollup of 15 pull requests #138733

Closed

tgross35 mentioned this pull request Mar 22, 2025

Rollup of 10 pull requests #138827

Closed

jhpratt mentioned this pull request Mar 24, 2025

Rollup of 10 pull requests #138873

Merged

bors merged commit 66f2a19 into rust-lang:master Mar 24, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Mar 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[bootstrap] Distribute split debuginfo if present#138321

[bootstrap] Distribute split debuginfo if present#138321
bors merged 1 commit intorust-lang:masterfrom
wesleywiser:bootstrap_package_pdbs

wesleywiser commented Mar 10, 2025

Uh oh!

rustbot commented Mar 10, 2025

Uh oh!

Uh oh!

onur-ozkan commented Mar 11, 2025

Uh oh!

bors commented Mar 11, 2025

Uh oh!

This comment has been minimized.

onur-ozkan commented Mar 14, 2025

Uh oh!

bors commented Mar 14, 2025

Uh oh!

bors commented Mar 15, 2025

Uh oh!

wesleywiser commented Mar 17, 2025

Uh oh!

onur-ozkan commented Mar 18, 2025

Uh oh!

bors commented Mar 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

wesleywiser commented Mar 10, 2025

Uh oh!

rustbot commented Mar 10, 2025

Uh oh!

Uh oh!

onur-ozkan commented Mar 11, 2025

Uh oh!

bors commented Mar 11, 2025

Uh oh!

This comment has been minimized.

onur-ozkan commented Mar 14, 2025

Uh oh!

bors commented Mar 14, 2025

Uh oh!

bors commented Mar 15, 2025

Uh oh!

wesleywiser commented Mar 17, 2025

Uh oh!

onur-ozkan commented Mar 18, 2025

Uh oh!

bors commented Mar 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants