[perf] Decouple directly accessing a HIR owner from ast lowering by oli-obk · Pull Request #138705 · rust-lang/rust

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.1%, 1.3%]	158
Regressions ❌ (secondary)	1.0%	[0.1%, 2.8%]	62
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.1%, 1.3%]	158

Max RSS (memory usage)

Results (primary 1.8%, secondary 1.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.0%	[0.6%, 17.0%]	10
Regressions ❌ (secondary)	5.7%	[1.3%, 6.6%]	7
Improvements ✅ (primary)	-2.0%	[-2.2%, -1.9%]	3
Improvements ✅ (secondary)	-2.1%	[-3.5%, -0.8%]	8
All ❌✅ (primary)	1.8%	[-2.2%, 17.0%]	13

Cycles

Results (primary 1.5%, secondary 2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.2%, 2.0%]	3
Regressions ❌ (secondary)	2.8%	[1.4%, 3.7%]	16
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	1.5%	[1.2%, 2.0%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.901s -> 775.7s (-0.15%)
Artifact size: 365.07 MiB -> 365.12 MiB (0.01%)

oli-obk · 2025-03-19T18:51:32Z

@rust-timer build 67ad3c3

rust-timer · 2025-03-20T03:13:05Z

Finished benchmarking commit (67ad3c3): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.2%, 2.5%]	159
Regressions ❌ (secondary)	1.4%	[0.2%, 4.1%]	66
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[0.2%, 2.5%]	159

Max RSS (memory usage)

Results (primary 1.7%, secondary 1.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.6%	[0.6%, 17.3%]	8
Regressions ❌ (secondary)	4.4%	[0.8%, 6.4%]	11
Improvements ✅ (primary)	-2.1%	[-2.7%, -1.8%]	4
Improvements ✅ (secondary)	-2.8%	[-3.8%, -1.9%]	6
All ❌✅ (primary)	1.7%	[-2.7%, 17.3%]	12

Cycles

Results (primary 1.6%, secondary 0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.6%, 1.6%]	1
Regressions ❌ (secondary)	2.6%	[2.0%, 3.3%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-4.9%, -1.8%]	4
All ❌✅ (primary)	1.6%	[1.6%, 1.6%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.717s -> 772.179s (-0.20%)
Artifact size: 365.52 MiB -> 365.48 MiB (-0.01%)

oli-obk · 2025-03-20T14:08:45Z

@bors try @rust-timer queue

[perf] Decouple directly accessing a HIR owner from ast lowering r? `@ghost`

bors · 2025-03-20T14:09:56Z

⌛ Trying commit 0d1af78 with merge 658a5a6...

bors · 2025-03-20T16:18:19Z

☀️ Try build successful - checks-actions
Build commit: 658a5a6 (658a5a6a7f12aeb79d54469c023d0c5416731529)

rust-timer · 2025-03-20T18:43:36Z

Finished benchmarking commit (658a5a6): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.2%, 1.4%]	161
Regressions ❌ (secondary)	1.0%	[0.1%, 2.9%]	64
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.2%, 1.4%]	161

Max RSS (memory usage)

Results (primary 2.1%, secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.3%	[0.7%, 17.3%]	10
Regressions ❌ (secondary)	3.6%	[0.7%, 6.9%]	10
Improvements ✅ (primary)	-2.0%	[-2.3%, -1.8%]	3
Improvements ✅ (secondary)	-2.9%	[-3.5%, -2.2%]	3
All ❌✅ (primary)	2.1%	[-2.3%, 17.3%]	13

Cycles

Results (secondary 0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.5%, 3.1%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-2.5%, -1.3%]	4
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.84s -> 775.25s (0.18%)
Artifact size: 365.50 MiB -> 365.51 MiB (0.00%)

[perf] Decouple directly accessing a HIR owner from ast lowering r? `@ghost` cc rust-lang#95004

bors · 2025-05-21T13:14:08Z

☀️ Try build successful - checks-actions
Build commit: 2c990c5 (2c990c5259fc2c09ad857114cd96674b402ee3b3)

rust-timer · 2025-05-21T15:24:44Z

Finished benchmarking commit (2c990c5): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.1%, 2.2%]	144
Regressions ❌ (secondary)	1.2%	[0.0%, 6.0%]	72
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.1%, 2.2%]	144

Max RSS (memory usage)

Results (primary 1.2%, secondary 3.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[0.7%, 4.8%]	13
Regressions ❌ (secondary)	4.0%	[0.4%, 12.6%]	10
Improvements ✅ (primary)	-2.0%	[-3.2%, -0.9%]	2
Improvements ✅ (secondary)	-2.6%	[-2.6%, -2.6%]	1
All ❌✅ (primary)	1.2%	[-3.2%, 4.8%]	15

Cycles

Results (primary 2.6%, secondary 4.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[1.3%, 4.7%]	36
Regressions ❌ (secondary)	4.2%	[0.4%, 11.4%]	28
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.6%	[1.3%, 4.7%]	36

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.541s -> 777.894s (0.17%)
Artifact size: 365.51 MiB -> 365.41 MiB (-0.03%)

oli-obk · 2025-06-05T15:32:40Z

@bors try @rust-timer queue

[perf] Decouple directly accessing a HIR owner from ast lowering r? `@ghost` cc #95004

bors · 2025-06-05T15:33:52Z

⌛ Trying commit 0ddb721 with merge fd56196...

bors · 2025-06-05T18:23:50Z

💔 Test failed - checks-actions

oli-obk · 2025-06-06T06:42:18Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-06T06:42:21Z

⌛ Trying commit 0ddb721 with merge bc256db…

To cancel the try build, run the command @bors2 try cancel.

[perf] Decouple directly accessing a HIR owner from ast lowering r? `@ghost` cc #95004

rust-bors · 2025-06-06T09:10:05Z

☀️ Try build successful (CI)
Build commit: bc256db (bc256dbec9e453f8af70de9c9f70de9cdd9464dc)

rust-timer · 2025-06-06T10:39:16Z

Finished benchmarking commit (bc256db): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.1%, 2.5%]	133
Regressions ❌ (secondary)	1.5%	[0.1%, 6.5%]	55
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.1%]	4
All ❌✅ (primary)	0.9%	[0.1%, 2.5%]	133

Max RSS (memory usage)

Results (primary 2.1%, secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[0.8%, 8.7%]	54
Regressions ❌ (secondary)	3.6%	[1.2%, 12.7%]	19
Improvements ✅ (primary)	-2.4%	[-3.4%, -1.6%]	4
Improvements ✅ (secondary)	-2.7%	[-4.5%, -1.0%]	27
All ❌✅ (primary)	2.1%	[-3.4%, 8.7%]	58

Cycles

Results (primary 3.2%, secondary 6.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.2%	[0.9%, 5.3%]	51
Regressions ❌ (secondary)	6.0%	[1.6%, 11.2%]	22
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.2%	[0.9%, 5.3%]	51

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 750.748s -> 751.226s (0.06%)
Artifact size: 371.85 MiB -> 371.87 MiB (0.01%)

bors · 2025-06-12T23:36:21Z

☔ The latest upstream changes (presumably #138164) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 19, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 19, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2025

Auto merge of rust-lang#138705 - oli-obk:hir-split, r=<try>

6f0ff2d

[perf] Decouple directly accessing a HIR owner from ast lowering r? `@ghost`

This comment has been minimized.

Sign in to view

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2025

Auto merge of rust-lang#138705 - oli-obk:hir-split, r=<try>

67ad3c3

[perf] Decouple directly accessing a HIR owner from ast lowering r? `@ghost`

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 19, 2025

This comment has been minimized.

Sign in to view

oli-obk force-pushed the hir-split branch from 5671229 to 0d1af78 Compare March 20, 2025 14:08

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 20, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 20, 2025

Auto merge of rust-lang#138705 - oli-obk:hir-split, r=<try>

658a5a6

[perf] Decouple directly accessing a HIR owner from ast lowering r? `@ghost`

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 20, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2025

Auto merge of rust-lang#138705 - oli-obk:hir-split, r=<try>

2c990c5

[perf] Decouple directly accessing a HIR owner from ast lowering r? `@ghost` cc rust-lang#95004

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 21, 2025

oli-obk added 4 commits June 5, 2025 14:01

Stop using the hir_crate query in hir_walk_attributes

04d077b

Decouple directly accessing a HIR owner from ast lowering

2584823

Feed the hir_owner query instead of the other queries based off it

764815c

Back-and-forth feed the hir_owner query

0ddb721

oli-obk force-pushed the hir-split branch from 4f3ab35 to 0ddb721 Compare June 5, 2025 15:32

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 5, 2025

bors added a commit that referenced this pull request Jun 5, 2025

Auto merge of #138705 - oli-obk:hir-split, r=<try>

fd56196

[perf] Decouple directly accessing a HIR owner from ast lowering r? `@ghost` cc #95004

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jun 6, 2025

Auto merge of #138705 - oli-obk:hir-split, r=<try>

bc256db

[perf] Decouple directly accessing a HIR owner from ast lowering r? `@ghost` cc #95004

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 6, 2025

Dylan-DPC added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2025

Uh oh!

Conversation

oli-obk commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Mar 19, 2025

Uh oh!

This comment has been minimized.

bors commented Mar 19, 2025

Uh oh!

bors commented Mar 19, 2025

Uh oh!

This comment has been minimized.

oli-obk commented Mar 19, 2025

Uh oh!

This comment has been minimized.

bors commented Mar 19, 2025

Uh oh!

bors commented Mar 19, 2025

Uh oh!

rust-timer commented Mar 19, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

oli-obk commented Mar 19, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Mar 20, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

oli-obk commented Mar 20, 2025

Uh oh!

This comment has been minimized.

bors commented Mar 20, 2025

Uh oh!

bors commented Mar 20, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Mar 20, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

This comment has been minimized.

bors commented May 21, 2025

Uh oh!

This comment has been minimized.

rust-timer commented May 21, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

oli-obk commented Jun 5, 2025

Uh oh!

This comment has been minimized.

bors commented Jun 5, 2025

Uh oh!

bors commented Jun 5, 2025

Uh oh!

oli-obk commented Jun 6, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 6, 2025

Uh oh!

rust-bors bot commented Jun 6, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 6, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

bors commented Jun 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

oli-obk commented Mar 19, 2025 •

edited

Loading