Revert "Auto merge of #129827 - bvanjoi:less-decoding, r=petrochenkov"

[Kobzol]

Reverting #129827 because of a performance regression.

This reverts commit d4812c8, reversing changes made to 5cc6072.

r? @petrochenkov

[petrochenkov]

@bors r+

[bors]

📌 Commit 31face9 has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit 31face9 with merge 45b40a7...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 45b40a7 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b9ea82b (parent) -> 45b40a7 (this PR)

Test differences

Show 8 test diffs

Additionally, 8 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Job duration changes

1. aarch64-gnu: 6417.4s -> 9759.9s (52.1%)
2. dist-apple-various: 6762.4s -> 8033.9s (18.8%)
3. x86_64-msvc-ext1: 7016.8s -> 7605.0s (8.4%)
4. mingw-check: 1225.7s -> 1303.5s (6.3%)
5. i686-msvc-2: 6942.1s -> 7341.6s (5.8%)
6. x86_64-msvc-2: 6581.6s -> 6929.6s (5.3%)
7. dist-i686-mingw: 7833.4s -> 8169.4s (4.3%)
8. i686-mingw-3: 7819.7s -> 8128.6s (4.0%)
9. dist-aarch64-apple: 4834.8s -> 5022.6s (3.9%)
10. dist-armhf-linux: 5012.4s -> 5204.9s (3.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (45b40a7): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.4%, 0.6%]	2
Improvements ✅ (primary)	-0.9%	[-3.6%, -0.1%]	74
Improvements ✅ (secondary)	-2.2%	[-5.7%, -0.2%]	37
All ❌✅ (primary)	-0.9%	[-3.6%, -0.1%]	74

Max RSS (memory usage)

Results (secondary 2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[1.3%, 3.5%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -2.3%, secondary -2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.7%, -1.9%]	5
Improvements ✅ (secondary)	-2.8%	[-3.5%, -2.2%]	4
All ❌✅ (primary)	-2.3%	[-2.7%, -1.9%]	5

Binary size

Results (primary 0.2%, secondary 0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.0%, 0.9%]	121
Regressions ❌ (secondary)	0.4%	[0.0%, 0.9%]	39
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.0%, 0.9%]	121

Bootstrap: 778.078s -> 777.758s (-0.04%)
Artifact size: 365.93 MiB -> 365.96 MiB (0.01%)