tests/codegen: ignore x86-64-v3 in issue-101082 for now#139503
Closed
cuviper wants to merge 1 commit intorust-lang:masterfrom
Closed
tests/codegen: ignore x86-64-v3 in issue-101082 for now#139503cuviper wants to merge 1 commit intorust-lang:masterfrom
issue-101082 for now#139503cuviper wants to merge 1 commit intorust-lang:masterfrom
Conversation
LLVM is struggling to optimize this test when AVX is enabled, but there's not much Rust can be expected to do about it. Let's ignore that part until we learn more on the LLVM side, hopefully fixed and updated.
rustbot
added
S-waiting-on-review
Member
|
I was also disabling this particular array length in https://github.com/rust-lang/rust/pull/139430/files#diff-a6f7809c5adbbdcc5080d91b5615b2d7ec2e69a5df97470dd3d7d13a9a90cab0R16 while keeping the test for that CPU with a different length that's easier to optimize (by being a multiple of the vector size), so accepting that PR would be another way to accomplish this goal. |
Collaborator
|
☔ The latest upstream changes (presumably #139430) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVM is struggling to optimize this test when AVX is enabled, but
there's not much Rust can be expected to do about it. Let's ignore that
part until we learn more on the LLVM side, hopefully fixed and updated.
Ref: llvm/llvm-project#134513 llvm/llvm-project#134735
Unblocks: #138380
cc @scottmcm
r? nikic