Skip to content

Add socket extensions for cygwin#139524

Merged
bors merged 1 commit intorust-lang:masterfrom
Berrysoft:cygwin-socket-ext
Sep 7, 2025
Merged

Add socket extensions for cygwin#139524
bors merged 1 commit intorust-lang:masterfrom
Berrysoft:cygwin-socket-ext

Conversation

@Berrysoft
Copy link
Contributor

@Berrysoft Berrysoft commented Apr 8, 2025 •
edited
Loading

r? @joboet

  • Abstract name uds addr
  • quickack
  • passcred

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 8, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Berrysoft Berrysoft marked this pull request as ready for review April 8, 2025 15:03
@Berrysoft
Copy link
Contributor Author

Berrysoft commented Apr 9, 2025 •
edited
Loading

Some limitations:

  • Cannot connect the addr from recvfrom of a unix datagram socket.
    • It seems like a bug of cygwin.
    • A patch has been proposed.
    • UPDATE: patch merged. Now the test passes.
  • Cannot bind to abstract addr - not supported by cygwin.
  • Unbounded unix socket has an abstract local addr - a feature (autobind?) of cygwin.
  • Unix socket doesn't support recvmsg with control data. It fallbacks to recvmsg without control data.
  • Unix socket connect blocks until the server accepts it. See mailing list. I have to ignore some tests because of that.

@Berrysoft Berrysoft force-pushed the cygwin-socket-ext branch 2 times, most recently from e0b30bf to ce3ee0c Compare April 11, 2025 01:55
@jieyouxu jieyouxu added the O-cygwin Target: *-pc-cygwin label Apr 25, 2025
@bors
Copy link
Collaborator

bors commented Jun 29, 2025

☔ The latest upstream changes (presumably #143157) made this pull request unmergeable. Please resolve the merge conflicts.

@mati865
Copy link
Member

mati865 commented Aug 10, 2025

I think Jonas doesn't do reviews currently. @Berrysoft can you solve conflicts? We will reroll the reviewer.

@Berrysoft
Copy link
Contributor Author

Berrysoft commented Aug 11, 2025

Thanks! I have rebased the PR.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@mati865
Copy link
Member

mati865 commented Aug 11, 2025

Thanks.

r? rust-lang/libs

@rustbot rustbot assigned thomcc and unassigned joboet Aug 11, 2025
@mati865
Copy link
Member

mati865 commented Aug 23, 2025

Rerolling: #144651 (comment)

r? rust-lang/libs

@rustbot rustbot assigned tgross35 and unassigned thomcc Aug 23, 2025
tgross35
tgross35 requested changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a docs request then r=me with a squash

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2025
@Berrysoft
Copy link
Contributor Author

Berrysoft commented Sep 6, 2025

@rustbot ready

r? tgross35

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2025

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

@Berrysoft Berrysoft requested a review from tgross35 September 6, 2025 12:26
@tgross35
Copy link
Contributor

tgross35 commented Sep 6, 2025

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 6, 2025

📌 Commit 26b1575 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2025
@tgross35 tgross35 mentioned this pull request Sep 6, 2025
Merged
bors added a commit that referenced this pull request Sep 6, 2025
@bors
Auto merge of #146282 - tgross35:rollup-0n5tjnm, r=tgross35
76863e3 
Rollup of 5 pull requests

Successful merges:

 - #139524 (Add socket extensions for cygwin)
 - #145940 (single buffer for exponent fmt of integers)
 - #146206 (identity uses are ok, even if there are no defining uses)
 - #146272 (Update comment for `-Werror` on LLVM builds)
 - #146280 (Make `LetChainsPolicy` public for rustfmt usage)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 31d7cbc into rust-lang:master Sep 7, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 7, 2025
rust-timer added a commit that referenced this pull request Sep 7, 2025
@rust-timer
Unrolled build for #139524
572793b 
Rollup merge of #139524 - Berrysoft:cygwin-socket-ext, r=tgross35

Add socket extensions for cygwin

r? `@joboet`

* Abstract name uds addr
* quickack
* passcred
@Berrysoft Berrysoft deleted the cygwin-socket-ext branch September 7, 2025 01:58
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Sep 8, 2025
@bors
Auto merge of #146282 - tgross35:rollup-0n5tjnm, r=tgross35
99edef7 
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#139524 (Add socket extensions for cygwin)
 - rust-lang/rust#145940 (single buffer for exponent fmt of integers)
 - rust-lang/rust#146206 (identity uses are ok, even if there are no defining uses)
 - rust-lang/rust#146272 (Update comment for `-Werror` on LLVM builds)
 - rust-lang/rust#146280 (Make `LetChainsPolicy` public for rustfmt usage)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Sep 10, 2025
@tgross35
Rollup merge of rust-lang#139524 - Berrysoft:cygwin-socket-ext, r=tgr…
0616edc 
…oss35

Add socket extensions for cygwin

r? `@joboet`

* Abstract name uds addr
* quickack
* passcred
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@bors
Auto merge of #146282 - tgross35:rollup-0n5tjnm, r=tgross35
11a0729 
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#139524 (Add socket extensions for cygwin)
 - rust-lang/rust#145940 (single buffer for exponent fmt of integers)
 - rust-lang/rust#146206 (identity uses are ok, even if there are no defining uses)
 - rust-lang/rust#146272 (Update comment for `-Werror` on LLVM builds)
 - rust-lang/rust#146280 (Make `LetChainsPolicy` public for rustfmt usage)

r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
@bors
Auto merge of #146282 - tgross35:rollup-0n5tjnm, r=tgross35
b773f9f 
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#139524 (Add socket extensions for cygwin)
 - rust-lang/rust#145940 (single buffer for exponent fmt of integers)
 - rust-lang/rust#146206 (identity uses are ok, even if there are no defining uses)
 - rust-lang/rust#146272 (Update comment for `-Werror` on LLVM builds)
 - rust-lang/rust#146280 (Make `LetChainsPolicy` public for rustfmt usage)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels

O-cygwin Target: *-pc-cygwin O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

9 participants

@Berrysoft @rust-log-analyzer @bors @mati865 @rustbot @tgross35 @thomcc @joboet @jieyouxu