UI tests: add missing diagnostic kinds where possible

[petrochenkov]

The subset of #139427 that only adds diagnostic kinds to line annotations, without changing any other things in annotations or compiletest.
After this only non-viral NOTEs and HELPs should be missing.

r? @jieyouxu

[jieyouxu]

Thanks, test changes LGTM

[jieyouxu]

Yeah, this is nice

[jieyouxu]

Very conflict-prone so
@bors r+ rollup=never p=10

[bors]

📌 Commit b3f7535 has been approved by jieyouxu

It is now in the queue for this repository.

[bors]

⌛ Testing commit b3f7535 with merge c1b8b7e...

[bors]

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing c1b8b7e to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing de5b8a4 (parent) -> c1b8b7e (this PR)

Test differences

Show 32998 test diffs

Stage 1

• array::array_mixed_equality_nans: pass -> [missing] (J0)
• cmp::test_user_defined_eq: pass -> [missing] (J0)
• collections::btree::map::tests::test_pop_first_last: pass -> [missing] (J0)
• fmt::builders::debug_list::test_empty_non_exhaustive: pass -> [missing] (J0)
• io::stdio::tests::panic_doesnt_poison: pass -> [missing] (J0)
• iter::range::test_double_ended_range: pass -> [missing] (J0)
• mem::size_of_64: pass -> [missing] (J0)
• num::bignum::test_sub: pass -> [missing] (J0)
• num::f32::min: pass -> [missing] (J0)
• num::test_try_i16u16: pass -> [missing] (J0)
• ops::test_bound_cloned_excluded: pass -> [missing] (J0)
• ops::test_range_from: pass -> [missing] (J0)
• pin_macro::extension_works_through_block: pass -> [missing] (J0)
• result::test_and: pass -> [missing] (J0)
• slice::select_nth_unstable_past_length: pass -> [missing] (J0)
• slice::split_off_in_bounds_range_from: pass -> [missing] (J0)
• slice::test_array_chunks_infer: pass -> [missing] (J0)
• slice::test_remove: pass -> [missing] (J0)
• str::pattern::str_searcher_ascii_haystack_seq::bwd: pass -> [missing] (J0)
• string::test_pop: pass -> [missing] (J0)
• string::test_split_off_empty: pass -> [missing] (J0)
• sys_common::wtf8::tests::wtf8buf_show_str: pass -> [missing] (J0)
• vec::zero_sized_values: pass -> [missing] (J0)
• clean::types::tests::should_unindent_multiple_paragraphs: pass -> [missing] (J1)
• errors::verify_ast_passes_const_and_coroutine_50: pass -> [missing] (J1)
• errors::verify_const_eval_non_const_question_from_residual_29: pass -> [missing] (J1)
• errors::verify_mir_build_static_in_pattern_0: pass -> [missing] (J1)
• html::url_parts_builder::tests::singleton: pass -> [missing] (J1)
• source_map::tests::path_prefix_remapping: pass -> [missing] (J1)
• spec::tests::arm64e_apple_darwin: pass -> [missing] (J1)
• spec::tests::armv7_unknown_linux_musleabihf: pass -> [missing] (J1)
• spec::tests::armv7a_none_eabi: pass -> [missing] (J1)
• spec::tests::thumbv8m_main_none_eabihf: pass -> [missing] (J1)
• ascii::short::case05_branchless: pass -> [missing] (J2)
• btree::set::intersection_random_10k_vs_100: pass -> [missing] (J2)
• char::methods::bench_to_digit_radix_2: pass -> [missing] (J2)
• iter::bench_filter_chain_ref_sum: pass -> [missing] (J2)
• sort::tests::unstable::panic_retain_orig_set_cell_i32_ascending: pass -> [missing] (J2)
• sort::tests::unstable::stability_string_random: pass -> [missing] (J2)
• str::find_underscore_char::short_pile_of_poo: pass -> [missing] (J2)
• tests::shuffle_tests: pass -> [missing] (J2)
• vec::bench_nest_chain_chain_collect: pass -> [missing] (J2)
• sort::tests::stable::observable_is_less_ascending: ignore -> [missing] (J3)
• sort::tests::unstable::panic_retain_orig_set_string_ascending: ignore -> [missing] (J3)

Stage 2

• ascii::test_is_ascii: [missing] -> pass (J0)
• borrow::test_from_cow_os_str: [missing] -> pass (J0)
• btree_set_hash::test_hash: [missing] -> pass (J0)
• collections::binary_heap::test_peek_mut_pop: [missing] -> pass (J0)
• collections::btree::set::tests::test_clone_eq: [missing] -> pass (J0)
• collections::hash::set::tests::test_disjoint: [missing] -> pass (J0)
• dynamic_tests::smoke: [missing] -> pass (J0)
• f16::test_nan: [missing] -> pass (J0)
• f32::test_clamp_min_greater_than_max: [missing] -> pass (J0)
• f32::test_exp2: [missing] -> pass (J0)
• io::tests::read_until: [missing] -> pass (J0)
• mpmc::stress: [missing] -> pass (J0)
• mpsc_sync::shared_chan_stress: [missing] -> pass (J0)
• net::ip_addr::ipv4_to_ipv6: [missing] -> pass (J0)
• nonzero::test_nonzero_from_int_on_err: [missing] -> pass (J0)
• num::i16::test_le: [missing] -> pass (J0)
• num::test_try_i128u8: [missing] -> pass (J0)
• num::u128::test_widening_mul: [missing] -> pass (J0)
• num::u64::test_count_zeros: [missing] -> pass (J0)
• ptr::ptr_metadata_bounds: [missing] -> pass (J0)
• task::waker_const: [missing] -> pass (J0)
• vec::test_vec_dedup_by: [missing] -> pass (J0)
• vec_deque::test_param_taggy: [missing] -> pass (J0)
• vec_deque::test_simple: [missing] -> pass (J0)
• errors::verify_incremental_no_cfg_14: [missing] -> pass (J1)
• errors::verify_passes_debug_visualizer_invalid_80: [missing] -> pass (J1)
• errors::verify_passes_non_exported_macro_invalid_attrs_98: [missing] -> pass (J1)
• errors::verify_session_profile_use_file_does_not_exist_4: [missing] -> pass (J1)
• html::length_limit::tests::limit_0: [missing] -> pass (J1)
• html::render::write_shared::tests::all_crates_parts: [missing] -> pass (J1)
• interval::tests::last_set_before_adjacent: [missing] -> pass (J1)
• mir::interpret::allocation::init_mask::tests::grow_mixed_state_within_unused_bits_and_full_overwrite: [missing] -> pass (J1)
• opaque::tests::test_string: [missing] -> pass (J1)
• parser::tests::multiple_labels_with_message: [missing] -> pass (J1)
• session_diagnostics::verify_attr_parsing_rustc_allowed_unstable_pairing_18: [missing] -> pass (J1)
• spec::tests::thumbv7neon_unknown_linux_musleabihf: [missing] -> pass (J1)
• ascii::long::case10_mask_mult_bool_lookup_table: [missing] -> pass (J2)
• btree::set::intersection_10k_pos_vs_100_neg: [missing] -> pass (J2)
• btree::set::is_subset_100_vs_10k: [missing] -> pass (J2)
• fmt::write_str_macro_debug: [missing] -> pass (J2)
• fs::tests::realpath_works: [missing] -> pass (J2)
• hash::set_ops::set_symmetric_difference: [missing] -> pass (J2)
• net::tcp::tests::multiple_connect_interleaved_lazy_schedule: [missing] -> pass (J2)
• num::int_sqrt::u128_sqrt_uniform: [missing] -> pass (J2)
• sort::tests::stable::correct_cell_i32_descending: [missing] -> pass (J2)
• sort::tests::stable::deterministic_i32_random_d2: [missing] -> pass (J2)
• sort::tests::unstable::self_cmp_i32_descending: [missing] -> pass (J2)
• str::char_iterator_rev_for: [missing] -> pass (J2)
• str::to_lowercase::short_mixed: [missing] -> pass (J2)
• str::trim_ascii_char::long_lorem_ipsum: [missing] -> pass (J2)
• vec::bench_in_place_collect_droppable: [missing] -> pass (J2)
• vec::bench_next_chunk: [missing] -> pass (J2)
• vec::bench_with_capacity_0000: [missing] -> pass (J2)
• sort::tests::stable::deterministic_string_random_s95: [missing] -> ignore (J3)
• sort::tests::stable::self_cmp_i32_random_d20: [missing] -> ignore (J3)
• sort::tests::unstable::violate_ord_retain_orig_set_i32_descending: [missing] -> ignore (J3)

(and 16402 additional test diffs)

Additionally, 16496 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: aarch64-apple, test-various, x86_64-apple-1, x86_64-gnu-aux
• J1: aarch64-apple, x86_64-apple-1
• J2: aarch64-apple, test-various, x86_64-apple-1
• J3: x86_64-gnu-aux

Job duration changes

1. dist-aarch64-apple: 4251.8s -> 5022.5s (18.1%)
2. dist-various-2: 3320.7s -> 3485.0s (4.9%)
3. dist-i686-msvc: 6849.1s -> 7162.0s (4.6%)
4. dist-x86_64-musl: 7278.6s -> 7599.2s (4.4%)
5. x86_64-gnu-llvm-19-2: 6001.8s -> 6229.5s (3.8%)
6. dist-x86_64-mingw: 7593.3s -> 7832.7s (3.2%)
7. dist-armhf-linux: 5069.0s -> 5220.9s (3.0%)
8. dist-x86_64-msvc-alt: 7414.4s -> 7635.5s (3.0%)
9. dist-ohos: 10570.6s -> 10840.7s (2.6%)
10. x86_64-mingw-2: 6969.8s -> 7146.6s (2.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (c1b8b7e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.2%, secondary -2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.2%	[3.7%, 4.7%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	4.2%	[3.7%, 4.7%]	2

Cycles

Results (primary 0.9%, secondary 1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.9%, 0.9%]	1
Regressions ❌ (secondary)	1.8%	[1.8%, 1.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.9%	[0.9%, 0.9%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.068s -> 780.154s (0.27%)
Artifact size: 366.11 MiB -> 366.11 MiB (-0.00%)