bootstrap: Inhibit download-rustc in CI when tools are changed#140322
bootstrap: Inhibit download-rustc in CI when tools are changed#140322Zalathar wants to merge 2 commits intorust-lang:masterfrom
Conversation
|
rustbot has assigned @albertlarsan68. Use |
|
This PR modifies If appropriate, please update |
This comment has been minimized.
This comment has been minimized.
9f355a3 to
b05be37
Compare
|
Like I said on the Zulip thread, I think the proper solution would be to investigate and fix the issue of "some tests being ignored" rather than excluding tool paths from ci-rustc. Those tools don't have any effect on the rustc builds. |
|
@rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
|
☔ The latest upstream changes (presumably #119899) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Declaring bankruptcy on all my stale PRs. |
This automatically avoids situations like #139998 (comment) and #140177 (comment), where a sensitive change to compiletest was eligible for download-rustc, preventing the collection of proper test metrics for comparison.
While the primary goal is to make compiletest changes inhibit download-rustc, this PR ends up making any change to
src/toolsinhibit download-rustc (but only in CI builds). With the current code, it's not clear how to “un-exempt” individual subdirectories that are covered by another exemption.See https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Should.20tool.20changes.20inhibit.20download-rustc.20on.20CI.3F for associated discussion.