Rollup of 7 pull requests by matthiaskrgr · Pull Request #140329 · rust-lang/rust

matthiaskrgr · 2025-04-26T08:30:18Z

Successful merges:

Implement a lint for implicit autoref of raw pointer dereference - take 2 #123239 (Implement a lint for implicit autoref of raw pointer dereference - take 2)
transmutability: Support char, NonZeroXxx #140215 (transmutability: Support char, NonZeroXxx)
Update wasm-component-ld to 0.5.13 #140226 (Update wasm-component-ld to 0.5.13)
Move inline asm check to typeck, properly handle aliases #140302 (Move inline asm check to typeck, properly handle aliases)
Remove redundant check #140317 (Remove redundant check)
Simply try to unpeel AsyncFnKindHelper goal in emit_specialized_closure_kind_error #140318 (Simply try to unpeel AsyncFnKindHelper goal in emit_specialized_closure_kind_error)
Grammar fixes for BufRead::has_data_left docs #140325 (Grammar fixes for BufRead::has_data_left docs)

r? @ghost
@rustbot modify labels: rollup

This commit updates the vendored `wasm-component-ld` binary to 0.5.13 which includes some various bug fixes and new feature updates for upcoming component model features coming down the pike. Not expected to break any existing workflows, just a normal update.

Note that `NonZero` support is not wired up, as the author encountered bugs while attempting this. A future commit will wire up `NonZero` support.

…re_kind_error

… r=jdonszelmann,traviscross Implement a lint for implicit autoref of raw pointer dereference - take 2 *[t-lang nomination comment](rust-lang#123239 (comment) This PR aims at implementing a lint for implicit autoref of raw pointer dereference, it is based on rust-lang#103735 with suggestion and improvements from rust-lang#103735 (comment). The goal is to catch cases like this, where the user probably doesn't realise it just created a reference. ```rust pub struct Test { data: [u8], } pub fn test_len(t: *const Test) -> usize { unsafe { (*t).data.len() } // this calls <[T]>::len(&self) } ``` Since rust-lang#103735 already went 2 times through T-lang, where they T-lang ended-up asking for a more restricted version (which is what this PR does), I would prefer this PR to be reviewed first before re-nominating it for T-lang. ---- Compared to the PR it is as based on, this PR adds 3 restrictions on the outer most expression, which must either be: 1. A deref followed by any non-deref place projection (that intermediate deref will typically be auto-inserted) 2. A method call annotated with `#[rustc_no_implicit_refs]`. 3. A deref followed by a `addr_of!` or `addr_of_mut!`. See bottom of post for details. There are several points that are not 100% clear to me when implementing the modifications: - ~~"4. Any number of automatically inserted deref/derefmut calls." I as never able to trigger this. Am I missing something?~~ Fixed - Are "index" and "field" enough? ---- cc ``@JakobDegen`` ``@WaffleLapkin`` r? ``@RalfJung``

…o, r=jswrenn transmutability: Support char, NonZeroXxx Note that `NonZero` support is not wired up, as the author encountered bugs while attempting this. A future commit will wire up `NonZero` support. r? ``@jswrenn``

…-ld, r=jieyouxu Update wasm-component-ld to 0.5.13 This commit updates the vendored `wasm-component-ld` binary to 0.5.13 which includes some various bug fixes and new feature updates for upcoming component model features coming down the pike. Not expected to break any existing workflows, just a normal update.

…lcnr Move inline asm check to typeck, properly handle aliases Pull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. To fix rust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`. r? lcnr

Remove redundant check We still check for `rustc_on_unimplemented` on implementations, but this functionality was removed in rust-lang#139091, since then it always returns `Ok` when called with a non-trait defid. https://github.com/rust-lang/rust/blob/b4c8b0c3f0533bb342a4873ff59bdad3883ab8e3/compiler/rustc_trait_selection/src/error_reporting/traits/on_unimplemented.rs#L557-L564

…fn-kind-err, r=fee1-dead Simply try to unpeel AsyncFnKindHelper goal in `emit_specialized_closure_kind_error` Tweak the handling of `AsyncFnKindHelper` goals in `emit_specialized_closure_kind_error` to not be so special-casey, and just try to unpeel one or two layers of obligation causes to get to their underlying `AsyncFn*` goal. Fixes rust-lang#140292

…for-bufread-has-data-left-docs, r=jhpratt Grammar fixes for BufRead::has_data_left docs Fix some grammar in the documentation for `BufRead::has_data_left`

matthiaskrgr · 2025-04-26T08:30:51Z

@bors r+ rollup=never p=5

bors · 2025-04-26T08:30:54Z

📌 Commit af18438 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-04-26T10:24:18Z

⌛ Testing commit af18438 with merge c6f4ff1...

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#123239 (Implement a lint for implicit autoref of raw pointer dereference - take 2) - rust-lang#140215 (transmutability: Support char, NonZeroXxx) - rust-lang#140226 (Update wasm-component-ld to 0.5.13) - rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) - rust-lang#140317 (Remove redundant check) - rust-lang#140318 (Simply try to unpeel AsyncFnKindHelper goal in `emit_specialized_closure_kind_error`) - rust-lang#140325 (Grammar fixes for BufRead::has_data_left docs) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-04-26T11:18:47Z

The job test-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] tests/ui/asm/normalizable-asm-ty.rs#next stdout ----

error in revision `next`: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/asm/normalizable-asm-ty.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=wasm32-wasip1" "--cfg" "next" "--check-cfg" "cfg(test,FALSE,current,next)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm/normalizable-asm-ty.next" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/wasm32-wasip1/native/rust-test-helpers" "-Znext-solver"
stdout: none
--- stderr -------------------------------
error[E0658]: inline assembly is not stable yet on this architecture
##[error]  --> /checkout/tests/ui/asm/normalizable-asm-ty.rs:8:9
   |
LL | /         std::arch::asm!(
LL | |             "/* {} */",
LL | |             in(reg) pc_section[0]
LL | |         );
   | |_________^
   |
   = note: see issue #93335 <https://github.com/rust-lang/rust/issues/93335> for more information
   = help: add `#![feature(asm_experimental_arch)]` to the crate attributes to enable
   = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date

error: invalid register class `reg`: unknown register class
##[error]  --> /checkout/tests/ui/asm/normalizable-asm-ty.rs:10:13
   |
LL |             in(reg) pc_section[0]
   |             ^^^^^^^^^^^^^^^^^^^^^
   |
   = note: the following register classes are supported on this target: `local`

error: aborting due to 2 previous errors
---
---- [ui] tests/ui/asm/normalizable-asm-ty.rs#current stdout ----

error in revision `current`: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/asm/normalizable-asm-ty.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=wasm32-wasip1" "--cfg" "current" "--check-cfg" "cfg(test,FALSE,current,next)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm/normalizable-asm-ty.current" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/wasm32-wasip1/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0658]: inline assembly is not stable yet on this architecture
##[error]  --> /checkout/tests/ui/asm/normalizable-asm-ty.rs:8:9
   |
LL | /         std::arch::asm!(
LL | |             "/* {} */",
LL | |             in(reg) pc_section[0]
LL | |         );
   | |_________^
   |
   = note: see issue #93335 <https://github.com/rust-lang/rust/issues/93335> for more information
   = help: add `#![feature(asm_experimental_arch)]` to the crate attributes to enable
   = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date

error: invalid register class `reg`: unknown register class
##[error]  --> /checkout/tests/ui/asm/normalizable-asm-ty.rs:10:13
   |
LL |             in(reg) pc_section[0]
   |             ^^^^^^^^^^^^^^^^^^^^^
   |
   = note: the following register classes are supported on this target: `local`

error: aborting due to 2 previous errors

bors · 2025-04-26T11:19:25Z

💔 Test failed - checks-actions

Urgau and others added 16 commits April 20, 2025 11:36

Add #[rustc_no_implicit_autorefs] and apply it to std methods

1632f62

Implement lint against dangerous implicit autorefs

40ba47d

Allow dangerous_implicit_autorefs lint in some tests

e8a6c17

Move inline_asm to typeck, properly handle aliases

f769f42

transmutability: Support char, NonZeroXxx

ae0c2fe

Note that `NonZero` support is not wired up, as the author encountered bugs while attempting this. A future commit will wire up `NonZero` support.

Remove redundant check

1ec3e62

Simply try to unpeel AsyncFnKindHelper goal in emit_specialized_closu…

4b309c6

…re_kind_error

Grammar fixes for BufRead::has_data_left docs

0084862

Rollup merge of rust-lang#140325 - ethanwu10:ethanwu10/grammar-fixes-…

af18438

…for-bufread-has-data-left-docs, r=jhpratt Grammar fixes for BufRead::has_data_left docs Fix some grammar in the documentation for `BufRead::has_data_left`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2025

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 26, 2025

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2025

matthiaskrgr mentioned this pull request Apr 26, 2025

Move inline asm check to typeck, properly handle aliases #140302

Merged

matthiaskrgr closed this Apr 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests#140329

Rollup of 7 pull requests#140329
matthiaskrgr wants to merge 16 commits intorust-lang:masterfrom
matthiaskrgr:rollup-9itify0

matthiaskrgr commented Apr 26, 2025

Uh oh!

matthiaskrgr commented Apr 26, 2025

Uh oh!

bors commented Apr 26, 2025

Uh oh!

bors commented Apr 26, 2025

Uh oh!

rust-log-analyzer commented Apr 26, 2025

Uh oh!

bors commented Apr 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

matthiaskrgr commented Apr 26, 2025

Uh oh!

matthiaskrgr commented Apr 26, 2025

Uh oh!

bors commented Apr 26, 2025

Uh oh!

bors commented Apr 26, 2025

Uh oh!

rust-log-analyzer commented Apr 26, 2025

Uh oh!

bors commented Apr 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants