Skip to content

Fix a compiletest blessing message#140953

Merged
bors merged 1 commit intorust-lang:masterfrom
jieyouxu:compiletest-bless-msg
May 15, 2025
Merged

Fix a compiletest blessing message#140953
bors merged 1 commit intorust-lang:masterfrom
jieyouxu:compiletest-bless-msg

Conversation

@jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented May 12, 2025 •
edited
Loading

It was showing compare mode instead of test name.

Fixes #140945.
Noticed in #140622 (comment).

@jieyouxu
compiletest: fix "blessing" message
82fbbc0 
It was showing compare mode instead of test name.
@rustbot
Copy link
Collaborator

rustbot commented May 12, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 12, 2025
@compiler-errors
Copy link
Contributor

compiler-errors commented May 12, 2025

r? compiler-errors

@rustbot rustbot assigned compiler-errors and unassigned oli-obk May 12, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented May 13, 2025

@bors r=@compiler-errors rollup

@bors
Copy link
Collaborator

bors commented May 13, 2025

📌 Commit 82fbbc0 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2025
@bors
Auto merge of rust-lang#140953 - jieyouxu:compiletest-bless-msg, r=co…
c0ac7d5 
…mpiler-errors

Fix a compiletest blessing message

It was showing compare mode instead of test name.

Fixes rust-lang#140945.
Noticed in rust-lang#140622 (comment).
@bors
Copy link
Collaborator

bors commented May 14, 2025

⌛ Testing commit 82fbbc0 with merge c0ac7d5...

@bors
Copy link
Collaborator

bors commented May 14, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 14, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented May 14, 2025

@bors retry (no idea)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request May 14, 2025
@jieyouxu
Rollup merge of rust-lang#140953 - jieyouxu:compiletest-bless-msg, r=…
121880a 
…compiler-errors

Fix a compiletest blessing message

It was showing compare mode instead of test name.

Fixes rust-lang#140945.
Noticed in rust-lang#140622 (comment).
@jieyouxu jieyouxu mentioned this pull request May 14, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2025
@bors
Auto merge of rust-lang#140993 - jieyouxu:rollup-rb13gfl, r=jieyouxu
3c15a9d 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#140953 (Fix a compiletest blessing message)
 - rust-lang#140973 (Update rustix to 1.0.7 for bootstrap)
 - rust-lang#140976 (Add `Ipv4Addr` and `Ipv6Addr` diagnostic items)
 - rust-lang#140977 ([win] Use a dash instead of slash for linker to avoid breaking lld)

r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxu
Copy link
Member Author

jieyouxu commented May 14, 2025

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 14, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented May 14, 2025

Oh it's the msvc job running out of disk space (?)
@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented May 14, 2025

📌 Commit 82fbbc0 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 14, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request May 14, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2025
@bors
Auto merge of rust-lang#141011 - matthiaskrgr:rollup-4uwllo2, r=matth…
695b091 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#140827 (Do not ICE when reassigning in GatherLocalsVisitor on the bad path)
 - rust-lang#140904 (Add an issue template for future-incompatible lints)
 - rust-lang#140953 (Fix a compiletest blessing message)
 - rust-lang#140973 (Update rustix to 1.0.7 for bootstrap)
 - rust-lang#140976 (Add `Ipv4Addr` and `Ipv6Addr` diagnostic items)
 - rust-lang#140988 (MaybeUninit::write: fix doc)
 - rust-lang#140989 (Suggest replace f with f: Box<f> when expr field is short hand)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2025
@bors
Auto merge of rust-lang#141011 - matthiaskrgr:rollup-4uwllo2, r=matth…
e46194e 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#140827 (Do not ICE when reassigning in GatherLocalsVisitor on the bad path)
 - rust-lang#140904 (Add an issue template for future-incompatible lints)
 - rust-lang#140953 (Fix a compiletest blessing message)
 - rust-lang#140973 (Update rustix to 1.0.7 for bootstrap)
 - rust-lang#140976 (Add `Ipv4Addr` and `Ipv6Addr` diagnostic items)
 - rust-lang#140988 (MaybeUninit::write: fix doc)
 - rust-lang#140989 (Suggest replace f with f: Box<f> when expr field is short hand)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2025
@bors
Auto merge of rust-lang#141011 - matthiaskrgr:rollup-4uwllo2, r=matth…
d163a28 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#140827 (Do not ICE when reassigning in GatherLocalsVisitor on the bad path)
 - rust-lang#140904 (Add an issue template for future-incompatible lints)
 - rust-lang#140953 (Fix a compiletest blessing message)
 - rust-lang#140973 (Update rustix to 1.0.7 for bootstrap)
 - rust-lang#140976 (Add `Ipv4Addr` and `Ipv6Addr` diagnostic items)
 - rust-lang#140988 (MaybeUninit::write: fix doc)
 - rust-lang#140989 (Suggest replace f with f: Box<f> when expr field is short hand)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8e34100 into rust-lang:master May 15, 2025
6 of 7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 15, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2025
@rust-timer
Unrolled build for rust-lang#140953
4c7c810 
Rollup merge of rust-lang#140953 - jieyouxu:compiletest-bless-msg, r=compiler-errors

Fix a compiletest blessing message

It was showing compare mode instead of test name.

Fixes rust-lang#140945.
Noticed in rust-lang#140622 (comment).
@jieyouxu jieyouxu deleted the compiletest-bless-msg branch May 15, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@compiler-errors compiler-errors compiler-errors approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@compiler-errors compiler-errors

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

compiletest "Blessing the {stream} of {test_name} in {expected_path:?}" test name is incorrect

5 participants

@jieyouxu @rustbot @compiler-errors @bors @oli-obk