Remove #![feature(let_chains)] from library and src/librustdoc by est31 · Pull Request #140966 · rust-lang/rust

est31 · 2025-05-13T13:16:02Z

PR #132833 has stabilized the let_chains feature. This PR removes the last occurences from the library, the compiler, and librustdoc (also because #140887 missed the conditional in one of the crates as it was behind the "rustc" feature).

We keep core as exercise for the future as updating it is non-trivial (see PR thread).

rustbot · 2025-05-13T13:16:07Z

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-05-13T13:16:09Z

Some changes occurred in exhaustiveness checking

cc @Nadrieril

samueltardieu · 2025-05-13T21:23:43Z

"--edition" "2021"

It looks like the tests/run-make tests have not been updated to use edition 2024.

rustbot · 2025-05-13T22:22:51Z

This PR modifies run-make tests.

cc @jieyouxu

est31 · 2025-05-14T20:46:20Z

Updated that test to edition 2024

tgross35 · 2025-05-14T22:29:46Z

@bors r+

bors · 2025-05-14T22:29:49Z

📌 Commit 79b2794 has been approved by tgross35

It is now in the queue for this repository.

bors · 2025-05-14T22:29:49Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

Remove #![feature(let_chains)] from library and src/librustdoc PR rust-lang#132833 has stabilized the `let_chains` feature. This PR removes the last occurences from the library, the compiler, and librustdoc (also because rust-lang#140887 missed the conditional in one of the crates as it was behind the "rustc" feature).

…mpiler-errors Rollup of 14 pull requests Successful merges: - rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary") - rust-lang#140130 (Add LLDB providers for BTreeMap and BTreeSet) - rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`) - rust-lang#140712 (normalization: avoid incompletely constraining GAT args) - rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output) - rust-lang#140834 (move (or remove) some impl Trait tests) - rust-lang#140910 (Remove `stable` attribute from wasi fs (read_exact|write_all)_at) - rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`) - rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc) - rust-lang#140977 ([win] Use a dash instead of slash for linker to avoid breaking lld) - rust-lang#140990 (VxWorks: updates from recent libc versions) - rust-lang#141003 (Improve ternary operator recovery) - rust-lang#141013 (Implement methods to set STARTUPINFO flags for Command API on Windows) - rust-lang#141026 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary") - rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`) - rust-lang#140712 (normalization: avoid incompletely constraining GAT args) - rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output) - rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`) - rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc) - rust-lang#140990 (VxWorks: updates from recent libc versions) - rust-lang#141027 (remove `RustfmtState` to reduce `initial_rustfmt` complexity) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2025-05-15T20:28:31Z

@bors r-
#141040 (comment)

tgross35 · 2025-05-16T13:56:04Z

I have removed core for now as it's non trivial, per above. Let's get the trivial removals done first.

Isn't the change for library/core/src/lib.rs is still removing the feature gate? The force push doesn't show any diff https://github.com/rust-lang/rust/compare/79b27947794e7b8bf89c46779a0ff69865888744..5013a9761ed815988bb71eed66fef676813b18b4.

est31 · 2025-05-16T14:15:14Z

@tgross35 good point. I have force pushed a new version without the core changes.

tgross35 · 2025-05-16T14:29:17Z

@bors r+

bors · 2025-05-16T14:29:21Z

📌 Commit 258e880 has been approved by tgross35

It is now in the queue for this repository.

nbdd0121 · 2025-05-17T08:39:40Z

If you still want to make core changes, you can modify src/ci/docker/scripts/rfl-build.sh to use 21e9042f91922761532470c6540a1e18a3be89a7 instead of v6.15-rc4.

BTW: I think the ping group is still broken..

jieyouxu · 2025-05-17T12:36:28Z

BTW: I think the ping group is still broken..

I'll double-check and file a bug against triagebot.

EDIT: rust-lang/triagebot#1992

Fix Rust for Linux ping group label Noticed in rust-lang#140966 (comment). Seems like a broken label can cause the triagebot ping message to not be issued. See rust-lang/triagebot#1992. `@rustbot` label: +A-rust-for-linux

Remove #![feature(let_chains)] from library and src/librustdoc PR rust-lang#132833 has stabilized the `let_chains` feature. This PR removes the last occurences from the library, the compiler, and librustdoc (also because rust-lang#140887 missed the conditional in one of the crates as it was behind the "rustc" feature). We keep `core` as exercise for the future as updating it is non-trivial (see PR thread).

Fix Rust for Linux ping group label Noticed in rust-lang#140966 (comment). Seems like a broken label can cause the triagebot ping message to not be issued. See rust-lang/triagebot#1992. ``@rustbot`` label: +A-rust-for-linux

Rollup of 6 pull requests Successful merges: - rust-lang#127013 (Add `f16` formatting and parsing) - rust-lang#140154 (Cygwin support in rustc) - rust-lang#140628 (std: stop using TLS in signal handler) - rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc) - rust-lang#140994 (replace `cc_detect::cc2ar` with `cc::try_get_archiver`) - rust-lang#141127 (bump windows crate for compiler,bootstrap and tools) r? `@ghost` `@rustbot` modify labels: rollup

Fix Rust for Linux ping group label Noticed in rust-lang#140966 (comment). Seems like a broken label can cause the triagebot ping message to not be issued. See rust-lang/triagebot#1992. ```@rustbot``` label: +A-rust-for-linux

Rollup of 8 pull requests Successful merges: - rust-lang#140113 (Add per page TOC in the `rustc` book) - rust-lang#140511 (Stabilize `#![feature(non_null_from_ref)]`) - rust-lang#140924 (Make some `f32`/`f64` tests also run in const-context) - rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc) - rust-lang#141045 ([win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test) - rust-lang#141071 (Enable [behind-upstream] triagebot option for rust-lang/rust) - rust-lang#141132 (Use `crate::` prefix for root macro suggestions) - rust-lang#141139 (Fix Rust for Linux ping group label) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#141139 - jieyouxu:fix-rfl, r=Urgau Fix Rust for Linux ping group label Noticed in rust-lang#140966 (comment). Seems like a broken label can cause the triagebot ping message to not be issued. See rust-lang/triagebot#1992. ```@rustbot``` label: +A-rust-for-linux

Rollup merge of rust-lang#140966 - est31:let_chains_library, r=tgross35 Remove #![feature(let_chains)] from library and src/librustdoc PR rust-lang#132833 has stabilized the `let_chains` feature. This PR removes the last occurences from the library, the compiler, and librustdoc (also because rust-lang#140887 missed the conditional in one of the crates as it was behind the "rustc" feature). We keep `core` as exercise for the future as updating it is non-trivial (see PR thread).

Fix Rust for Linux ping group label Noticed in rust-lang/rust#140966 (comment). Seems like a broken label can cause the triagebot ping message to not be issued. See rust-lang/triagebot#1992. ```@rustbot``` label: +A-rust-for-linux

Remove #![feature(let_chains)] from library and src/librustdoc PR rust-lang#132833 has stabilized the `let_chains` feature. This PR removes the last occurences from the library, the compiler, and librustdoc (also because rust-lang#140887 missed the conditional in one of the crates as it was behind the "rustc" feature). We keep `core` as exercise for the future as updating it is non-trivial (see PR thread).

Remove #![feature(let_chains)] from libcore PR #132833 has stabilized the let_chains feature. This PR removes the last occurrence from the library. Split out of #140966 as it caused breakage. Now we have a patch to the linux tree that fixes the build, so we update the linux tree to it. cc Rust-for-Linux/linux#1163 cc #140722

Remove #![feature(let_chains)] from libcore PR rust-lang#132833 has stabilized the let_chains feature. This PR removes the last occurrence from the library. Split out of rust-lang#140966 as it caused breakage. Now we have a patch to the linux tree that fixes the build, so we update the linux tree to it. cc Rust-for-Linux/linux#1163 cc rust-lang#140722

rustbot assigned jhpratt May 13, 2025

est31 mentioned this pull request May 13, 2025

let_chains stabilization followups #140722

Closed

8 tasks

This comment has been minimized.

Sign in to view

est31 force-pushed the let_chains_library branch from 46001c1 to 79b2794 Compare May 13, 2025 22:22

rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label May 13, 2025

tgross35 approved these changes May 14, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2025

tgross35 assigned tgross35 and unassigned jhpratt May 15, 2025

matthiaskrgr mentioned this pull request May 15, 2025

Rollup of 8 pull requests #141040

Closed

compiler-errors mentioned this pull request May 15, 2025

Rollup of 14 pull requests #141041

Closed

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 15, 2025

Remove #![feature(let_chains)] from library and src/librustdoc

258e880

est31 force-pushed the let_chains_library branch from 5013a97 to 258e880 Compare May 16, 2025 14:14

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2025

This was referenced May 17, 2025

Missing label in a ping definition causes the ping to fail rust-lang/triagebot#1992

Open

Fix Rust for Linux ping group label #141139

Merged

fmease mentioned this pull request May 18, 2025

Rollup of 6 pull requests #141208

Closed

fmease mentioned this pull request May 18, 2025

Rollup of 8 pull requests #141216

Merged

ojeda mentioned this pull request May 18, 2025

Rust CI wanted features & bugfixes Rust-for-Linux/linux#1080

Open

21 tasks

bors merged commit eb21b25 into rust-lang:master May 18, 2025
6 checks passed

rustbot added this to the 1.89.0 milestone May 18, 2025

est31 mentioned this pull request May 23, 2025

Remove #![feature(let_chains)] from libcore #141415

Merged

Uh oh!

Conversation

est31 commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 13, 2025

Uh oh!

rustbot commented May 13, 2025

Uh oh!

This comment has been minimized.

samueltardieu commented May 13, 2025

Uh oh!

rustbot commented May 13, 2025

Uh oh!

est31 commented May 14, 2025

Uh oh!

tgross35 commented May 14, 2025

Uh oh!

bors commented May 14, 2025

Uh oh!

bors commented May 14, 2025

Uh oh!

matthiaskrgr commented May 15, 2025

Uh oh!

tgross35 commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

est31 commented May 16, 2025

Uh oh!

tgross35 commented May 16, 2025

Uh oh!

bors commented May 16, 2025

Uh oh!

nbdd0121 commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

est31 commented May 13, 2025 •

edited

Loading

tgross35 commented May 16, 2025 •

edited

Loading

nbdd0121 commented May 17, 2025 •

edited

Loading

jieyouxu commented May 17, 2025 •

edited

Loading